From: Flavio Stanchina <flavio@stanchina.net>
To: Peter Osterlund <petero2@telia.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
trond.myklebust@fys.uio.no
Subject: Re: Linux 2.6.7-rc2
Date: Thu, 03 Jun 2004 22:01:49 +0200 [thread overview]
Message-ID: <40BF83AD.1020401@stanchina.net> (raw)
In-Reply-To: <m34qpw5k4h.fsf@telia.com>
Peter Osterlund wrote:
> [patch to linux/fs/nfs/read.c]
> + memset(rdata, 0, sizeof(*rdata));
> + rdata->flags = (IS_SWAPFILE(inode)? NFS_RPC_SWAPFLAGS : 0);
Wouldn't this be better as:
if (IS_SWAPFILE(inode))
rdata->flags = NFS_RPC_SWAPFLAGS;
> + rdata->args.pgbase = 0UL;
Wouldn't this be redundant?
--
Ciao, Flavio
next prev parent reply other threads:[~2004-06-03 20:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-30 6:52 Linux 2.6.7-rc2 Linus Torvalds
2004-05-30 7:56 ` Danny ter Haar
2004-05-30 11:09 ` Francois Romieu
2004-05-30 13:16 ` Danny ter Haar
2004-05-30 13:24 ` Danny ter Haar
2004-05-30 16:26 ` Malte Schröder
2004-05-30 17:26 ` Jeff Garzik
2004-05-31 9:21 ` Peter Osterlund
2004-05-31 9:27 ` Andrew Morton
2004-05-31 16:58 ` Linus Torvalds
2004-05-31 22:04 ` Peter Osterlund
2004-06-03 20:01 ` Flavio Stanchina [this message]
2004-06-01 3:44 ` Linux 2.6.7-rc2 (compile stats) John Cherry
2004-06-01 16:07 ` 2.6.7-rc2: .bss.page_aligned warning with gcc 2.95 Adrian Bunk
2004-06-02 14:37 ` Linux 2.6.7-rc2 Thomas Zehetbauer
2004-06-04 14:06 ` Denis Vlasenko
2004-06-08 17:02 ` Bill Davidsen
2004-06-08 18:02 ` David Ford
2004-06-09 6:37 ` sk98lin (was: Re: Linux 2.6.7-rc2) Geert Uytterhoeven
2004-06-10 15:03 ` SCSI_DPT_I2O " Geert Uytterhoeven
2004-06-10 15:33 ` ide-proc.c " Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2004-05-31 12:20 Linux 2.6.7-rc2 Albert Cahalan
2004-05-31 16:53 ` Linus Torvalds
2004-05-31 15:12 ` Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40BF83AD.1020401@stanchina.net \
--to=flavio@stanchina.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.