All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: PATCH: ethtool power manglement hooks
Date: Mon, 07 Jun 2004 14:19:41 -0400	[thread overview]
Message-ID: <40C4B1BD.1020503@pobox.com> (raw)
In-Reply-To: <20040607155018.GA5810@devserv.devel.redhat.com>

Alan Cox wrote:
> Several ethernet drivers have been broken by the ethtool support because
> the ioctl code used to power the interface up and down as needed. Rather
> than add this to each driver call Jeff Garzik suggested we add hooks
> for before/after ethtool processing.
> 
> This patch implements them which makes fixing the PM stuff easier,
> as the epic100 patch to follow will show. It also cleans up the 
> via-velocity driver pm/ethtool logic a great deal. As per Jeff's
> request the before handler is allowed to fail the operation.

Thanks A.

BTW, if you have a free moment, I don't think all your comments from 
your months-ago review of net/core/ethtool.c were addressed.  A 
re-review would be appreciated.  In the meantime, I'm hunting around for 
your original review.

	Jeff




  reply	other threads:[~2004-06-07 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-07 15:50 PATCH: ethtool power manglement hooks Alan Cox
2004-06-07 18:19 ` Jeff Garzik [this message]
2004-06-08 18:02 ` Jeff Garzik
2004-06-08 18:29 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40C4B1BD.1020503@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.