All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Picco <Robert.Picco@hp.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] discontig.c
Date: Thu, 10 Jun 2004 15:23:28 +0000	[thread overview]
Message-ID: <40C87CF0.7070206@hp.com> (raw)

Hi David and Andrew:

I found a problem with HP NUMA configuration in 2.6.7-rc3-mm1.  The 
node_online_map is incorrect
because of actions taken by reassign_cpu_only_nodes in 
arch/ia64/mm/discontig.c.  The mm1 patch
which changes the mempolicy for the init_task uses this invalid 
node_online_map and eventually uses a
non-existent node's zonelist when calling __alloc_pages. 

The patch below takes care of this issue.  It puts the non-existent 
nodes offline.

thanks,

Bob

diff -ruN -X /home/picco/losl/dontdiff linux-2.6.7-rc3-m1.orig/arch/ia64/mm/discontig.c linux-2.6.7-rc3-m1.hpet/arch/ia64/mm/discontig.c
--- linux-2.6.7-rc3-m1.orig/arch/ia64/mm/discontig.c	2004-06-07 15:14:58.000000000 -0400
+++ linux-2.6.7-rc3-m1.hpet/arch/ia64/mm/discontig.c	2004-06-09 18:44:02.000000000 -0400
@@ -154,6 +154,9 @@
 
 	memcpy(numa_slit, numa_slit_fix, sizeof (numa_slit));
 
+	for (i = nnode; i < numnodes; i++)
+		node_set_offline(i);
+
 	numnodes = nnode;
 
 	return;




             reply	other threads:[~2004-06-10 15:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-10 15:23 Robert Picco [this message]
2004-06-10 18:10 ` [PATCH] discontig.c David Mosberger
2004-06-10 20:00 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40C87CF0.7070206@hp.com \
    --to=robert.picco@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.