From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Andrew Morton <akpm@osdl.org>
Cc: herbert@gondor.apana.org.au, pavel@suse.cz,
mochel@digitalimplant.org, linux-kernel@vger.kernel.org
Subject: Re: Fix memory leak in swsusp
Date: Sun, 13 Jun 2004 08:07:57 +1000 [thread overview]
Message-ID: <40CB7EBD.2020109@linuxmail.org> (raw)
In-Reply-To: <20040611210059.2522e02d.akpm@osdl.org>
Hi.
Andrew Morton wrote:
> Nigel Cunningham <ncunningham@linuxmail.org> wrote:
>
>> We were avoiding the use of memcpy because it messes up the preempt count with 3DNow, and
>> potentially as other unseen side effects. The preempt could possibly simply be reset at resume time,
>> but the point remains.
>
>
> eh? memcpy just copies memory. Maybe your meant copy_*_user()?
At some stage, you copy the page that contains the preempt count for the process that is doing the
suspending. If you use memcpy on a 3Dnow machine, the preempt count is incremented prior to doing
the copy of the page. Then, at resume time, it is one too high.
Regards,
Nigel
--
Nigel & Michelle Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (417) 100 574 (mobile)
next prev parent reply other threads:[~2004-06-12 22:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 13:04 Fix memory leak in swsusp Pavel Machek
2004-06-10 10:50 ` Herbert Xu
2004-06-10 10:56 ` Herbert Xu
2004-06-10 20:08 ` Pavel Machek
2004-06-10 21:24 ` Pavel Machek
2004-06-10 23:37 ` Herbert Xu
2004-06-11 9:48 ` Pavel Machek
2004-06-11 10:16 ` Herbert Xu
2004-06-11 10:23 ` Pavel Machek
2004-06-11 11:03 ` Herbert Xu
2004-06-12 3:17 ` Nigel Cunningham
2004-06-12 4:00 ` Andrew Morton
2004-06-12 11:10 ` Dave Jones
2004-06-13 15:59 ` Pavel Machek
2004-06-12 22:07 ` Nigel Cunningham [this message]
2004-06-12 23:32 ` Jeff Sipek
2004-06-13 15:57 ` Pavel Machek
2004-06-13 8:15 ` Herbert Xu
2004-06-12 6:45 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2004-06-12 10:45 pavel
2004-06-12 22:09 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CB7EBD.2020109@linuxmail.org \
--to=ncunningham@linuxmail.org \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.