From: Patrick McHardy <kaber@trash.net>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: ip_queue_vwmark for pom-ng
Date: Sun, 13 Jun 2004 23:39:00 +0200 [thread overview]
Message-ID: <40CCC974.9080807@trash.net> (raw)
In-Reply-To: <1087160421.3320.5.camel@coati>
Eric Leblond wrote:
> On Sun, 2004-06-13 at 22:11, Patrick McHardy wrote:
>
>>On Thu, 2004-06-10 at 23:31, Eric Leblond wrote:
>>Applied, thanks Eric. Am I right that this patch doesn't break userspace
>>compatiblity ?
>
> I add to change the definition of a structure related to libipq. So it
> can break compatibility of application using the size of this structure.
The kernel itself verifies the size of the structure when receiving
messages from userspace. I missed that you enlarged the structure. Since
it breaks compatibility with old binaries anyway, why didn't you just
add the mark to ipq_verdict_msg instead of duplicating it and adding
ipq_set_vwmark, which is 99% equal to ipq_set_verdict?
Regards
Patrick
>
> But It should not impact libipq applications.
>
> Regards
next prev parent reply other threads:[~2004-06-13 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 21:31 ip_queue_vwmark for pom-ng Eric Leblond
2004-06-13 20:11 ` Patrick McHardy
2004-06-13 21:00 ` Eric Leblond
2004-06-13 21:39 ` Patrick McHardy [this message]
2004-06-13 23:29 ` Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CCC974.9080807@trash.net \
--to=kaber@trash.net \
--cc=eric@inl.fr \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.