All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org
Subject: noisy reservation conflicts
Date: Mon, 14 Jun 2004 16:01:40 +1000	[thread overview]
Message-ID: <40CD3F44.4080004@torque.net> (raw)

While testing persistent reservations it is quite common
to get a status of "reservation conflict". When using
the SG_IO ioctl this status is returned via the
sg_io_hdr::status field and is simple to process.

However this lk 2.6.7-rc3 code fragment in
scsi_decide_disposition() [scsi_error.c] makes it very
noisy (on the console and in the log):

         case RESERVATION_CONFLICT:
                 printk("scsi%d (%d,%d,%d) : reservation conflict\n",
                        scmd->device->host->host_no,
                        scmd->device->channel,
                        scmd->device->id, scmd->device->lun);
                 return SUCCESS; /* causes immediate i/o error */

The unadorned printk() looks like debugging code. Could this
be softened, or removed in the case of a RQ_SPECIAL?

Doug Gilbert


             reply	other threads:[~2004-06-14  6:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-14  6:01 Douglas Gilbert [this message]
2004-06-14 19:18 ` noisy reservation conflicts Mike Anderson
2004-06-15 12:54   ` Doug Ledford
2004-06-25  6:17   ` [PATCH] lk 2.6.7-bk6 [Re: noisy reservation conflicts] Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40CD3F44.4080004@torque.net \
    --to=dougg@torque.net \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.