All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"Martin J. Bligh" <mbligh@aracnet.com>,
	mingo@elte.hu, kernel@kolivas.org, linux-kernel@vger.kernel.org,
	piggin@cyberone.com.au, akpm@osdl.org, wli@holomorphy.com,
	markw@osdl.org
Subject: Re: [PATCH] Performance regression in 2.6.7-rc3
Date: Wed, 16 Jun 2004 13:18:51 +1000	[thread overview]
Message-ID: <40CFBC1B.6000400@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.58.0406152009220.4142@ppc970.osdl.org>

Linus Torvalds wrote:
> 
> On Wed, 16 Jun 2004, Nick Piggin wrote:
> 
>>I think balance on clone probably needs to be turned off by default
>>presently.
>>
>>It slows down a simple thread creation test by a factor of 7(!) here,
>>and has quite a few not too difficult to imagine performance problems.
> 
> 
> I agree. However, I still think we should do my suggested
> "wake_up_new(p,clone_flags)" thing, and then have the logic on whether to 
> try to care about threading or not be in schedule.c, not in kernel/fork.c.
> 
> The fact is, fork.c shouldn't try to make scheduling decisions. But it 
> could inform the scheduler about the new process, and THAT can then make 
> the decisions.
> 

I agree, it is a fine suggestion. Would be a trivial change, and
would clean things up nicely.

  reply	other threads:[~2004-06-16  3:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-12  0:28 [PATCH] Performance regression in 2.6.7-rc3 Con Kolivas
2004-06-12  7:58 ` Nick Piggin
2004-06-15  4:56 ` Ingo Molnar
2004-06-15 13:11   ` Con Kolivas
2004-06-15 15:02   ` Martin J. Bligh
2004-06-16  2:14     ` Herbert Xu
2004-06-16  3:05       ` Nick Piggin
2004-06-16  3:10         ` Linus Torvalds
2004-06-16  3:18           ` Nick Piggin [this message]
2004-06-16  7:02           ` Ingo Molnar
2004-06-16  3:09       ` Linus Torvalds
2004-06-16 14:54         ` Martin J. Bligh
2004-06-16  3:00   ` Nick Piggin
2004-06-16  1:22     ` Con Kolivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40CFBC1B.6000400@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markw@osdl.org \
    --cc=mbligh@aracnet.com \
    --cc=mingo@elte.hu \
    --cc=piggin@cyberone.com.au \
    --cc=torvalds@osdl.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.