All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: David Howells <dhowells@redhat.com>,
	Nuno Monteiro <nuno@itsari.org>,
	linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com
Subject: Re: [2.4] build error with latest BK
Date: Wed, 16 Jun 2004 19:04:31 +1000	[thread overview]
Message-ID: <40D00D1F.8070109@yahoo.com.au> (raw)
In-Reply-To: <16592.3188.448186.438659@alkaid.it.uu.se>

Mikael Pettersson wrote:
> Nick Piggin writes:
>  > David Howells wrote:
>  > >>-		put_task_struct(tsk);
>  > >>+		task_unlock(tsk);
>  > > 
>  > > 
>  > > Ummm... that doesn't look right.
>  > > 
>  > > 
>  > >>-	get_task_struct(tsk);
>  > > 
>  > > 
>  > > This is necessary to stop someone deallocating the task structure, can the
>  > > task structure be deallocated whilst locked?
>  > > 
>  > 
>  > Ooh maybe it can. Should that be a read_lock of the tasklist lock then?
> 
> For 2.4 kernels, use get_task_struct() and free_task_struct() [not put]
> for locking and unlocking a task.
> 

Sorry I'm an idiot. I'm sure Marcelo has already fixed it.
Just simply replace put_task_struct with free_task_struct.

  reply	other threads:[~2004-06-16  9:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-15 16:48 [2.4] build error with latest BK Nuno Monteiro
2004-06-16  2:38 ` Nick Piggin
2004-06-16  8:20   ` David Howells
2004-06-16  8:43     ` Nick Piggin
2004-06-16  9:01       ` Mikael Pettersson
2004-06-16  9:04         ` Nick Piggin [this message]
2004-06-16 13:40           ` Nuno Monteiro
2004-06-16 13:57             ` Marcelo Tosatti
2004-06-16 15:07           ` [2.4] build error with latest BK [fixed patch] Nuno Monteiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40D00D1F.8070109@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=mikpe@csd.uu.se \
    --cc=nuno@itsari.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.