All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Schirmer <jolt@tuxbox.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>, akpm <akpm@osdl.org>,
	B.Zolnierkiewicz@elka.pw.edu.pl, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [STACK] >3k call path in ide
Date: Wed, 16 Jun 2004 11:55:52 +0200	[thread overview]
Message-ID: <40D01928.1080309@tuxbox.org> (raw)
In-Reply-To: <20040616094737.GA2548@wohnheim.fh-wedel.de>

Hi,

>Leak memory.  I also tend to depend on the fact that kfree(NULL) works
>just fine:
>
>err_kfree:
>	kfree(cfginfo);
>	kfree(def_cte);
>	kfree(tbuf);
>	printk(KERN_NOTICE "ide-cs: ide_config failed memory allocation\n");
>	goto failed;
>
>Makes the error path a little simpler.
>  
>

Nope. It will deadlock just like the original patch because failed falls 
through to err_kfree which then will jump to failed...

Regards,
    Florian


  reply	other threads:[~2004-06-16  9:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-09 12:29 [STACK] >3k call path in ide Jörn Engel
2004-06-09 15:23 ` Michael Clark
2004-06-09 16:29   ` Jörn Engel
2004-06-09 19:27     ` Andrew Morton
2004-06-10 22:59       ` Jörn Engel
2004-06-10 23:10         ` Andrew Morton
2004-06-11 10:53           ` Jörn Engel
2004-10-15  1:58           ` Rusty Russell
2004-06-15 23:34 ` [PATCH] " Randy.Dunlap
2004-06-16  7:11   ` Florian Schirmer
2004-06-16  9:47     ` Jörn Engel
2004-06-16  9:55       ` Florian Schirmer [this message]
2004-06-16 10:00         ` Jörn Engel
2004-06-16 17:37           ` [PATCH] [STACK] reduce " Randy.Dunlap
2004-06-16 17:57             ` Jörn Engel
2004-06-16 18:16               ` Randy.Dunlap
2004-06-16 18:29                 ` Jörn Engel
2004-06-16 18:49                   ` Randy.Dunlap
2004-06-16 18:58             ` Brian Gerst
2004-06-16 19:52               ` Randy.Dunlap
2004-06-16 22:53                 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40D01928.1080309@tuxbox.org \
    --to=jolt@tuxbox.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@osdl.org \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.