From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ed Wildgoose <lists@wildgooses.com>
Date: Fri, 18 Jun 2004 09:41:49 +0000
Subject: Re: [LARTC] Help:how to generate different packets?souce code explanation?
Message-Id: <40D2B8DD.2080606@wildgooses.com>
List-Id: <lartc.vger.kernel.org>
References: <20040618023313.98B464498@outpost.ds9a.nl>
In-Reply-To: <20040618023313.98B464498@outpost.ds9a.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: lartc@vger.kernel.org


>	Another question:I am studying sch_htb.c,but it's so tough for to understand,especially htb_dequeue().Would anyone please supply some adivse?
>  
>

Hmm, well I will set you a problem. I have been looking at sch_htb.c as
well, but I don't understand the marked line below (won't it mean that
we double count the stats for this packet?):


static int htb_enqueue(struct sk_buff *skb, struct Qdisc *sch)
{
struct htb_sched *q = (struct htb_sched *)sch->data;
struct htb_class *cl = htb_classify(skb,sch);

if (cl = HTB_DIRECT || !cl) {
/* enqueue to helper queue */
if (q->direct_queue.qlen < q->direct_qlen && cl) {
__skb_queue_tail(&q->direct_queue, skb);
q->direct_pkts++;
} else {
kfree_skb (skb);
sch->stats.drops++;
return NET_XMIT_DROP;
}
} else if (cl->un.leaf.q->enqueue(skb, cl->un.leaf.q) != NET_XMIT_SUCCESS) {
sch->stats.drops++;
cl->stats.drops++;
return NET_XMIT_DROP;
} else {
->> cl->stats.packets++; cl->stats.bytes += skb->len;
htb_activate (q,cl);
}

sch->q.qlen++;
sch->stats.packets++; sch->stats.bytes += skb->len;
HTB_DBG(1,1,"htb_enq_ok cl=%X skb=%p\n",(cl && cl !HTB_DIRECT)?cl->classid:0,skb);
return NET_XMIT_SUCCESS;
}


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/