Re: 2.6.7-ck1

[Con Kolivas <kernel@kolivas.org>]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

Con Kolivas wrote:
> On Sat, 19 Jun 2004 04:35, Grzegorz Kulewski wrote:
> 
>>Hi Con,
>>
>>I have two problems with 2.6.7-ck1. My distribution is Gentoo Linux
>>unstable with all latest updates. Oh, yes, both 2.6.7-ck1 and 2.6.7-rc3
>>I tested have vesafb-tng applied from http://dev.gentoo.org/~spock/, but
>>it should not cause any problems because it is very non-intrusive patch I
>>think. Maybe you should include this in your patchset?
>>
>>1. When booting init script freezes after starting input hotplugging (it
>>is udev system). The only way to make it run is to press Ctrl-Alt-SysRQ
>>and various keys to display kernel state several times. After that system
>>starts normally. I do not know if it is only -ck problem because I had
>>no time to test 2.6.7 vanilla, but 2.6.7-rc3 worked fine. (Log included.)
> 
> 
> Yes I have a sneaking suspicion it's related to the fact kernel threads are 
> fixed priority at the moment in staircase (they dont descend priority like 
> normal tasks so act like relatively low priority real time tasks). I'm 
> addressing that for the next version so hopefully that will fix it.

Here's a diff for -ck1 which brings you up to staircase7.1
Can you try that?

Con

[-- Attachment #2: from-2.6.7-ck1_to_staircase7.1 --]
[-- Type: text/x-troff-man, Size: 426 bytes --]

--- linux-2.6.7-ck2pre/kernel/sched.c	2004-06-19 15:12:15.280924354 +1000
+++ linux-2.6.7-ck1/kernel/sched.c	2004-06-19 14:58:08.000000000 +1000
@@ -334,8 +334,7 @@ static int effective_prio(task_t *p)
 
 	if (used_slice < first_slice)
 		return prio;
-	if (p->mm)
-		prio += 1 + (used_slice - first_slice) / rr;
+	prio += 1 + (used_slice - first_slice) / rr;
 	if (prio > MAX_PRIO - 2)
 		prio = MAX_PRIO - 2;
 	return prio;