From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1BbaOi-0002wi-OU
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 03:36:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1BbaOi-0002wA-2r
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 03:36:20 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1BbaOh-0002w5-Vt
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 03:36:20 -0400
Received: from [195.9.147.9] (helo=dionis.simtreas.ru)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1BbaNA-0004DM-3n
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 03:34:44 -0400
Message-ID: <40D3ED57.2040506@simtreas.ru>
Date: Sat, 19 Jun 2004 11:37:59 +0400
From: "Vladimir N. Oleynik" <dzo@simtreas.ru>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] security_20040618
References: <200406181841.i5IIfZQa019337@treas.simtreas.ru>
In-Reply-To: <200406181841.i5IIfZQa019337@treas.simtreas.ru>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, tim-qemu@sentinelchicken.org

Tim,

 > Updates to this, from the previous version two days ago, include
 > additional strcpy replacements,

 > --- qemu-current/monitor.c	2004-06-16 20:49:59.000000000 -0700
 > +++ qemu-dev/monitor.c	2004-06-17 22:12:49.000000000 -0700
 >                  str = qemu_malloc(strlen(buf) + 1);
 > -                strcpy(str, buf);
 > +                pstrcpy(str, strlen(buf) + 1,  buf);

In my opinion, it already absolutely unnecessary correction.
There is in this place no problem.


--w
vodz