From: Robert Picco <Robert.Picco@hp.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hpet related
Date: Mon, 28 Jun 2004 17:23:18 -0400 [thread overview]
Message-ID: <40E08C46.6050302@hp.com> (raw)
In-Reply-To: <20040628132704.50874705.akpm@osdl.org>
Sure. I'll make the change and resend patch.
Andrew Morton wrote:
>Robert Picco <Robert.Picco@hp.com> wrote:
>
>
>>+static inline void hpet_timer_reserved(struct hpet_data *hd, int timer)
>> +{
>> + hd->hd_state |= (1 << timer);
>> + return;
>> +}
>>
>>
>
>The identifier "hpet_timer_reserved" implies (to me) that the function
>queries something. Except it doesn't.
>
>Would "hpet_reserve_timer" be a better choice?
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
prev parent reply other threads:[~2004-06-28 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 18:09 [PATCH] hpet related Robert Picco
2004-06-28 20:27 ` Andrew Morton
2004-06-28 21:23 ` Robert Picco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E08C46.6050302@hp.com \
--to=robert.picco@hp.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.