From: Sylvain Munaut <tnt@246tnt.com>
To: mcclintock@freescale.com
Cc: Adrian Cox <adrian@humboldt.co.uk>,
Embedded Linux PPC list <linuxppc-embedded@lists.linuxppc.org>,
"Kumar K. Gala" <kumar.gala@motorola.com>,
Matthew McClintock <mcclintock@motorola.com>
Subject: Re: [PATCH][RFC]Updated MPC I2C driver
Date: Thu, 01 Jul 2004 23:07:07 +0200 [thread overview]
Message-ID: <40E47CFB.7090106@246tNt.com> (raw)
In-Reply-To: <1088696887.7555.70.camel@matthew-laptop>
Matthew McClintock wrote:
> The blocks look very similar, you might want to look at the follow
> up patch I just sent that abstracts the read/writes. It might be as
> simple as abstracting another read/write function for your
> particular platform.
>
Yes
I'd say they are identical in fact. I kind of forgot that readl/writel
does a endianness correction. So in fact this driver should work for
the MPC5200.
My only concern is about interrupts.
MPC5200 has two I2C port:
* One is MBAR + 0x3D00
* Second is MBAR + 0x3D40
At MBAR + 0x3D20 there is an interrupt control register for the I2C
ports ( shared, 4bits for the first port, 4bits for the second).
It controls for what reason an I2C interrupt should be fired. I don't
know if there is a similar register on the other, I'll look up the
datasheets.
Sylvain Munaut
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-07-01 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 18:19 [PATCH][RFC]Updated MPC I2C driver Adrian Cox
2004-07-01 14:59 ` Matthew McClintock
2004-07-01 21:25 ` Adrian Cox
2004-07-01 22:32 ` Sylvain Munaut
2004-07-02 9:05 ` Adrian Cox
2004-07-02 11:01 ` Sylvain Munaut
2004-07-02 13:44 ` Adrian Cox
2004-07-02 15:11 ` Sylvain Munaut
2004-07-01 18:59 ` Eugene Surovegin
2004-07-01 19:20 ` Sylvain Munaut
2004-07-01 15:48 ` Matthew McClintock
2004-07-01 21:07 ` Sylvain Munaut [this message]
2004-07-01 20:54 ` Adrian Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E47CFB.7090106@246tNt.com \
--to=tnt@246tnt.com \
--cc=adrian@humboldt.co.uk \
--cc=kumar.gala@motorola.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=mcclintock@freescale.com \
--cc=mcclintock@motorola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.