From: Jeff Garzik <jgarzik@pobox.com>
To: Stelian Pop <stelian@popies.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6] meye driver update (wait_ms -> msleep)
Date: Fri, 02 Jul 2004 10:40:30 -0400 [thread overview]
Message-ID: <40E573DE.6090303@pobox.com> (raw)
In-Reply-To: <20040702140825.GD2942@crusoe.alcove-fr>
Stelian Pop wrote:
> ===== drivers/media/video/meye.c 1.21 vs edited =====
> --- 1.21/drivers/media/video/meye.c 2004-03-19 07:04:56 +01:00
> +++ edited/drivers/media/video/meye.c 2004-07-02 10:58:36 +02:00
> @@ -473,16 +473,6 @@
> /* MCHIP low-level functions */
> /****************************************************************************/
>
> -/* waits for the specified miliseconds */
> -static inline void wait_ms(unsigned int ms) {
> - if (!in_interrupt()) {
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(1 + ms * HZ / 1000);
> - }
> - else
> - mdelay(ms);
> -}
> -
I was worried about in_interrupt() removal (when you unconditionally use
msleep), so I reviewed this in-depth. Looks OK to me.
ACK
Jeff
next prev parent reply other threads:[~2004-07-02 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 14:08 [PATCH 2.6] meye driver update (wait_ms -> msleep) Stelian Pop
2004-07-02 14:40 ` Jeff Garzik [this message]
2004-07-02 15:04 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E573DE.6090303@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stelian@popies.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.