Clemens Buchacher wrote:
> I've replaced the custom MIN/MAX macros in drivers/ide/ide-timing.h with
> the corresponding min/max macros from kernel.h, as suggested by the TODO
> list.

One advice: Before doing stuff on the todo list, ask on the mailing list 
if anybodys working on it. This could save you some time.

Otherwise the patch looks good to me, but next time also tell against 
which version it is. 2.6.7 I presume?

Greetings,
Veeck