Re: [PATCH] Update in-kernel orinoco drivers to upstream current CVS

[Michael Clark <michael@metaparadigm.com>]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Just like to chime in as a tester. I've been running the orinoco CVS
for around 6 weeks now. Has been very stable although I needed the
attached patch to make suspend/resume work (thinkpad with APM).

I posted a bug on orinoco savannah but haven't seen any changes in CVS.

BTW - what is the *correct* ordering of pci_(save|restore)_state,
pci_set_power_state?

The new scanning functionality is great. Thanks guys for the good work.

~mc

On 07/07/04 06:54, Francois Romieu wrote:
> Jeff Garzik <jgarzik@pobox.com> :
> 
>>Francois Romieu wrote:
>>
>>>The news:
>>>- I got the adequate patch from the cvs repository
>>>- 35 patches are available at the usual location. The series-mm file
>>>  describes the ordering of the patches. I'll redo the numbering as
>>>  it starts to be scary
>>>- the remaining diff weights ~210k so far
>>>
>>>At least it makes reviewing easier.
>>
>>
>>If you are willing to do some re-diffing, feel free to send out the 
>>boring, and easy-to-review parts such as netdev_priv() or obvious 
>>cleanups.  That would help, at least, to cut things to more meat, and 
>>less noise.
> 
> 
> Actually it does not induce a noticeable noise. The remaining patch is
> down to 162 ko. 50 ko have disappeared while partially moving code on
> the target sources (I'll keep this part separated from the "normal"
> patches).
> 
> The renumbered patches + one or two new ones are available at
> http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.7-mm6

[-- Attachment #2: orinoco-fix-powerstate.patch --]
[-- Type: text/x-patch, Size: 552 bytes --]

--- orinoco_pci.c.orig	2004-06-21 20:35:22.000000000 +0800
+++ orinoco_pci.c	2004-06-22 12:32:24.000000000 +0800
@@ -327,8 +327,8 @@
 	
 	orinoco_unlock(priv, &flags);
 
-	pci_set_power_state(pdev, 3);
 	pci_save_state(pdev, card->pci_state);
+	pci_set_power_state(pdev, 3);
 
 	return 0;
 }
@@ -343,8 +343,8 @@
 
 	printk(KERN_DEBUG "%s: Orinoco-PCI waking up\n", dev->name);
 
-	pci_restore_state(pdev, card->pci_state);
 	pci_set_power_state(pdev, 0);
+	pci_restore_state(pdev, card->pci_state);
 
 	err = orinoco_reinit_firmware(dev);
 	if (err) {