All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: William Lee Irwin III <wli@holomorphy.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-mm6
Date: Wed, 07 Jul 2004 12:29:32 +1000	[thread overview]
Message-ID: <40EB600C.8020603@yahoo.com.au> (raw)
In-Reply-To: <20040706170247.5bca760c.davem@redhat.com>

David S. Miller wrote:
> On Tue, 6 Jul 2004 16:36:18 -0700
> William Lee Irwin III <wli@holomorphy.com> wrote:
> 
> 
>>I have it isolated down to the sched-clean-init-idle.patch and
>>sched-clean-fork.patch. sched-clean-init-idle.patch fails to build without
>>the second of those two applied, so I didn't do any work to narrow it down
>>further.
> 
> 
> One thing to note is that we don't currently call the
> wake_up_forked_process() thing in our SMP idle bootup
> dispatcher in arch/sparc64/kernel/smp.c
> 
> Perhaps that is somehow related to the problems.
> In that case the culprit would be the first patch,
> sched-clean-init-idle.patch
> 

Yes, I missed sparc64 due to the lack of wake_up_forked_process. Dang.

Well, what used to happen is that wake_up_forked_process would put the
idle task on the runqueue like a regular process, then init_idle would
take it off again.

However after the patch, init_idle simply does all the work itself,
and doesn't have to deal with removal from the runqueue. Now sparc64
uses "kernel_thread" to clone its idle tasks, which *does* put the
process onto the runqueue. init_idle then also makes it the idle task.
This is probably why it blows up.

I guess another small function to remove the task from the runqueue
before calling init_idle for those arches that want it would be the
way to go.

Sorry, this is my fault. Got to run now, but I'll send a patch to try
in a few hours if someone hasn't already.

  reply	other threads:[~2004-07-07  2:29 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-05  9:31 2.6.7-mm6 Andrew Morton
2004-07-05 10:18 ` 2.6.7-mm6 Christoph Hellwig
2004-07-05 10:44   ` 2.6.7-mm6 Christoph Hellwig
2004-07-05 10:32 ` 2.6.7-mm6 Redeeman
2004-07-05 13:54   ` 2.6.7-mm6 Frieder Buerzele
2004-07-05 14:41     ` 2.6.7-mm6 Redeeman
2004-07-05 10:39 ` 2.6.7-mm6 Martin Zwickel
2004-07-05 19:04 ` 2.6.7-mm6 Jurgen Kramer
2004-07-05 20:38 ` 2.6.7-mm6 - ppc32 inconsistent kallsyms data Joseph Fannin
2004-07-05 20:54   ` Andrew Morton
2004-07-06  2:06   ` Keith Owens
2004-07-06  7:31     ` Keith Owens
2004-07-06  7:43       ` Keith Owens
2004-07-06 20:54         ` Joseph Fannin
2004-07-06  9:09       ` Rusty Russell
2004-07-06 12:28         ` Keith Owens
2004-07-05 22:52 ` 2.6.7-mm6: ALSA: vortex_asXtalkGainsAllChan multiple definitions Adrian Bunk
2004-07-05 22:56 ` [patch] 2.6.7-mm6: let CDROM_PKTCDVD depend on experimental Adrian Bunk
2004-07-06  6:49 ` USB Lockups with 2.6.7-mm6, was Re: 2.6.7-mm6 Ralf Hildebrandt
2004-07-06 12:54 ` 2.6.7-mm6 William Lee Irwin III
2004-07-06 17:51   ` 2.6.7-mm6 Dmitry Torokhov
2004-07-06 18:55     ` 2.6.7-mm6 Jan-Benedict Glaw
2004-07-06 23:12     ` 2.6.7-mm6 William Lee Irwin III
2004-07-06 23:55       ` 2.6.7-mm6 William Lee Irwin III
2004-07-07  5:15       ` 2.6.7-mm6 Dmitry Torokhov
2004-07-07  6:37         ` 2.6.7-mm6 William Lee Irwin III
2004-07-07 12:47           ` 2.6.7-mm6 Dmitry Torokhov
2004-07-07 12:55             ` 2.6.7-mm6 William Lee Irwin III
2004-07-07 16:31         ` 2.6.7-mm6 Vojtech Pavlik
2004-07-07 17:15           ` 2.6.7-mm6 Dmitry Torokhov
2004-07-07 19:05             ` 2.6.7-mm6 Vojtech Pavlik
2004-07-06 22:34   ` 2.6.7-mm6 Andrew Morton
2004-07-06 22:45     ` 2.6.7-mm6 David S. Miller
2004-07-06 22:52       ` 2.6.7-mm6 William Lee Irwin III
2004-07-06 23:07         ` 2.6.7-mm6 Russell King
2004-07-06 23:36   ` 2.6.7-mm6 William Lee Irwin III
2004-07-07  0:02     ` 2.6.7-mm6 David S. Miller
2004-07-07  2:29       ` Nick Piggin [this message]
2004-07-07  7:35       ` 2.6.7-mm6 Ingo Molnar
2004-07-07 21:02         ` 2.6.7-mm6 David S. Miller
2004-07-09  2:45           ` 2.6.7-mm6 Nick Piggin
2004-07-09  2:51             ` 2.6.7-mm6 William Lee Irwin III
2004-07-09  5:09               ` 2.6.7-mm6 Nick Piggin
2004-07-09  6:29                 ` 2.6.7-mm6 Ingo Molnar
2004-07-09  6:58                 ` 2.6.7-mm6 William Lee Irwin III
2004-07-09  7:07                   ` 2.6.7-mm6 Nick Piggin
2004-07-09  7:16                     ` 2.6.7-mm6 William Lee Irwin III
2004-07-06 14:49 ` 2.6.7-mm6 - USB problems Jesse Stockall
2004-07-07 16:44 ` 2.6.7-mm6 Jesse Barnes
  -- strict thread matches above, loose matches on Subject: below --
2004-07-05 14:41 2.6.7-mm6 Martin Knoblauch
2004-07-06 13:42 2.6.7-mm6 Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40EB600C.8020603@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.