From: Sylvain Munaut <tnt@246tnt.com>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/2] Freescale MPC52xx support for 2.6 - Base part
Date: Fri, 09 Jul 2004 02:30:04 +0200 [thread overview]
Message-ID: <40EDE70C.40202@246tNt.com> (raw)
In-Reply-To: <17F799EA-D13C-11D8-A787-000393DBC2E8@freescale.com>
Kumar Gala wrote:
> A few comments:
>
> cputable.c: * the 8280/52xx, maybe we should just have G2_LE, (same
> core exists in 8272, 8249, etc.)
IMHO, yes it may be better.
> mpc52xx_setup.c: * what is cpu_52xx[]?
A table with coefficients taken from datasheet. They're used to
compute the core frequency according to XLB bus frequency and external
jumper configurations.
> ppcboot.h: * was bi_immr_base not sufficient?
I suppose your question is why create bi_mbar_base instead of using immr.
Well, I guess that would work just fine. The structure is just taken
straight from U-Boot sources.
If the question was if I really need to add fields for the frequency,
then the answer is yes. (Else, I must measure them which takes times and
is inherently less precise).
Sylvain Munaut
next prev parent reply other threads:[~2004-07-09 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-08 16:54 [PATCH 1/2] Freescale MPC52xx support for 2.6 - Base part Sylvain Munaut
2004-07-09 0:08 ` Kumar Gala
2004-07-09 0:30 ` Sylvain Munaut [this message]
2004-07-09 15:51 ` Kumar Gala
2004-07-09 16:22 ` Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40EDE70C.40202@246tNt.com \
--to=tnt@246tnt.com \
--cc=akpm@osdl.org \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.