From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: amb_talk() (msleep)
Date: Tue, 13 Jul 2004 16:47:41 +0000 [thread overview]
Message-ID: <40F4122D.2040700@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
Sorry, I forgot two other locations with the same problem:
drivers/atm/idt77252.c::idt77252_close()
drivers/atm/lanai.c::lanai_shutdown_tx_vci()
-Nish
Nishanth Aravamudan wrote:
> Hi,
>
> In continuing to replace, where appropriate, code with msleep() calls, I
> ran across drivers/atm/ambassador.c::amb_talk():
>
> <snip>
> // 2.2 second wait (must not touch doorbell during 2 second DMA test)
> timeout = HZ*22/10;
> while (timeout)
> timeout = schedule_timeout (timeout);
> // give the adapter another half second?
> timeout = HZ/2;
> <snip>
>
> There is no call to set_current_state() before these timeouts are
> scheduled and thus they will return immediately. If someone could tell
> me which state (TASK_INTERRUPTIBLE or TASK_UNINTERRUPTIBLE) is desired,
> I can fix this and perhaps replace the calls with msleep().
>
> Thanks,
> Nish
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors
>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2004-07-13 16:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F4122D.2040700@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.