Since I'm not seeing a return value on msleep to be able to tell if it 
terminates prematurely, TASK_UNINTERRUPTIBLE is the preferred state.

Thanks

-Brian

Nishanth Aravamudan wrote:
> Hi,
> 
> In continuing to replace, where appropriate, code with msleep() calls, I 
> ran across the following file(s) / function(s), which do not invoke 
> set_current_state() before schedule_timeout(), which causes the latter 
> to return immediately:
> 
> drivers/scsi/ipr.c::ipr_store_diagnostics()
> 
> If someone could tell me which state (TASK_INTERRUPTIBLE or 
> TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the 
> calls with msleep().
> 
> Thanks,
> Nish
> 

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center