Mark Broadbent wrote:
> --- linux-2.6.7/arch/i386/kernel/apic.c	(revision 1)
> +++ linux-2.6.7/arch/i386/kernel/apic.c	(working copy)
> @@ -40,6 +40,15 @@
>  
>  #include "io_ports.h"
>  
> +/* 
> + * Debug level
> + */
> +extern int apic_verbosity;
> +
> +/* Ensure io_apic can see this level as well */
> +EXPORT_SYMBOL(apic_verbosity);


Your patch looks OK to me except for one small bit, above.

First, you should put the 'extern int apic_verbosity' in a header, 
presumeably the same header into which you stashed 
APIC_{QUIET,VERBOSE,DEBUG} definitions.

Second, it is highly unlikely that this symbol should be exported to 
kernel modules.

	Jeff