Re: [PATCH] NFS: Zeroing NFS and kNFSD stats

[Steve Dickson <SteveD@redhat.com>]

J. Bruce Fields wrote:

>On Tue, Jul 13, 2004 at 11:17:59AM -0400, J. Bruce Fields wrote:
>  
>
>>On Tue, Jul 13, 2004 at 11:08:08AM -0400, Steve Dickson wrote:
>>    
>>
>>>Starting up a test run, zeroing out the stats give you a very clear
>>>picture of what exactly is going on...
>>>      
>>>
>>But you could exactly the same thing by recording the values at the
>>beginning of the test run and then subtracting.  In practice this is
>>likely to be annoying, so you'd want to write utilities that did this
>>for you, like say
>>    
>>
IMHO,  its much simpler, easier and less error prone to zero them out 
than to make nfsstat
take samples then calculate the differences... I just think that a bit 
over nfsstat's head...

>>checkpoint_stats stats.txt
>>display_stats --since stats.txt
>>
>>That'd do what you want, right?
>>    
>>
>
>The problem I have, by the way, is that zeroing is going to cause
>confusing problems whenever there are two simultaneous attempts to
>collect statistics.
>
>For example, imagine that your NFS server has a persistent
>performance-monitoring daemon that checks the statistics every now and
>then and emails the adminstrator a summary once a week.
>
>Then imagine that one day you have a problem with the server, so you log
>in and do a quick check of some statistics, zeroing them in the process.
>Now the daemon has no more hope of getting its numbers right.  Murphy's
>law being what it is, you and the adminstrator that gets the summary
>email are probably different people, and by the time he/she gets the
>very odd-looking end-of-week report you've forgotten that you zeroed the
>statistics once.  Head-scratching ensues.
>
>Writing a script to do the subtraction is just as simple and avoids any
>such problems.
>  
>
Hang on.... Lets keep this in prospective....  Stats that  calculate bit 
rates,latencies and such (Like the ones
in Chuck's per-mount patchs) should not be zeroed out, since it simply 
does not make sense, due to
the collection issues you've outline... but I contend that the current 
nfsd/rpc stats simply aren't
these type of stats... these are simple activity counters that let you 
know what (if anything) is
happening... I think it would be a very difficult task to try to used 
these counts in any long
term analysis... I just don't think they recored the right type of 
information for that....

but... I do think allowing them to be reinitialized (maybe that's better 
term 8-)) makes
them much more useful than they currently are... TBL, when was the last time
anybody looked at these stats because they are basically unmanageable,
having the ability to zero them out, make them much more useful (imho)....

SteveD.


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs