All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Stephen Frost <sfrost@snowman.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: ipsec patches test: minor compilation and policy match issues
Date: Wed, 14 Jul 2004 03:22:46 +0200	[thread overview]
Message-ID: <40F48AE6.9090302@trash.net> (raw)
In-Reply-To: <20040713161021.GO21419@ns.snowman.net>

Stephen Frost wrote:
> Okay, thanks.  For --reqid...  Do you think that's sufficient to base
> firewall rules off of?  Can it be somehow 'faked' by the
> remote/potentially untrusted side?  That's my main issue.  If it can't
> and will only match if the ipsec packet is valid and coming from that
> network then I don't need to care about --spid and will just use
> --reqid...

It can't be faked, it will always match the reqid of the used SA.
But policy checks happen after the PRE_ROUTING/LOCAL_IN/FORWARD
hooks, so you can't be sure that a packet matching a reqid really
has a source/destination address that is configured in the policy.
Invalid packets will be dropped by the network stack before socket
delivery/forwarding. But this can also happen with --spi matching.

Maybe we should add new policy checks to protect conntrack from these
packets. If they are invalid it shouldn't change state.

Regards
Patrick

> 
> 	Thanks,
> 
> 		Stephen

  reply	other threads:[~2004-07-14  1:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-15 21:20 ipsec patches test: minor compilation and policy match issues Ivan Mitev
2004-04-16 14:11 ` Patrick McHardy
2004-04-24 10:17   ` Ivan Mitev
2004-04-24 11:14     ` Patrick McHardy
2004-04-24 11:51       ` Patrick McHardy
2004-04-24 13:07         ` Ivan Mitev
2004-04-27 18:58     ` Michael Richardson
2004-04-28  0:30       ` Patrick McHardy
2004-04-16 15:21 ` Where is DROP target implemented {Virus Scanned} Qiang
2004-04-16 16:39   ` Patrick McHardy
2004-07-13  2:37 ` ipsec patches test: minor compilation and policy match issues Stephen Frost
2004-07-13  2:54   ` Patrick McHardy
2004-07-13 11:53     ` Stephen Frost
2004-07-13 15:56       ` Patrick McHardy
2004-07-13 16:10         ` Stephen Frost
2004-07-14  1:22           ` Patrick McHardy [this message]
2004-07-14  3:00             ` Stephen Frost
2004-07-14 12:11               ` Patrick McHardy
2004-07-14  3:37             ` Henrik Nordstrom
2004-07-14 12:25               ` Patrick McHardy
2004-07-14 15:05                 ` Henrik Nordstrom
2004-07-23  0:06                   ` Patrick McHardy
2004-07-25  9:40                     ` Henrik Nordstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40F48AE6.9090302@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=sfrost@snowman.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.