Re: Conntrack & NAT question

[Pablo Neira <pablo@eurodev.net>]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi Krisztian,

KOVACS Krisztian wrote:

>  The 'new' parameter means we're updating an entry we've just created.
>So, unless the entry is new, we check whether the tuples in the update
>message are the same as ours. And, unfortunately, I have a few assertion
>failed messages in the logs... :(
>  
>

maybe this could be related to the initialization of the tuple and 
repl_tuple contained in ct_sync message. I didn't have much time to have 
a look at ct_sync implementation so far, if I'm missing anything, please 
let me know.

regards,
Pablo

[-- Attachment #2: memset.patch --]
[-- Type: text/x-patch, Size: 1232 bytes --]

? memset.patch
Index: Makefile
===================================================================
RCS file: /cvspublic/netfilter-ha/ct_sync/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	30 Jan 2004 20:24:26 -0000	1.3
+++ Makefile	15 Jul 2004 14:14:55 -0000
@@ -1,5 +1,5 @@
 # set to your kernel tree
-KERNEL  = /usr/src/linux-ctsync
+KERNEL  = /usr/src/new/linux-2.4.24
 
 # get the Linux architecture. Needed to find proper include file for CFLAGS
 ARCH=$(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e s/sa110/arm/)
Index: ct_sync_main.c
===================================================================
RCS file: /cvspublic/netfilter-ha/ct_sync/ct_sync_main.c,v
retrieving revision 1.30
diff -u -r1.30 ct_sync_main.c
--- ct_sync_main.c	13 Jul 2004 14:53:41 -0000	1.30
+++ ct_sync_main.c	15 Jul 2004 14:14:58 -0000
@@ -164,6 +164,9 @@
 	hdr->resource = CT_SYNC_RES_CONNTRACK;
 	hdr->len = __constant_htons(sizeof(*sct));
 
+	memset(&sct->orig, 0, sizeof(struct ip_conntrack_tuple));
+	memset(&sct->reply, 0, sizeof(struct ip_conntrack_tuple));
+
 	/* copy data from conntrack struct */
 	memcpy(&sct->orig, &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple, 
 		sizeof(sct->orig));