Re: [PATCH] ipt_ULOG delays packets caught by filter

[Pablo Neira <pablo@eurodev.net>]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi,

ruby joker wrote:

>Maybe bug is hard to notice but it decrease ulog reliability.
>[1] http://lists.netfilter.org/pipermail/netfilter-devel/2004-June/015860.html
>  
>

I think that this behaviour is related to the default qthreshold value. 
If I'm not wrong, we could fix this problem setting the default value to 
0 instead of 1. In that case we need to update the iptables man page. If 
I'm missing something, please let me know.

regards,
Pablo

[-- Attachment #2: ulog.patch --]
[-- Type: text/x-patch, Size: 368 bytes --]

diff -u -r1.1.1.1 ipt_ULOG.h
--- a/include/linux/netfilter_ipv4/ipt_ULOG.h	11 May 2004 13:35:40 -0000	1.1.1.1
+++ b/include/linux/netfilter_ipv4/ipt_ULOG.h	20 Jul 2004 00:34:30 -0000
@@ -12,7 +12,7 @@
 #endif
 
 #define ULOG_DEFAULT_NLGROUP	1
-#define ULOG_DEFAULT_QTHRESHOLD	1
+#define ULOG_DEFAULT_QTHRESHOLD	0
 
 #define ULOG_MAC_LEN	80
 #define ULOG_PREFIX_LEN	32

[-- Attachment #3: man.patch --]
[-- Type: text/x-patch, Size: 658 bytes --]

Index: libipt_ULOG.man
===================================================================
RCS file: /cvspublic/iptables/extensions/libipt_ULOG.man,v
retrieving revision 1.1
diff -u -r1.1 libipt_ULOG.man
--- libipt_ULOG.man	22 Jan 2004 15:04:24 -0000	1.1
+++ libipt_ULOG.man	20 Jul 2004 00:55:33 -0000
@@ -22,6 +22,6 @@
 .BI "--ulog-qthreshold " "size"
 Number of packet to queue inside kernel.  Setting this value to, e.g. 10
 accumulates ten packets inside the kernel and transmits them as one
-netlink multipart message to userspace.  Default is 1 (for backwards
+netlink multipart message to userspace.  Default is 0 (for backwards
 compatibility).
 .br