From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] small correction
Date: Tue, 20 Jul 2004 21:29:45 +0200 [thread overview]
Message-ID: <40FD72A9.7050400@bellard.org> (raw)
In-Reply-To: <20040720134912.3efb2ec3.jani@iv.ro>
This is not a bug. It is an optimisation to have 16 byte alignment for
faster array accesses.
Fabrice.
Jani Monoses wrote:
> io_mem_read and io_mem_write's second dimension is 3 not 4 since there are 3
> functions - byte,word,dword.
>
> Jani
>
>
> ------------------------------------------------------------------------
>
> Index: exec-all.h
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/exec-all.h,v
> retrieving revision 1.21
> diff -u -r1.21 exec-all.h
> --- exec-all.h 10 Jul 2004 15:15:39 -0000 1.21
> +++ exec-all.h 20 Jul 2004 10:47:37 -0000
> @@ -382,8 +382,8 @@
>
> #endif
>
> -extern CPUWriteMemoryFunc *io_mem_write[IO_MEM_NB_ENTRIES][4];
> -extern CPUReadMemoryFunc *io_mem_read[IO_MEM_NB_ENTRIES][4];
> +extern CPUWriteMemoryFunc *io_mem_write[IO_MEM_NB_ENTRIES][3];
> +extern CPUReadMemoryFunc *io_mem_read[IO_MEM_NB_ENTRIES][3];
> extern void *io_mem_opaque[IO_MEM_NB_ENTRIES];
>
> #ifdef __powerpc__
> Index: exec.c
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/exec.c,v
> retrieving revision 1.44
> diff -u -r1.44 exec.c
> --- exec.c 5 Jul 2004 21:25:10 -0000 1.44
> +++ exec.c 20 Jul 2004 10:47:39 -0000
> @@ -115,8 +115,8 @@
> #endif
>
> /* io memory support */
> -CPUWriteMemoryFunc *io_mem_write[IO_MEM_NB_ENTRIES][4];
> -CPUReadMemoryFunc *io_mem_read[IO_MEM_NB_ENTRIES][4];
> +CPUWriteMemoryFunc *io_mem_write[IO_MEM_NB_ENTRIES][3];
> +CPUReadMemoryFunc *io_mem_read[IO_MEM_NB_ENTRIES][3];
> void *io_mem_opaque[IO_MEM_NB_ENTRIES];
> static int io_mem_nb;
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
prev parent reply other threads:[~2004-07-20 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 10:49 [Qemu-devel] small correction Jani Monoses
2004-07-20 19:29 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40FD72A9.7050400@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.