From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
"Andrey Grodzovsky"
<andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
Cc: mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Marek.Olsak-5C7GfCeVMHo@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.
Date: Wed, 1 Nov 2017 09:43:53 +0100 [thread overview]
Message-ID: <40a3f3be-a093-7fb2-1144-9ecb6decd149@gmail.com> (raw)
In-Reply-To: <b269c18b-5520-2f26-2545-2b742ee34f2f-otUistvHUpPR7s880joybQ@public.gmane.org>
Am 31.10.2017 um 16:50 schrieb Michel Dänzer:
> On 31/10/17 04:40 PM, Andrey Grodzovsky wrote:
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> [...]
>
>> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
>> index 8f43e93..1155492 100644
>> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
>> +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
>> @@ -256,6 +256,14 @@ static struct radeon_winsys_ctx *amdgpu_ctx_create(struct radeon_winsys *ws)
>> goto error_create;
>> }
>>
>> + if (ctx->ws->reserve_vmid) {
>> + r = amdgpu_vm_reserve_vmid(ctx->ctx, 0);
>> + if (r) {
>> + fprintf(stderr, "amdgpu: amdgpu_cs_ctx_create failed. (%i)\n", r);
> This should say "amdgpu: amdgpu_vm_reserve_vmid failed. (%i)\n".
Not sure when amdgpu_ctx_create() is called, but the VMID is reserved
per process not per context.
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-11-01 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 15:40 [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx Andrey Grodzovsky
2017-10-31 15:50 ` Samuel Pitoiset
[not found] ` <078f3ca7-e108-6ce6-4e07-65d8f569eb45-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-31 15:56 ` Andrey Grodzovsky
2017-10-31 15:50 ` Michel Dänzer
[not found] ` <b269c18b-5520-2f26-2545-2b742ee34f2f-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-10-31 15:57 ` [Mesa-dev] " Marek Olšák
[not found] ` <CAAxE2A4SM3ZZTrN+UUw5mncdSx8e7zMiSGvEE7BgssyVrnyNyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-01 8:49 ` Christian König
2017-11-01 13:39 ` Marek Olšák
2017-11-01 8:43 ` Christian König [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-02 14:50 Andrey Grodzovsky
[not found] ` <1509634239-10807-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2017-11-03 17:26 ` Marek Olšák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a3f3be-a093-7fb2-1144-9ecb6decd149@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Marek.Olsak-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.