From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 3/6] vpci: don't assume that vpci per-device data exists unconditionally
Date: Mon, 24 Oct 2022 18:06:55 +0200 [thread overview]
Message-ID: <40a4b054-1f1c-e87c-c909-93f0bd4b7ee5@suse.com> (raw)
In-Reply-To: <Y1a24cSD9zVZFHn/@Air-de-Roger>
On 24.10.2022 18:01, Roger Pau Monné wrote:
> On Mon, Oct 24, 2022 at 01:04:01PM +0200, Jan Beulich wrote:
>> Furthermore msix_find() iterates over d->arch.hvm.msix_tables, which
>> looks to only ever be added to. Doesn't this list need pruning by
>> vpci_remove_device()? I've noticed this only because of looking at
>> derefs of ->vpci in msix.c - I don't think I can easily see that all
>> of those derefs are once again immune to a pdev losing its ->vpci.
>
> I think you are correct, we are missing a
> list_del(&pdev->vpci->msix->next) in vpci_remove_device(). We will
> however have locking issues with this, as msix_find() doesn't take any
> locks, neither do it's callers. I guess this will be fixed as part of
> the lager add vPCI locking series. Will add another patch to the
> series with the MSIX table removal.
But the locking issue the isn't new then: List insertion can also disturb
msix_find(), can't it?
Jan
next prev parent reply other threads:[~2022-10-24 16:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 9:46 [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding handling Roger Pau Monne
2022-10-20 9:46 ` [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define Roger Pau Monne
2022-10-20 9:57 ` Andrew Cooper
2022-10-20 13:20 ` Anthony PERARD
2022-10-20 9:46 ` [PATCH for-4.17 2/6] test/vpci: fix vPCI test harness to provide pci_get_pdev() Roger Pau Monne
2022-10-20 13:21 ` Anthony PERARD
2022-10-20 9:46 ` [PATCH for-4.17 3/6] vpci: don't assume that vpci per-device data exists unconditionally Roger Pau Monne
2022-10-24 11:04 ` Jan Beulich
2022-10-24 16:01 ` Roger Pau Monné
2022-10-24 16:06 ` Jan Beulich [this message]
2022-10-20 9:46 ` [PATCH for-4.17 4/6] vpci: introduce a local vpci_bar variable to modify_decoding() Roger Pau Monne
2022-10-24 11:05 ` Jan Beulich
2022-10-20 9:46 ` [PATCH for-4.17 5/6] pci: do not disable memory decoding for devices Roger Pau Monne
2022-10-24 11:19 ` Jan Beulich
2022-10-24 12:45 ` Roger Pau Monné
2022-10-24 13:59 ` Jan Beulich
2022-10-24 15:45 ` Roger Pau Monné
2022-10-24 15:56 ` Jan Beulich
2022-10-24 16:24 ` Roger Pau Monné
2022-10-20 9:46 ` [PATCH for-4.17 6/6] vpci: refuse BAR writes only if the BAR is mapped Roger Pau Monne
2022-10-24 11:51 ` Jan Beulich
2022-10-24 15:04 ` Roger Pau Monné
2022-10-24 16:03 ` Jan Beulich
2022-10-20 10:12 ` [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding handling Henry Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a4b054-1f1c-e87c-c909-93f0bd4b7ee5@suse.com \
--to=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.