From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out199-7.us.a.mail.aliyun.com (out199-7.us.a.mail.aliyun.com [47.90.199.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A607B for ; Wed, 17 Aug 2022 02:18:51 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VMT7Q2R_1660701783; Received: from 30.178.80.164(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0VMT7Q2R_1660701783) by smtp.aliyun-inc.com; Wed, 17 Aug 2022 10:03:04 +0800 Message-ID: <40c60196-b30c-359f-e1a2-171a6be45296@linux.alibaba.com> Date: Wed, 17 Aug 2022 10:03:02 +0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v2] mm/dmapool.c: avoid duplicate memset within dma_pool_alloc To: Robin Murphy , Marek Szyprowski , akpm@linux-foundation.org, "linux-arm-kernel@lists.infradead.org" , Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "iommu@lists.linux.dev" References: <1658125690-76930-1-git-send-email-liusong@linux.alibaba.com> <1dbe63ff-5575-745b-653a-a992ae53e1aa@samsung.com> <413d8666-7a82-efd7-6716-13658016ca10@arm.com> From: Liu Song In-Reply-To: <413d8666-7a82-efd7-6716-13658016ca10@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit > On 2022-08-16 13:39, Marek Szyprowski wrote: >> Hi, >> >> On 18.07.2022 08:28, Liu Song wrote: >>> From: Liu Song >>> >>> In "dma_alloc_from_dev_coherent" and "dma_direct_alloc", >>> the allocated memory is explicitly set to 0. >>> >>> A helper function "use_dev_coherent_memory" is introduced here to >>> determine whether the memory is allocated by >>> "dma_alloc_from_dev_coherent". >>> >>> And use "get_dma_ops" to determine whether the memory is allocated by >>> "dma_direct_alloc". >>> >>> After this modification, memory allocated using "dma_pool_zalloc" >>> can avoid >>> duplicate memset. >>> >>> Signed-off-by: Liu Song >> >> This patch landed linux next-20220816. Unfortunately it causes serious >> issues on ARM 32bit systems. I've observed it on ARM 32bit Samsung >> Exynos 5422 based Odroid XU4 board with USB r8152 driver. After applying >> this patch and loading r8152 driver I only the following endless >> messages in the log: >> >> xhci-hcd xhci-hcd.9.auto: WARN Event TRB for slot 1 ep 0 with no TDs >> queued? >> xhci-hcd xhci-hcd.9.auto: WARN Event TRB for slot 1 ep 0 with no TDs >> queued? >> xhci-hcd xhci-hcd.9.auto: WARN Event TRB for slot 1 ep 0 with no TDs >> queued? >> >> It looks that there are drivers which rely on the fact that the dma >> coherent buffers are always zeroed. > > It's not even that, the change here is just obviously broken, since it > ends up entirely ignoring want_init_on_alloc() for devices using > dma-direct. Sure, the memory backing a dma_page is zeroed *once* by > its initial dma-coherent allocation, but who says we're not not > reallocating pool entries from an existing dma_page? > > I'm not convinced it's worth trying to special-case this at all, since > we can only do it reliably for the first pool entry allocated from a > new dma_page, and that will only happen as the pool initially grows to > a suitable size for its working set, after which no further new pages > are likely to be allocated for the lifetime of the pool. Even if there > is a case to be made for doing so, it would need to be based on the > flow through dma_pool_alloc() itself, not some nonsense heuristic on > the device. Hi， First of all, I am very sorry that there are missing branches that have not been considered fully, but there is a possibility that the memset to 0 will be repeated whether re-allocation from the dma pool, and this patch needs to be fixed. Thanks > > Andrew, please drop this patch. > > Thanks, > Robin. > >>> --- >>>    include/linux/dma-map-ops.h | 5 +++++ >>>    mm/dmapool.c                | 5 ++++- >>>    2 files changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/dma-map-ops.h b/include/linux/dma-map-ops.h >>> index 0d5b06b..c29948d 100644 >>> --- a/include/linux/dma-map-ops.h >>> +++ b/include/linux/dma-map-ops.h >>> @@ -171,6 +171,10 @@ int dma_alloc_from_dev_coherent(struct device >>> *dev, ssize_t size, >>>    int dma_release_from_dev_coherent(struct device *dev, int order, >>> void *vaddr); >>>    int dma_mmap_from_dev_coherent(struct device *dev, struct >>> vm_area_struct *vma, >>>            void *cpu_addr, size_t size, int *ret); >>> +static inline bool use_dev_coherent_memory(struct device *dev) >>> +{ >>> +    return dev->dma_mem ? true : false; >>> +} >>>    #else >>>    static inline int dma_declare_coherent_memory(struct device *dev, >>>            phys_addr_t phys_addr, dma_addr_t device_addr, size_t size) >>> @@ -180,6 +184,7 @@ static inline int >>> dma_declare_coherent_memory(struct device *dev, >>>    #define dma_alloc_from_dev_coherent(dev, size, handle, ret) (0) >>>    #define dma_release_from_dev_coherent(dev, order, vaddr) (0) >>>    #define dma_mmap_from_dev_coherent(dev, vma, vaddr, order, ret) (0) >>> +#define use_dev_coherent_memory(dev) (0) >>>    #endif /* CONFIG_DMA_DECLARE_COHERENT */ >>>       #ifdef CONFIG_DMA_GLOBAL_POOL >>> diff --git a/mm/dmapool.c b/mm/dmapool.c >>> index a7eb5d0..6e03530 100644 >>> --- a/mm/dmapool.c >>> +++ b/mm/dmapool.c >>> @@ -21,6 +21,7 @@ >>>       #include >>>    #include >>> +#include >>>    #include >>>    #include >>>    #include >>> @@ -372,7 +373,9 @@ void *dma_pool_alloc(struct dma_pool *pool, >>> gfp_t mem_flags, >>>    #endif >>>        spin_unlock_irqrestore(&pool->lock, flags); >>>    -    if (want_init_on_alloc(mem_flags)) >>> +    if (want_init_on_alloc(mem_flags) && >>> +        !use_dev_coherent_memory(pool->dev) && >>> +        get_dma_ops(pool->dev)) >>>            memset(retval, 0, pool->size); >>>           return retval; >> >> Best regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52F51C25B0E for ; Wed, 17 Aug 2022 02:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=07VIbJ0Pe5z8UrX9i5wtlMHIg8zVfxG1Da1jl+Irbkc=; b=NKKZDOnAAsnd74 w04QRDgKPb828IYeWjXdeKUSPgsZRsa3eYhchw6drXlEZF6QmN7bkeqJNVpkCT9aqsUROc9Np6ZI8 khl9oWMOYpDrRhrN7EhhwkK4qWO5ktWurHhjea+mKswDtqAAtJL0SdpDjV2Fr4dwyCkps6fG+oASb RV0G7OxGaFuXlDXzLsLdgT+33nNcQH47OgWPfwV6FEs2/7dUZurvjWL81EJaTEFcEaiEF14e0RGO4 7nOJlcYF0DQwe1Ro5h+5/cm4HPbFlAamD8RLCkNFX8keyqgeJAmEphhBORvp1lZdaTkV59CYmAHjb pp02Wg4Qjb49h5R7f57w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO8Ot-008r6h-Up; Wed, 17 Aug 2022 02:03:20 +0000 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO8Oq-008qzL-Qk for linux-arm-kernel@lists.infradead.org; Wed, 17 Aug 2022 02:03:18 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VMT7Q2R_1660701783; Received: from 30.178.80.164(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0VMT7Q2R_1660701783) by smtp.aliyun-inc.com; Wed, 17 Aug 2022 10:03:04 +0800 Message-ID: <40c60196-b30c-359f-e1a2-171a6be45296@linux.alibaba.com> Date: Wed, 17 Aug 2022 10:03:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v2] mm/dmapool.c: avoid duplicate memset within dma_pool_alloc To: Robin Murphy , Marek Szyprowski , akpm@linux-foundation.org, "linux-arm-kernel@lists.infradead.org" , Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "iommu@lists.linux.dev" References: <1658125690-76930-1-git-send-email-liusong@linux.alibaba.com> <1dbe63ff-5575-745b-653a-a992ae53e1aa@samsung.com> <413d8666-7a82-efd7-6716-13658016ca10@arm.com> From: Liu Song In-Reply-To: <413d8666-7a82-efd7-6716-13658016ca10@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_190317_076526_B00A3F52 X-CRM114-Status: GOOD ( 24.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PiBPbiAyMDIyLTA4LTE2IDEzOjM5LCBNYXJlayBTenlwcm93c2tpIHdyb3RlOgo+PiBIaSwKPj4K Pj4gT24gMTguMDcuMjAyMiAwODoyOCwgTGl1IFNvbmcgd3JvdGU6Cj4+PiBGcm9tOiBMaXUgU29u ZyA8bGl1c29uZ0BsaW51eC5hbGliYWJhLmNvbT4KPj4+Cj4+PiBJbiAiZG1hX2FsbG9jX2Zyb21f ZGV2X2NvaGVyZW50IiBhbmQgImRtYV9kaXJlY3RfYWxsb2MiLAo+Pj4gdGhlIGFsbG9jYXRlZCBt ZW1vcnkgaXMgZXhwbGljaXRseSBzZXQgdG8gMC4KPj4+Cj4+PiBBIGhlbHBlciBmdW5jdGlvbiAi dXNlX2Rldl9jb2hlcmVudF9tZW1vcnkiIGlzIGludHJvZHVjZWQgaGVyZSB0bwo+Pj4gZGV0ZXJt aW5lIHdoZXRoZXIgdGhlIG1lbW9yeSBpcyBhbGxvY2F0ZWQgYnkgCj4+PiAiZG1hX2FsbG9jX2Zy b21fZGV2X2NvaGVyZW50Ii4KPj4+Cj4+PiBBbmQgdXNlICJnZXRfZG1hX29wcyIgdG8gZGV0ZXJt aW5lIHdoZXRoZXIgdGhlIG1lbW9yeSBpcyBhbGxvY2F0ZWQgYnkKPj4+ICJkbWFfZGlyZWN0X2Fs bG9jIi4KPj4+Cj4+PiBBZnRlciB0aGlzIG1vZGlmaWNhdGlvbiwgbWVtb3J5IGFsbG9jYXRlZCB1 c2luZyAiZG1hX3Bvb2xfemFsbG9jIiAKPj4+IGNhbiBhdm9pZAo+Pj4gZHVwbGljYXRlIG1lbXNl dC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMaXUgU29uZyA8bGl1c29uZ0BsaW51eC5hbGliYWJh LmNvbT4KPj4KPj4gVGhpcyBwYXRjaCBsYW5kZWQgbGludXggbmV4dC0yMDIyMDgxNi4gVW5mb3J0 dW5hdGVseSBpdCBjYXVzZXMgc2VyaW91cwo+PiBpc3N1ZXMgb24gQVJNIDMyYml0IHN5c3RlbXMu IEkndmUgb2JzZXJ2ZWQgaXQgb24gQVJNIDMyYml0IFNhbXN1bmcKPj4gRXh5bm9zIDU0MjIgYmFz ZWQgT2Ryb2lkIFhVNCBib2FyZCB3aXRoIFVTQiByODE1MiBkcml2ZXIuIEFmdGVyIGFwcGx5aW5n Cj4+IHRoaXMgcGF0Y2ggYW5kIGxvYWRpbmcgcjgxNTIgZHJpdmVyIEkgb25seSB0aGUgZm9sbG93 aW5nIGVuZGxlc3MKPj4gbWVzc2FnZXMgaW4gdGhlIGxvZzoKPj4KPj4geGhjaS1oY2QgeGhjaS1o Y2QuOS5hdXRvOiBXQVJOIEV2ZW50IFRSQiBmb3Igc2xvdCAxIGVwIDAgd2l0aCBubyBURHMgCj4+ IHF1ZXVlZD8KPj4geGhjaS1oY2QgeGhjaS1oY2QuOS5hdXRvOiBXQVJOIEV2ZW50IFRSQiBmb3Ig c2xvdCAxIGVwIDAgd2l0aCBubyBURHMgCj4+IHF1ZXVlZD8KPj4geGhjaS1oY2QgeGhjaS1oY2Qu OS5hdXRvOiBXQVJOIEV2ZW50IFRSQiBmb3Igc2xvdCAxIGVwIDAgd2l0aCBubyBURHMgCj4+IHF1 ZXVlZD8KPj4KPj4gSXQgbG9va3MgdGhhdCB0aGVyZSBhcmUgZHJpdmVycyB3aGljaCByZWx5IG9u IHRoZSBmYWN0IHRoYXQgdGhlIGRtYQo+PiBjb2hlcmVudCBidWZmZXJzIGFyZSBhbHdheXMgemVy b2VkLgo+Cj4gSXQncyBub3QgZXZlbiB0aGF0LCB0aGUgY2hhbmdlIGhlcmUgaXMganVzdCBvYnZp b3VzbHkgYnJva2VuLCBzaW5jZSBpdCAKPiBlbmRzIHVwIGVudGlyZWx5IGlnbm9yaW5nIHdhbnRf aW5pdF9vbl9hbGxvYygpIGZvciBkZXZpY2VzIHVzaW5nIAo+IGRtYS1kaXJlY3QuIFN1cmUsIHRo ZSBtZW1vcnkgYmFja2luZyBhIGRtYV9wYWdlIGlzIHplcm9lZCAqb25jZSogYnkgCj4gaXRzIGlu aXRpYWwgZG1hLWNvaGVyZW50IGFsbG9jYXRpb24sIGJ1dCB3aG8gc2F5cyB3ZSdyZSBub3Qgbm90 IAo+IHJlYWxsb2NhdGluZyBwb29sIGVudHJpZXMgZnJvbSBhbiBleGlzdGluZyBkbWFfcGFnZT8K Pgo+IEknbSBub3QgY29udmluY2VkIGl0J3Mgd29ydGggdHJ5aW5nIHRvIHNwZWNpYWwtY2FzZSB0 aGlzIGF0IGFsbCwgc2luY2UgCj4gd2UgY2FuIG9ubHkgZG8gaXQgcmVsaWFibHkgZm9yIHRoZSBm aXJzdCBwb29sIGVudHJ5IGFsbG9jYXRlZCBmcm9tIGEgCj4gbmV3IGRtYV9wYWdlLCBhbmQgdGhh dCB3aWxsIG9ubHkgaGFwcGVuIGFzIHRoZSBwb29sIGluaXRpYWxseSBncm93cyB0byAKPiBhIHN1 aXRhYmxlIHNpemUgZm9yIGl0cyB3b3JraW5nIHNldCwgYWZ0ZXIgd2hpY2ggbm8gZnVydGhlciBu ZXcgcGFnZXMgCj4gYXJlIGxpa2VseSB0byBiZSBhbGxvY2F0ZWQgZm9yIHRoZSBsaWZldGltZSBv ZiB0aGUgcG9vbC4gRXZlbiBpZiB0aGVyZSAKPiBpcyBhIGNhc2UgdG8gYmUgbWFkZSBmb3IgZG9p bmcgc28sIGl0IHdvdWxkIG5lZWQgdG8gYmUgYmFzZWQgb24gdGhlIAo+IGZsb3cgdGhyb3VnaCBk bWFfcG9vbF9hbGxvYygpIGl0c2VsZiwgbm90IHNvbWUgbm9uc2Vuc2UgaGV1cmlzdGljIG9uIAo+ IHRoZSBkZXZpY2UuCgpIae+8jAoKRmlyc3Qgb2YgYWxsLCBJIGFtIHZlcnkgc29ycnkgdGhhdCB0 aGVyZSBhcmUgbWlzc2luZyBicmFuY2hlcyB0aGF0IGhhdmUgCm5vdCBiZWVuIGNvbnNpZGVyZWQg ZnVsbHksCgpidXQgdGhlcmUgaXMgYSBwb3NzaWJpbGl0eSB0aGF0IHRoZSBtZW1zZXQgdG8gMCB3 aWxsIGJlIHJlcGVhdGVkIHdoZXRoZXIgCnJlLWFsbG9jYXRpb24gZnJvbSB0aGUKCmRtYSBwb29s LCBhbmQgdGhpcyBwYXRjaCBuZWVkcyB0byBiZSBmaXhlZC4KCgpUaGFua3MKCgo+Cj4gQW5kcmV3 LCBwbGVhc2UgZHJvcCB0aGlzIHBhdGNoLgo+Cj4gVGhhbmtzLAo+IFJvYmluLgo+Cj4+PiAtLS0K Pj4+IMKgwqAgaW5jbHVkZS9saW51eC9kbWEtbWFwLW9wcy5oIHwgNSArKysrKwo+Pj4gwqDCoCBt bS9kbWFwb29sLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCA1ICsrKystCj4+PiDC oMKgIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Pgo+ Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZG1hLW1hcC1vcHMuaCBiL2luY2x1ZGUvbGlu dXgvZG1hLW1hcC1vcHMuaAo+Pj4gaW5kZXggMGQ1YjA2Yi4uYzI5OTQ4ZCAxMDA2NDQKPj4+IC0t LSBhL2luY2x1ZGUvbGludXgvZG1hLW1hcC1vcHMuaAo+Pj4gKysrIGIvaW5jbHVkZS9saW51eC9k bWEtbWFwLW9wcy5oCj4+PiBAQCAtMTcxLDYgKzE3MSwxMCBAQCBpbnQgZG1hX2FsbG9jX2Zyb21f ZGV2X2NvaGVyZW50KHN0cnVjdCBkZXZpY2UgCj4+PiAqZGV2LCBzc2l6ZV90IHNpemUsCj4+PiDC oMKgIGludCBkbWFfcmVsZWFzZV9mcm9tX2Rldl9jb2hlcmVudChzdHJ1Y3QgZGV2aWNlICpkZXYs IGludCBvcmRlciwgCj4+PiB2b2lkICp2YWRkcik7Cj4+PiDCoMKgIGludCBkbWFfbW1hcF9mcm9t X2Rldl9jb2hlcmVudChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCAKPj4+IHZtX2FyZWFfc3Ry dWN0ICp2bWEsCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2b2lkICpjcHVfYWRkciwgc2l6ZV90 IHNpemUsIGludCAqcmV0KTsKPj4+ICtzdGF0aWMgaW5saW5lIGJvb2wgdXNlX2Rldl9jb2hlcmVu dF9tZW1vcnkoc3RydWN0IGRldmljZSAqZGV2KQo+Pj4gK3sKPj4+ICvCoMKgwqAgcmV0dXJuIGRl di0+ZG1hX21lbSA/IHRydWUgOiBmYWxzZTsKPj4+ICt9Cj4+PiDCoMKgICNlbHNlCj4+PiDCoMKg IHN0YXRpYyBpbmxpbmUgaW50IGRtYV9kZWNsYXJlX2NvaGVyZW50X21lbW9yeShzdHJ1Y3QgZGV2 aWNlICpkZXYsCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwaHlzX2FkZHJfdCBwaHlzX2FkZHIs IGRtYV9hZGRyX3QgZGV2aWNlX2FkZHIsIHNpemVfdCBzaXplKQo+Pj4gQEAgLTE4MCw2ICsxODQs NyBAQCBzdGF0aWMgaW5saW5lIGludCAKPj4+IGRtYV9kZWNsYXJlX2NvaGVyZW50X21lbW9yeShz dHJ1Y3QgZGV2aWNlICpkZXYsCj4+PiDCoMKgICNkZWZpbmUgZG1hX2FsbG9jX2Zyb21fZGV2X2Nv aGVyZW50KGRldiwgc2l6ZSwgaGFuZGxlLCByZXQpICgwKQo+Pj4gwqDCoCAjZGVmaW5lIGRtYV9y ZWxlYXNlX2Zyb21fZGV2X2NvaGVyZW50KGRldiwgb3JkZXIsIHZhZGRyKSAoMCkKPj4+IMKgwqAg I2RlZmluZSBkbWFfbW1hcF9mcm9tX2Rldl9jb2hlcmVudChkZXYsIHZtYSwgdmFkZHIsIG9yZGVy LCByZXQpICgwKQo+Pj4gKyNkZWZpbmUgdXNlX2Rldl9jb2hlcmVudF9tZW1vcnkoZGV2KSAoMCkK Pj4+IMKgwqAgI2VuZGlmIC8qIENPTkZJR19ETUFfREVDTEFSRV9DT0hFUkVOVCAqLwo+Pj4gwqDC oCDCoMKgICNpZmRlZiBDT05GSUdfRE1BX0dMT0JBTF9QT09MCj4+PiBkaWZmIC0tZ2l0IGEvbW0v ZG1hcG9vbC5jIGIvbW0vZG1hcG9vbC5jCj4+PiBpbmRleCBhN2ViNWQwLi42ZTAzNTMwIDEwMDY0 NAo+Pj4gLS0tIGEvbW0vZG1hcG9vbC5jCj4+PiArKysgYi9tbS9kbWFwb29sLmMKPj4+IEBAIC0y MSw2ICsyMSw3IEBACj4+PiDCoMKgIMKgwqAgI2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgo+Pj4g wqDCoCAjaW5jbHVkZSA8bGludXgvZG1hLW1hcHBpbmcuaD4KPj4+ICsjaW5jbHVkZSA8bGludXgv ZG1hLW1hcC1vcHMuaD4KPj4+IMKgwqAgI2luY2x1ZGUgPGxpbnV4L2RtYXBvb2wuaD4KPj4+IMKg wqAgI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+Pj4gwqDCoCAjaW5jbHVkZSA8bGludXgvbGlz dC5oPgo+Pj4gQEAgLTM3Miw3ICszNzMsOSBAQCB2b2lkICpkbWFfcG9vbF9hbGxvYyhzdHJ1Y3Qg ZG1hX3Bvb2wgKnBvb2wsIAo+Pj4gZ2ZwX3QgbWVtX2ZsYWdzLAo+Pj4gwqDCoCAjZW5kaWYKPj4+ IMKgwqDCoMKgwqDCoCBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZwb29sLT5sb2NrLCBmbGFncyk7 Cj4+PiDCoMKgIC3CoMKgwqAgaWYgKHdhbnRfaW5pdF9vbl9hbGxvYyhtZW1fZmxhZ3MpKQo+Pj4g K8KgwqDCoCBpZiAod2FudF9pbml0X29uX2FsbG9jKG1lbV9mbGFncykgJiYKPj4+ICvCoMKgwqDC oMKgwqDCoCAhdXNlX2Rldl9jb2hlcmVudF9tZW1vcnkocG9vbC0+ZGV2KSAmJgo+Pj4gK8KgwqDC oMKgwqDCoMKgIGdldF9kbWFfb3BzKHBvb2wtPmRldikpCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDC oCBtZW1zZXQocmV0dmFsLCAwLCBwb29sLT5zaXplKTsKPj4+IMKgwqAgwqDCoMKgwqDCoMKgIHJl dHVybiByZXR2YWw7Cj4+Cj4+IEJlc3QgcmVnYXJkcwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=