From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3683EC433E2 for ; Mon, 14 Sep 2020 13:30:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE5E9207BB for ; Mon, 14 Sep 2020 13:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AZo4Zrph" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE5E9207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECD586E0F6; Mon, 14 Sep 2020 13:30:51 +0000 (UTC) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 733106E0F6 for ; Mon, 14 Sep 2020 13:30:50 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id ay8so17570425edb.8 for ; Mon, 14 Sep 2020 06:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=MJZms6QlGOYEjnVyjgzH8924ZUFCbrOAjhB8S+SOw0Q=; b=AZo4Zrph06jSQFMyghqg1VeH/uJOLm2FTxlr/lwLz7LcGc0dGWMtJGTGfIa56pfqRD SfHBHsrbfH2iLoCUhK/MZHqrDpM/JA26F/AGyypmlC8llez2CWnSY5tQ3e2HcDw2L9BQ Idd41N3fpgLMR5/YftegmeplJ+0U4knjuLatzRauZq3iLjrWvmUDIVY8+gM3rBhrXqyO 5fAQ4JfxeJMiJ3yLE4UMugQzETfzbzi9LiAlrW8D3PaHaUUg0XX1Gb8R/XnjddNgeN8y hPH3z3PjWYW7jYaLwy++Ij502YqCHABMpErfK7GUyDUDXbvFsj5PDRunJeTmU9KmumUU 4vjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MJZms6QlGOYEjnVyjgzH8924ZUFCbrOAjhB8S+SOw0Q=; b=JgkpImMpc26NjX/Sfknb9V3MLqlRj/RuTBhvWPfujIo2Gmm5BT0NLk+JXW/glyXf+N r6zlzzsWKC5zSeb6GN7x5WuLi24V7beLi2B60s276BeJg8xmlacLgTkmp19yXyjKQdtP ZQ2URfnnHyXu7vXyicDxTaB7oxPS857pemNx0YDqrn4seLm7Z1VhvNS9O2W5s61I6ipe B5KxdTWBb7V+Cvz9KxkyZrLBp4gAGPkudhW0eCY2FdkYbqYDXjzlfVT/+2BUhdvsrrxG hjqh7cXx1bZOiYYhQb64nBKFIQxAm07jWBHlV5Ey9OdvqOw4ud/0E++1pvzCqDPFC5ta XV8w== X-Gm-Message-State: AOAM531q3PUAm3ohq+zw7qM8YqCiB2sR673Tp3YLstWtkWjakM3v8Zna 7xbRbm2yx3UXWKbf9Jwsk7g= X-Google-Smtp-Source: ABdhPJwM5ZL8+pefIM8N8Pp/HAs1Da9AhS9+TCqXwmw1+Bfwc5H4UJw/fibBFv4vSEBRyYvPybunNQ== X-Received: by 2002:a50:fb15:: with SMTP id d21mr17942730edq.150.1600090249097; Mon, 14 Sep 2020 06:30:49 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id nh1sm7646664ejb.21.2020.09.14.06.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2020 06:30:48 -0700 (PDT) Subject: Re: Changing vma->vm_file in dma_buf_mmap() From: =?UTF-8?Q?Christian_K=c3=b6nig?= To: akpm@linux-foundation.org References: <20200914132920.59183-1-christian.koenig@amd.com> Message-ID: <40cd26ae-b855-4627-5a13-4dcea5d622f6@gmail.com> Date: Mon, 14 Sep 2020 15:30:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200914132920.59183-1-christian.koenig@amd.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QW0gMTQuMDkuMjAgdW0gMTU6Mjkgc2NocmllYiBDaHJpc3RpYW4gS8O2bmlnOgo+IEhpIEFuZHJl dywKClNvcnJ5IGZvcmdvdCB0byBhZGQgRGFuaWVsIGFzIHdlbGwuCgo+Cj4gSSdtIHRoZSBuZXcg RE1BLWJ1ZiBtYWludGFpbmVyIGFuZCBEYW5pZWwgYW5kIG90aGVycyBjYW1lIHVwIHdpdGggcGF0 Y2hlcyBleHRlbmRpbmcgdGhlIHVzZSBvZiB0aGUgZG1hX2J1Zl9tbWFwKCkgZnVuY3Rpb24uCj4K PiBOb3cgdGhpcyBmdW5jdGlvbiBpcyBkb2luZyBzb21ldGhpbmcgYSBiaXQgb2RkIGJ5IGNoYW5n aW5nIHRoZSB2bWEtPnZtX2ZpbGUgd2hpbGUgaW5zdGFsbGluZyBhIFZNQSBpbiB0aGUgbW1hcCgp IHN5c3RlbSBjYWxsCj4KPiBUaGUgYmFja2dyb3VuZCBoZXJlIGlzIHRoYXQgRE1BLWJ1ZiBhbGxv d3MgZGV2aWNlIGRyaXZlcnMgdG8gZXhwb3J0IGJ1ZmZlciB3aGljaCBhcmUgdGhlbiBpbXBvcnRl ZCBpbnRvIGFub3RoZXIgZGV2aWNlIGRyaXZlci4gVGhlIG1tYXAoKSBoYW5kbGVyIG9mIHRoZSBp bXBvcnRpbmcgZGV2aWNlIGRyaXZlciB0aGVuIGZpbmQgdGhhdCB0aGUgcGdvZmYgYmVsb25ncyB0 byB0aGUgZXhwb3J0aW5nIGRldmljZSBhbmQgc28gcmVkaXJlY3RzIHRoZSBtbWFwKCkgY2FsbCB0 aGVyZS4KPgo+IEluIG90aGVyIHdvcmRzIHVzZXIgc3BhY2UgY2FsbHMgbW1hcCgpIG9uIG9uZSBm aWxlIGRlc2NyaXB0b3IsIGJ1dCBnZXQgYSBkaWZmZXJlbnQgb25lIG1hcHBlZCBpbnRvIHlvdXIg dmlydHVhbCBhZGRyZXNzIHNwYWNlLgo+Cj4gTXkgcXVlc3Rpb24gaXMgbm93OiBJcyB0aGF0IGxl Z2FsIG9yIGNhbiB5b3UgdGhpbmsgb2Ygc29tZXRoaW5nIHdoaWNoIGJyZWFrcyBoZXJlPwo+Cj4g SWYgaXQncyBub3QgbGVnYWwgd2Ugc2hvdWxkIHByb2JhYmx5IGJsb2NrIGFueSBuZXcgdXNlcnMg b2YgdGhlIGRtYV9idWZfbW1hcCgpIGZ1bmN0aW9uIGFuZCBjb25zaWRlciB3aGF0IHNob3VsZCBo YXBwZW4gd2l0aCB0aGUgdHdvIGV4aXN0aW5nIG9uZXMuCj4KPiBJZiB0aGF0IGlzIGxlZ2FsIEkg d291bGQgbGlrZSB0byBkb2N1bWVudCB0aGlzIGJ5IGFkZGluZyBhIG5ldyB2bWFfc2V0X2ZpbGUo KSBmdW5jdGlvbiB3aGljaCBkb2VzIHRoZSBuZWNlc3NhcnkgcmVmZXJlbmNlIGNvdW50IGRhbmNl Lgo+Cj4gVGhhbmtzIGluIGFkdmFuY2UsCj4gQ2hyaXN0aWFuLgo+Cj4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2324C433E2 for ; Mon, 14 Sep 2020 13:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6374E207BB for ; Mon, 14 Sep 2020 13:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AZo4Zrph" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgINNgF (ORCPT ); Mon, 14 Sep 2020 09:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbgINNbD (ORCPT ); Mon, 14 Sep 2020 09:31:03 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FFB2C06174A; Mon, 14 Sep 2020 06:30:50 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id c8so17618037edv.5; Mon, 14 Sep 2020 06:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=MJZms6QlGOYEjnVyjgzH8924ZUFCbrOAjhB8S+SOw0Q=; b=AZo4Zrph06jSQFMyghqg1VeH/uJOLm2FTxlr/lwLz7LcGc0dGWMtJGTGfIa56pfqRD SfHBHsrbfH2iLoCUhK/MZHqrDpM/JA26F/AGyypmlC8llez2CWnSY5tQ3e2HcDw2L9BQ Idd41N3fpgLMR5/YftegmeplJ+0U4knjuLatzRauZq3iLjrWvmUDIVY8+gM3rBhrXqyO 5fAQ4JfxeJMiJ3yLE4UMugQzETfzbzi9LiAlrW8D3PaHaUUg0XX1Gb8R/XnjddNgeN8y hPH3z3PjWYW7jYaLwy++Ij502YqCHABMpErfK7GUyDUDXbvFsj5PDRunJeTmU9KmumUU 4vjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MJZms6QlGOYEjnVyjgzH8924ZUFCbrOAjhB8S+SOw0Q=; b=tQmopRIchFop1uP8VbwCaVFZ38Ji6uyJg5aChIM+up+wbszWk8dnt+SY4Vc1l82zda MKSpF0bFvC5sFZOSoAnRKEhjLtqKB0ZzgEUyndwMRxsZIefEIN+QgPt6OVdzhnYFtlsD a9+TwJNejZk1/TCcOuzlo8rkGWXi2APaKhKIW7eBCgqCoJ9JknG7NDNov2VLq1WiXdFz PuhHpAtl/yFVi5ytb+3i6l8HP4tx8P7ECSfEiCcAB68cxI5/nehF+HquiZZILzAvHeAW 8mm1iQ9Juy9tIuopYVrTZBTibaiC2P598q9OCGrMG29tlY4VNmj5mDppHA/LyvUaw/Oe oXpA== X-Gm-Message-State: AOAM530obYZ4wywoWW6KVjRUXb2i4847/L/dNp3H8xoPrpwFlkNo47+T h/EtiiPRi1iTgT827CFU6BNAKs8x3fY= X-Google-Smtp-Source: ABdhPJwM5ZL8+pefIM8N8Pp/HAs1Da9AhS9+TCqXwmw1+Bfwc5H4UJw/fibBFv4vSEBRyYvPybunNQ== X-Received: by 2002:a50:fb15:: with SMTP id d21mr17942730edq.150.1600090249097; Mon, 14 Sep 2020 06:30:49 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id nh1sm7646664ejb.21.2020.09.14.06.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2020 06:30:48 -0700 (PDT) Subject: Re: Changing vma->vm_file in dma_buf_mmap() From: =?UTF-8?Q?Christian_K=c3=b6nig?= To: akpm@linux-foundation.org Cc: sumit.semwal@linaro.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Vetter References: <20200914132920.59183-1-christian.koenig@amd.com> Message-ID: <40cd26ae-b855-4627-5a13-4dcea5d622f6@gmail.com> Date: Mon, 14 Sep 2020 15:30:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200914132920.59183-1-christian.koenig@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Am 14.09.20 um 15:29 schrieb Christian König: > Hi Andrew, Sorry forgot to add Daniel as well. > > I'm the new DMA-buf maintainer and Daniel and others came up with patches extending the use of the dma_buf_mmap() function. > > Now this function is doing something a bit odd by changing the vma->vm_file while installing a VMA in the mmap() system call > > The background here is that DMA-buf allows device drivers to export buffer which are then imported into another device driver. The mmap() handler of the importing device driver then find that the pgoff belongs to the exporting device and so redirects the mmap() call there. > > In other words user space calls mmap() on one file descriptor, but get a different one mapped into your virtual address space. > > My question is now: Is that legal or can you think of something which breaks here? > > If it's not legal we should probably block any new users of the dma_buf_mmap() function and consider what should happen with the two existing ones. > > If that is legal I would like to document this by adding a new vma_set_file() function which does the necessary reference count dance. > > Thanks in advance, > Christian. > >