From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: Simon Ser <contact@emersion.fr>
Subject: Re: [PATCH i-g-t] lib/igt_eld: Fix 88.2kHz/176.4kHz sample rate parsing
Date: Tue, 8 Sep 2026 12:24:06 +0530 [thread overview]
Message-ID: <40cf20af-d61e-4776-b8c2-310967cf2fde@intel.com> (raw)
In-Reply-To: <20260901113313.627816-1-chaitanya.kumar.borah@intel.com>
Hi Chaitanya
On 01-09-2026 05:03 pm, Chaitanya Kumar Borah wrote:
> parse_sad_rate() matched the rounded labels 88000/176000, but ALSA's
> eld proc file reports the exact rates 88200/176400, so those never
> matched and were silently dropped even when present in the ELD:
>
> $ cat /proc/asound/card0/eld#2.4
> [...]
> sad_count 1
> sad0_rates [0x1ee0] 32000 44100 48000 88200 96000 176400 192000
>
> Match the exact rates ALSA reports instead of the rounded ones.
Patch LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
>
> Cc: Simon Ser <contact@emersion.fr>
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
> lib/igt_eld.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_eld.c b/lib/igt_eld.c
> index 4a6f867ab..896ab0e6b 100644
> --- a/lib/igt_eld.c
> +++ b/lib/igt_eld.c
> @@ -76,11 +76,11 @@ static enum cea_sad_sampling_rate parse_sad_rate(const char *value)
> return CEA_SAD_SAMPLING_RATE_44KHZ;
> case 48000:
> return CEA_SAD_SAMPLING_RATE_48KHZ;
> - case 88000:
> + case 88200:
> return CEA_SAD_SAMPLING_RATE_88KHZ;
> case 96000:
> return CEA_SAD_SAMPLING_RATE_96KHZ;
> - case 176000:
> + case 176400:
> return CEA_SAD_SAMPLING_RATE_176KHZ;
> case 192000:
> return CEA_SAD_SAMPLING_RATE_192KHZ;
next prev parent reply other threads:[~2026-09-08 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 11:33 [PATCH i-g-t] lib/igt_eld: Fix 88.2kHz/176.4kHz sample rate parsing Chaitanya Kumar Borah
2026-09-01 23:35 ` ✓ i915.CI.BAT: success for " Patchwork
2026-09-02 15:27 ` ✗ i915.CI.Full: failure " Patchwork
2026-09-08 6:54 ` Sharma, Swati2 [this message]
2026-09-11 11:48 ` ✗ Xe.CI.BAT: failure for lib/igt_eld: Fix 88.2kHz/176.4kHz sample rate parsing (rev2) Patchwork
2026-09-11 12:05 ` ✓ i915.CI.BAT: success " Patchwork
2026-09-11 18:57 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-12 10:11 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40cf20af-d61e-4776-b8c2-310967cf2fde@intel.com \
--to=swati2.sharma@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=contact@emersion.fr \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.