From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7D8C43461 for ; Thu, 17 Sep 2020 04:39:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EC0C2078D for ; Thu, 17 Sep 2020 04:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dklsedSw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EAV3TwJt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EC0C2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JofCLNDIMbXj5VpzP1BWmItBzObAwiOhKztZGBgEXL8=; b=dklsedSwWVcEce jzSQp9eVH73xP19TrCnpCgIP/gqtNa0eL7ctLZemdERaTR7JZgKGGZzZ9RIcah29CMzRyqnKp4PzF jwxLFKtoO4bp2MGB0LR5iOI6PoLcbXB24Kk0H/YP9AHTaIFJnYav17tbvEbNb2uT3kSeuxTh8RW8z NBwAvwRzkIeHOemrx1nEwDlNwrFFgSxL/ChhW7Bxdk1IgbmrnKQvKxCRSwe0NFzh6JsAeb7vNtJSh yXbIJ214EufPN4p91Ms4ARKP26wvToqOh3sRR/Fzrrdz6J7FMUa/up5vIK5ibX0MUkEFocP2hUKDV YAetFNcvOivKT1KA1gow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIlfT-0005H0-Qj; Thu, 17 Sep 2020 04:37:11 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIlfQ-0005G9-LT for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 04:37:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600317427; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1dPSymURtNP+nZr7zQlcglZS0n6hAk+k5COycAfqws=; b=EAV3TwJt43XxrahemiJviougWNLxBeO9E6ceDqw7d+L61aU6GT1tjysL6ZHegnHq9vJ4pj dn5Zm/aHEjKA7jYUHPnedKzYagE9JmTGvwJMRZrXxqzLMjPZj3ws4X5vzfVI7UpdGBAEbd 8UVuI+fMSRqUQdp3S1hx7kn0eMPcx6w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-4kndPzdUMGiVpHBC11496g-1; Thu, 17 Sep 2020 00:37:04 -0400 X-MC-Unique: 4kndPzdUMGiVpHBC11496g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 373B51074641; Thu, 17 Sep 2020 04:37:03 +0000 (UTC) Received: from [10.64.54.113] (vpn2-54-113.bne.redhat.com [10.64.54.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BD5E19D61; Thu, 17 Sep 2020 04:37:00 +0000 (UTC) Subject: Re: [PATCH 2/2] arm64/mm: Enable color zero pages To: Robin Murphy , Will Deacon References: <20200916032523.13011-1-gshan@redhat.com> <20200916032523.13011-3-gshan@redhat.com> <20200916082819.GB27496@willie-the-truck> <77dcab5a-b5f2-a67c-6157-71a5a53db5de@arm.com> From: Gavin Shan Message-ID: <40d87436-c283-9beb-e00d-29faf5ed95f7@redhat.com> Date: Thu, 17 Sep 2020 14:36:58 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <77dcab5a-b5f2-a67c-6157-71a5a53db5de@arm.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_003708_858475_FCE9A5BD X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Cc: mark.rutland@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iaW4sCgpPbiA5LzE2LzIwIDg6NDYgUE0sIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAy MDIwLTA5LTE2IDA5OjI4LCBXaWxsIERlYWNvbiB3cm90ZToKPj4gT24gV2VkLCBTZXAgMTYsIDIw MjAgYXQgMDE6MjU6MjNQTSArMTAwMCwgR2F2aW4gU2hhbiB3cm90ZToKPj4+IFRoaXMgZW5hYmxl cyBjb2xvciB6ZXJvIHBhZ2VzIGJ5IGFsbG9jYXRpbmcgY29udGlnb3VzIHBhZ2UgZnJhbWVzCj4+ PiBmb3IgaXQuIFRoZSBudW1iZXIgb2YgcGFnZXMgZm9yIHRoaXMgaXMgZGV0ZXJtaW5lZCBieSBM MSBkQ2FjaGUKPj4+IChvciBpQ2FjaGUpIHNpemUsIHdoaWNoIGlzIHByb2JiZWQgZnJvbSB0aGUg aGFyZHdhcmUuCj4+Pgo+Pj4gwqDCoMKgICogQWRkIGNhY2hlX3RvdGFsX3NpemUoKSB0byByZXR1 cm4gTDEgZENhY2hlIChvciBpQ2FjaGUpIHNpemUKPj4+Cj4+PiDCoMKgwqAgKiBJbXBsZW1lbnQg c2V0dXBfemVyb19wYWdlcygpLCB3aGljaCBpcyBjYWxsZWQgYWZ0ZXIgdGhlIHBhZ2UKPj4+IMKg wqDCoMKgwqAgYWxsb2NhdG9yIGJlZ2lucyB0byB3b3JrLCB0byBhbGxvY2F0ZSB0aGUgY29udGln b3VzIHBhZ2VzCj4+PiDCoMKgwqDCoMKgIG5lZWRlZCBieSBjb2xvciB6ZXJvIHBhZ2UuCj4+Pgo+ Pj4gwqDCoMKgICogUmV3b3JrZWQgWkVST19QQUdFKCkgYW5kIGRlZmluZSBfX0hBVkVfQ09MT1Jf WkVST19QQUdFLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEdhdmluIFNoYW4gPGdzaGFuQHJlZGhh dC5jb20+Cj4+PiAtLS0KPj4+IMKgIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaMKgwqAg fCAyMiArKysrKysrKysrKysrKysrKysrKwo+Pj4gwqAgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9w Z3RhYmxlLmggfMKgIDkgKysrKysrLS0KPj4+IMKgIGFyY2gvYXJtNjQva2VybmVsL2NhY2hlaW5m by5jwqDCoMKgIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4gwqAgYXJj aC9hcm02NC9tbS9pbml0LmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAzNSArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwo+Pj4gwqAgYXJjaC9hcm02NC9tbS9tbXUuY8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHzCoCA3IC0tLS0tLS0KPj4+IMKgIDUgZmlsZXMgY2hhbmdlZCwg OTggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvYXJj aC9hcm02NC9pbmNsdWRlL2FzbS9jYWNoZS5oIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9jYWNo ZS5oCj4+PiBpbmRleCBhNGQxYjVmNzcxZjYuLjQyMGU5ZGRlMmM1MSAxMDA2NDQKPj4+IC0tLSBh L2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaAo+Pj4gKysrIGIvYXJjaC9hcm02NC9pbmNs dWRlL2FzbS9jYWNoZS5oCj4+PiBAQCAtMzksNiArMzksMjcgQEAKPj4+IMKgICNkZWZpbmUgQ0xJ RFJfTE9DKGNsaWRyKcKgwqDCoCAoKChjbGlkcikgPj4gQ0xJRFJfTE9DX1NISUZUKSAmIDB4NykK Pj4+IMKgICNkZWZpbmUgQ0xJRFJfTE9VSVMoY2xpZHIpwqDCoMKgICgoKGNsaWRyKSA+PiBDTElE Ul9MT1VJU19TSElGVCkgJiAweDcpCj4+PiArI2RlZmluZSBDU1NFTFJfVE5EX1NISUZUwqDCoMKg IDQKPj4+ICsjZGVmaW5lIENTU0VMUl9UTkRfTUFTS8KgwqDCoMKgwqDCoMKgIChVTCgxKSA8PCBD U1NFTFJfVE5EX1NISUZUKQo+Pj4gKyNkZWZpbmUgQ1NTRUxSX0xFVkVMX1NISUZUwqDCoMKgIDEK Pj4+ICsjZGVmaW5lIENTU0VMUl9MRVZFTF9NQVNLwqDCoMKgIChVTCg3KSA8PCBDU1NFTFJfTEVW RUxfU0hJRlQpCj4+PiArI2RlZmluZSBDU1NFTFJfSU5EX1NISUZUwqDCoMKgIDAKPj4+ICsjZGVm aW5lIENTU0VSTF9JTkRfTUFTS8KgwqDCoMKgwqDCoMKgIChVTCgxKSA8PCBDU1NFTFJfSU5EX1NI SUZUKQo+Pj4gKwo+Pj4gKyNkZWZpbmUgQ0NTSURSXzY0X0xTX1NISUZUwqDCoMKgIDAKPj4+ICsj ZGVmaW5lIENDU0lEUl82NF9MU19NQVNLwqDCoMKgIChVTCg3KSA8PCBDQ1NJRFJfNjRfTFNfU0hJ RlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfNjRfQVNTT0NfU0hJRlTCoMKgwqAgMwo+Pj4gKyNkZWZp bmUgQ0NTSURSXzY0X0FTU09DX01BU0vCoMKgwqAgKFVMKDB4MUZGRkZGKSA8PCBDQ1NJRFJfNjRf QVNTT0NfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfNjRfU0VUX1NISUZUwqDCoMKgIDMyCj4+ PiArI2RlZmluZSBDQ1NJRFJfNjRfU0VUX01BU0vCoMKgwqAgKFVMKDB4RkZGRkZGKSA8PCBDQ1NJ RFJfNjRfU0VUX1NISUZUKQo+Pj4gKwo+Pj4gKyNkZWZpbmUgQ0NTSURSXzMyX0xTX1NISUZUwqDC oMKgIDAKPj4+ICsjZGVmaW5lIENDU0lEUl8zMl9MU19NQVNLwqDCoMKgIChVTCg3KSA8PCBDQ1NJ RFJfMzJfTFNfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfMzJfQVNTT0NfU0hJRlTCoMKgwqAg Mwo+Pj4gKyNkZWZpbmUgQ0NTSURSXzMyX0FTU09DX01BU0vCoMKgwqAgKFVMKDB4M0ZGKSA8PCBD Q1NJRFJfMzJfQVNTT0NfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfMzJfU0VUX1NISUZUwqDC oMKgIDEzCj4+PiArI2RlZmluZSBDQ1NJRFJfMzJfU0VUX01BU0vCoMKgwqAgKFVMKDB4N0ZGRikg PDwgQ0NTSURSXzMyX1NFVF9TSElGVCkKPj4KPj4gSSBkb24ndCB0aGluayB3ZSBzaG91bGQgYmUg aW5mZXJyaW5nIGNhY2hlIHN0cnVjdHVyZSBmcm9tIHRoZXNlIHJlZ2lzdGVyCj4+IHZhbHVlcy4g VGhlIEFybSBBUk0gaGVscGZ1bGx5IHNheXM6Cj4+Cj4+IMKgwqAgfCBZb3UgY2Fubm90IG1ha2Ug YW55IGluZmVyZW5jZSBhYm91dCB0aGUgYWN0dWFsIHNpemVzIG9mIGNhY2hlcyBiYXNlZAo+PiDC oMKgIHwgb24gdGhlc2UgcGFyYW1ldGVycy4KPj4KPj4gc28gd2UgbmVlZCB0byB0YWtlIHRoZSB0 b3BvbG9neSBpbmZvcm1hdGlvbiBmcm9tIGVsc2V3aGVyZS4KPiAKPiBZZXMsIHRoZXNlIHJlcHJl c2VudCBwYXJhbWV0ZXJzIGZvciB0aGUgbG93LWxldmVsIGNhY2hlIG1haW50ZW5hbmNlIGJ5IHNl dC93YXkgaW5zdHJ1Y3Rpb25zLCBhbmQgbm90aGluZyBtb3JlLiBUaGVyZSBhcmUgZGVmaW5pdGVs eSBjYXNlcyB3aGVyZSB0aGV5IGRvIG5vdCByZWZsZWN0IHRoZSB1bmRlcmx5aW5nIGNhY2hlIHN0 cnVjdHVyZSAoY29tbWl0IDc5M2FjZjg3MGVhMyBpcyBhbiBvYnZpb3VzIGZpcnN0IGNhbGwpLgo+ IAoKVGhhbmtzIGZvciB5b3VyIGNvbmZpcm1pbmcuIFllYWgsIHRoZSBzeXN0ZW0gcmVnaXN0ZXJz IGFyZW4ndApyZWxpYWJsZSBzaW5jZSB0aGUgY2FjaGUgd2F5L3NldCBhcmUgaGFyZCBjb2RlZCB0 byAxLzEuIEFzIEkKc3VnZ2VzdGVkIGluIGFub3RoZXIgdGhyZWFkLCBBQ1BJIChQUFRUKSB0YWJs ZSB3b3VsZCBiZSBjb3JyZWN0CnBsYWNlIHRvIGdldCBzdWNoIGtpbmQgb2YgaW5mb3JtYXRpb24u CgpbLi4uXQoKQ2hlZXJzLApHYXZpbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D660C433E2 for ; Thu, 17 Sep 2020 04:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 277E12078D for ; Thu, 17 Sep 2020 04:37:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hCXcbk/6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbgIQEhN (ORCPT ); Thu, 17 Sep 2020 00:37:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42797 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726055AbgIQEhL (ORCPT ); Thu, 17 Sep 2020 00:37:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600317429; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1dPSymURtNP+nZr7zQlcglZS0n6hAk+k5COycAfqws=; b=hCXcbk/6KpM/MjWoQYUR+1Ok436cSHMwnqtwUhY8lxcnWgxQ/gPKN61VEs4xWPvTMOYlyS PhMuoZPAMsf4rjNWjcg7lnYSaP2l+09dqscnp6Qq/8+2DV8ynVLjyRvpuSTI52f1U/QB6G 7ol8SWJk1hGY7AFxzw2x1nQTKKvkB/w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-4kndPzdUMGiVpHBC11496g-1; Thu, 17 Sep 2020 00:37:04 -0400 X-MC-Unique: 4kndPzdUMGiVpHBC11496g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 373B51074641; Thu, 17 Sep 2020 04:37:03 +0000 (UTC) Received: from [10.64.54.113] (vpn2-54-113.bne.redhat.com [10.64.54.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BD5E19D61; Thu, 17 Sep 2020 04:37:00 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH 2/2] arm64/mm: Enable color zero pages To: Robin Murphy , Will Deacon Cc: mark.rutland@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org References: <20200916032523.13011-1-gshan@redhat.com> <20200916032523.13011-3-gshan@redhat.com> <20200916082819.GB27496@willie-the-truck> <77dcab5a-b5f2-a67c-6157-71a5a53db5de@arm.com> From: Gavin Shan Message-ID: <40d87436-c283-9beb-e00d-29faf5ed95f7@redhat.com> Date: Thu, 17 Sep 2020 14:36:58 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <77dcab5a-b5f2-a67c-6157-71a5a53db5de@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On 9/16/20 8:46 PM, Robin Murphy wrote: > On 2020-09-16 09:28, Will Deacon wrote: >> On Wed, Sep 16, 2020 at 01:25:23PM +1000, Gavin Shan wrote: >>> This enables color zero pages by allocating contigous page frames >>> for it. The number of pages for this is determined by L1 dCache >>> (or iCache) size, which is probbed from the hardware. >>> >>>     * Add cache_total_size() to return L1 dCache (or iCache) size >>> >>>     * Implement setup_zero_pages(), which is called after the page >>>       allocator begins to work, to allocate the contigous pages >>>       needed by color zero page. >>> >>>     * Reworked ZERO_PAGE() and define __HAVE_COLOR_ZERO_PAGE. >>> >>> Signed-off-by: Gavin Shan >>> --- >>>   arch/arm64/include/asm/cache.h   | 22 ++++++++++++++++++++ >>>   arch/arm64/include/asm/pgtable.h |  9 ++++++-- >>>   arch/arm64/kernel/cacheinfo.c    | 34 +++++++++++++++++++++++++++++++ >>>   arch/arm64/mm/init.c             | 35 ++++++++++++++++++++++++++++++++ >>>   arch/arm64/mm/mmu.c              |  7 ------- >>>   5 files changed, 98 insertions(+), 9 deletions(-) >>> >>> diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cache.h >>> index a4d1b5f771f6..420e9dde2c51 100644 >>> --- a/arch/arm64/include/asm/cache.h >>> +++ b/arch/arm64/include/asm/cache.h >>> @@ -39,6 +39,27 @@ >>>   #define CLIDR_LOC(clidr)    (((clidr) >> CLIDR_LOC_SHIFT) & 0x7) >>>   #define CLIDR_LOUIS(clidr)    (((clidr) >> CLIDR_LOUIS_SHIFT) & 0x7) >>> +#define CSSELR_TND_SHIFT    4 >>> +#define CSSELR_TND_MASK        (UL(1) << CSSELR_TND_SHIFT) >>> +#define CSSELR_LEVEL_SHIFT    1 >>> +#define CSSELR_LEVEL_MASK    (UL(7) << CSSELR_LEVEL_SHIFT) >>> +#define CSSELR_IND_SHIFT    0 >>> +#define CSSERL_IND_MASK        (UL(1) << CSSELR_IND_SHIFT) >>> + >>> +#define CCSIDR_64_LS_SHIFT    0 >>> +#define CCSIDR_64_LS_MASK    (UL(7) << CCSIDR_64_LS_SHIFT) >>> +#define CCSIDR_64_ASSOC_SHIFT    3 >>> +#define CCSIDR_64_ASSOC_MASK    (UL(0x1FFFFF) << CCSIDR_64_ASSOC_SHIFT) >>> +#define CCSIDR_64_SET_SHIFT    32 >>> +#define CCSIDR_64_SET_MASK    (UL(0xFFFFFF) << CCSIDR_64_SET_SHIFT) >>> + >>> +#define CCSIDR_32_LS_SHIFT    0 >>> +#define CCSIDR_32_LS_MASK    (UL(7) << CCSIDR_32_LS_SHIFT) >>> +#define CCSIDR_32_ASSOC_SHIFT    3 >>> +#define CCSIDR_32_ASSOC_MASK    (UL(0x3FF) << CCSIDR_32_ASSOC_SHIFT) >>> +#define CCSIDR_32_SET_SHIFT    13 >>> +#define CCSIDR_32_SET_MASK    (UL(0x7FFF) << CCSIDR_32_SET_SHIFT) >> >> I don't think we should be inferring cache structure from these register >> values. The Arm ARM helpfully says: >> >>    | You cannot make any inference about the actual sizes of caches based >>    | on these parameters. >> >> so we need to take the topology information from elsewhere. > > Yes, these represent parameters for the low-level cache maintenance by set/way instructions, and nothing more. There are definitely cases where they do not reflect the underlying cache structure (commit 793acf870ea3 is an obvious first call). > Thanks for your confirming. Yeah, the system registers aren't reliable since the cache way/set are hard coded to 1/1. As I suggested in another thread, ACPI (PPTT) table would be correct place to get such kind of information. [...] Cheers, Gavin