From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDBA606A32A for ; Fri, 20 Nov 2026 17:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Fdn39dOY Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BD1410E1B2; Fri, 20 Nov 2026 17:04:34 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32C7210E1B2 for ; Fri, 20 Nov 2026 17:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795194267; x=1826730267; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=INjAK4ZCnUeJ5eFRpFdlFRq3+QSlJxMTcaCvIuKPbmU=; b=Fdn39dOYRxZzriUSXQNO94Ao4m+guaZ7cZHQxoueXN3mG7GWYub5Of7s sxnt0dfG9yA+RP05+lrsCJKARTTuSZS7oMTrOa5TxISNoiT4bi2DBDuGx XRuuf9Usd4iIDH57qMAYRUbj9fsXSN6AEqED59rqkiFavvv2ISCy/jnsa Xanv+srzcuMRV72IfCbw1HT5WWHpyPaWf1LAsYUsD0iXomRV/2uO4994U C5/G4Xg5oTlo3kwqun+Y64Gq2A34UO4Q866g1HD64K2OcDW52qZAUu3r7 wHMoHL9NgG4Bs9PquftcTeCCj2E8mbaWLE35SR/XwUAJb2kltvizPOQQ8 A==; X-CSE-ConnectionGUID: PduHI+/iTSaX9MIIapo7gw== X-CSE-MsgGUID: xQWueRY/Tam6IbIWTDDDdQ== X-IronPort-AV: E=McAfee;i="6800,10657,11972"; a="3960113" X-IronPort-AV: E=Sophos;i="6.27,223,1787036400"; d="scan'208";a="3960113" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2026 09:04:26 -0800 X-CSE-ConnectionGUID: Y8kVfqPaQ6KDRCt8Sq1NaA== X-CSE-MsgGUID: LzaOjbIlR7yYGWhqsiWx/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,223,1787036400"; d="scan'208";a="10640432" Received: from abityuts-desk1.ger.corp.intel.com (HELO localhost) ([10.245.245.250]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2026 09:04:25 -0800 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/i915/gvt: Descend to GVT Makefile through kbuild, not include In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20261120155734.259742-1-jani.nikula@intel.com> <20261120155734.259742-2-jani.nikula@intel.com> Date: Fri, 20 Nov 2026 19:04:22 +0200 Message-ID: <40de34776e441b082b4dfa5e1d76ef933ea303e7@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-gfx" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, 20 Nov 2026, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Nov 20, 2026 at 05:57:34PM +0200, Jani Nikula wrote: >> Treat the gvt/ subdirectory and Makefile like a regular kernel driver >> directory, and descend to it through kbuild, not Makefile include. >>=20 >> The main change is that the resulting kvmgt.ko is also placed in the >> gvt/ subdirectory in the build directory. > > Does this also change where the module gets installed finally? Probably. If anyone depends on the exact location, they'll be hosed. BR, Jani. > >>=20 >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/Makefile | 4 +-- >> drivers/gpu/drm/i915/gvt/Makefile | 48 ++++++++++++++++--------------- >> 2 files changed, 27 insertions(+), 25 deletions(-) >>=20 >> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefi= le >> index d4e7764621e1..ba7eecfffdca 100644 >> --- a/drivers/gpu/drm/i915/Makefile >> +++ b/drivers/gpu/drm/i915/Makefile >> @@ -433,10 +433,10 @@ i915-y +=3D \ >> i915-$(CONFIG_DRM_I915_GVT) +=3D \ >> intel_gvt.o \ >> intel_gvt_mmio_table.o >> -include $(src)/gvt/Makefile >>=20=20 >> obj-$(CONFIG_DRM_I915) +=3D i915.o >> -obj-$(CONFIG_DRM_I915_GVT_KVMGT) +=3D kvmgt.o >> + >> +obj-$(CONFIG_DRM_I915_GVT_KVMGT) +=3D gvt/ >>=20=20 >> # kernel-doc test >> # >> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gv= t/Makefile >> index 47f4f6f43c15..dfbf813f672c 100644 >> --- a/drivers/gpu/drm/i915/gvt/Makefile >> +++ b/drivers/gpu/drm/i915/gvt/Makefile >> @@ -1,25 +1,27 @@ >> # SPDX-License-Identifier: GPL-2.0 >>=20=20 >> -kvmgt-$(CONFIG_DRM_I915_GVT) +=3D \ >> - gvt/aperture_gm.o \ >> - gvt/cfg_space.o \ >> - gvt/cmd_parser.o \ >> - gvt/debugfs.o \ >> - gvt/display.o \ >> - gvt/dmabuf.o \ >> - gvt/edid.o \ >> - gvt/execlist.o \ >> - gvt/fb_decoder.o \ >> - gvt/firmware.o \ >> - gvt/gtt.o \ >> - gvt/handlers.o \ >> - gvt/interrupt.o \ >> - gvt/kvmgt_module.o \ >> - gvt/mmio.o \ >> - gvt/mmio_context.o \ >> - gvt/opregion.o \ >> - gvt/page_track.o \ >> - gvt/sched_policy.o \ >> - gvt/scheduler.o \ >> - gvt/trace_points.o \ >> - gvt/vgpu.o >> +kvmgt-y +=3D \ >> + aperture_gm.o \ >> + cfg_space.o \ >> + cmd_parser.o \ >> + debugfs.o \ >> + display.o \ >> + dmabuf.o \ >> + edid.o \ >> + execlist.o \ >> + fb_decoder.o \ >> + firmware.o \ >> + gtt.o \ >> + handlers.o \ >> + interrupt.o \ >> + kvmgt_module.o \ >> + mmio.o \ >> + mmio_context.o \ >> + opregion.o \ >> + page_track.o \ >> + sched_policy.o \ >> + scheduler.o \ >> + trace_points.o \ >> + vgpu.o >> + >> +obj-$(CONFIG_DRM_I915_GVT_KVMGT) +=3D kvmgt.o >> --=20 >> 2.47.3 --=20 Jani Nikula, Intel