Re: [f2fs-dev] [PATCH] f2fs: remove redunant invalidate compress pages

[Chao Yu <chao@kernel.org>]

On 2021/12/21 11:59, 常凤楠 wrote:
>> -----Original Message-----
>> From: 常凤楠
>> Sent: Monday, December 13, 2021 4:59 PM
>> To: jaegeuk@kernel.org; chao@kernel.org
>> Cc: linux-f2fs-devel@lists.sourceforge.net; 常凤楠 <changfengnan@vivo.com>
>> Subject: [PATCH] f2fs: remove redunant invalidate compress pages
>>
>> Compress page will invalidate in truncate block process too, so remove
>> redunant invalidate compress pages in f2fs_evict_inode.
>>
>> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
>> ---
>>   fs/f2fs/inode.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 935016e56010..595270646d69
>> 100644
>> --- a/fs/f2fs/inode.c
>> +++ b/fs/f2fs/inode.c
>> @@ -751,9 +751,6 @@ void f2fs_evict_inode(struct inode *inode)
>>   	trace_f2fs_evict_inode(inode);
>>   	truncate_inode_pages_final(&inode->i_data);
>>
>> -	if (test_opt(sbi, COMPRESS_CACHE) && f2fs_compressed_file(inode))
>> -		f2fs_invalidate_compress_pages(sbi, inode->i_ino);
>> -
> 
> Hi Jaegeuk, chao:
> After https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=662f6acdb0136dfda3d055f00086e2c8ed5c8bfc
> I think this patch still necessary, it could speed up evict inode. f2fs_invalidate_compress_pages find all pages and compare to decide which pages need invalidate, if there are many compressed file cached, it may need much time. And in later truncate block will invalidate page one by one, this may more effective.

Well, for the case inode has non-zero nlink value, it needs to 
invalidate compressed pages after truncate_inode_pages_final(), 
otherwise related compressed pages may be left in memory after inode was 
evicted.

https://www.ansymbol.com/linux/latest/source/fs/f2fs/inode.c#L754

Thanks,

> 
>>   	if (inode->i_ino == F2FS_NODE_INO(sbi) ||
>>   			inode->i_ino == F2FS_META_INO(sbi) ||
>>   			inode->i_ino == F2FS_COMPRESS_INO(sbi))
>> --
>> 2.32.0
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel