Re: [PATCH] ACPI: EC: Use ec_no_wakeup on ThinkPad T14 Gen 5

["Mark Pearson" <mpearson-lenovo@squebb.ca>]

Hi Yutaro,

On Tue, Jun 18, 2024, at 5:51 AM, Yutaro Ohno wrote:
> On ThinkPad T14 Gen 5, EC interrupts constantly wake up the system from
> s2idle, resulting in high power consumption.
>
> This sets `acpi.ec_no_wakeup=1` to fix the high power consumption issue
> in s2idle state.
>
> Signed-off-by: Yutaro Ohno <yutaro.ono.418@gmail.com>
> ---
>  drivers/acpi/ec.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 299ec653388c..c7d5231edca7 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -2248,6 +2248,12 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
>  			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Yoga 3rd"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad T14 Gen 5"),
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> -- 
> 2.45.2

We're doing Linux enablement on the T14 G5 right now - and if this is an issue in the Lenovo FW I would rather fix it there instead of introducing a quirk into the kernel that might later need to be removed. This platform is getting full Linux support.

I'd like to collect some debug details from you (if preferred you can ping me off thread using this email address):

 - Can I get your BIOS, EC and ME versions (easiest is to get these from the BIOS setup screen - F1 during early boot)
 - Get a report from running the Intel S0ix test tool - https://github.com/intel/S0ixSelftestTool. Run it with the -S option
 - There is a known issue if the ethernet is plugged in on this system that Intel are working on - can you confirm if you're using wired networking please?
 - Do you have WWAN enabled? If you have it can you try with WWAN disabled.

I'll also highlight that Linux enablement is not complete on this platform yet, so some patience might be needed.

Thanks
Mark (Lenovo employee working on the Linux PC enablement program)