From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8838CC433F5 for ; Tue, 26 Oct 2021 19:04:18 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A85E60EB9 for ; Tue, 26 Oct 2021 19:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1A85E60EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-lpGONXNcMLW4fJfVdwNrcQ-1; Tue, 26 Oct 2021 15:04:13 -0400 X-MC-Unique: lpGONXNcMLW4fJfVdwNrcQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62D5318414AF; Tue, 26 Oct 2021 19:04:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4669260BF1; Tue, 26 Oct 2021 19:04:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1AC6E18199EE; Tue, 26 Oct 2021 19:04:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19QJ3u6Z022701 for ; Tue, 26 Oct 2021 15:03:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9BC3A400F3F4; Tue, 26 Oct 2021 19:03:56 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97F5640C1242 for ; Tue, 26 Oct 2021 19:03:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8030B811E7F for ; Tue, 26 Oct 2021 19:03:56 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-329-YBRdJdbyOjCTZnCCX8icRA-1; Tue, 26 Oct 2021 15:03:52 -0400 X-MC-Unique: YBRdJdbyOjCTZnCCX8icRA-1 Received: from [10.137.106.139] (unknown [131.107.159.11]) by linux.microsoft.com (Postfix) with ESMTPSA id 403732034CB5; Tue, 26 Oct 2021 12:03:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 403732034CB5 Message-ID: <40f70c77-80eb-2716-be77-9cbcf4770b8a@linux.microsoft.com> Date: Tue, 26 Oct 2021 12:03:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 From: Deven Bowers To: Roberto Sassu , Eric Biggers References: <1634151995-16266-1-git-send-email-deven.desai@linux.microsoft.com> <1634151995-16266-13-git-send-email-deven.desai@linux.microsoft.com> <9089bdb0-b28a-9fa0-c510-00fa275af621@linux.microsoft.com> <5c1f800ba554485cb3659da689d2079a@huawei.com> In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 19QJ3u6Z022701 X-loop: dm-devel@redhat.com Cc: "axboe@kernel.dk" , "linux-security-module@vger.kernel.org" , "tytso@mit.edu" , "paul@paul-moore.com" , "snitzer@redhat.com" , "corbet@lwn.net" , "jannh@google.com" , "linux-doc@vger.kernel.org" , "jmorris@namei.org" , "eparis@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , "linux-audit@redhat.com" , "linux-fscrypt@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "agk@redhat.com" , "serge@hallyn.com" Subject: Re: [dm-devel] [RFC PATCH v7 12/16] fsverity|security: add security hooks to fsverity digest and signature X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Ck9uIDEwLzIyLzIwMjEgOTozMSBBTSwgUm9iZXJ0byBTYXNzdSB3cm90ZToKPj4gRnJvbTogUm9i ZXJ0byBTYXNzdSBbbWFpbHRvOnJvYmVydG8uc2Fzc3VAaHVhd2VpLmNvbV0KPj4gU2VudDogV2Vk bmVzZGF5LCBPY3RvYmVyIDIwLCAyMDIxIDU6MDkgUE0KPj4+IEZyb206IEVyaWMgQmlnZ2VycyBb bWFpbHRvOmViaWdnZXJzQGtlcm5lbC5vcmddCj4+PiBTZW50OiBGcmlkYXksIE9jdG9iZXIgMTUs IDIwMjEgMTA6MTEgUE0KPj4+IE9uIEZyaSwgT2N0IDE1LCAyMDIxIGF0IDEyOjI1OjUzUE0gLTA3 MDAsIERldmVuIEJvd2VycyB3cm90ZToKPj4+PiBPbiAxMC8xMy8yMDIxIDEyOjI0IFBNLCBFcmlj IEJpZ2dlcnMgd3JvdGU6Cj4+Pj4+IE9uIFdlZCwgT2N0IDEzLCAyMDIxIGF0IDEyOjA2OjMxUE0g LTA3MDAsCj4+PiBkZXZlbi5kZXNhaUBsaW51eC5taWNyb3NvZnQuY29tICB3cm90ZToKPj4+Pj4+ IEZyb206IEZhbiBXdTx3dWZhbkBsaW51eC5taWNyb3NvZnQuY29tPgo+Pj4+Pj4KPj4+Pj4+IEFk ZCBzZWN1cml0eV9pbm9kZV9zZXRzZWN1cml0eSB0byBmc3Zlcml0eSBzaWduYXR1cmUgdmVyaWZp Y2F0aW9uLgo+Pj4+Pj4gVGhpcyBjYW4gbGV0IExTTXMgc2F2ZSB0aGUgc2lnbmF0dXJlIGRhdGEg YW5kIGRpZ2VzdCBoYXNoZXMgcHJvdmlkZWQKPj4+Pj4+IGJ5IGZzdmVyaXR5Lgo+Pj4+PiBDYW4g eW91IGVsYWJvcmF0ZSBvbiB3aHkgTFNNcyBuZWVkIHRoaXMgaW5mb3JtYXRpb24/Cj4+Pj4gVGhl IHByb3Bvc2VkIExTTSAoSVBFKSBvZiB0aGlzIHNlcmllcyB3aWxsIGJlIHRoZSBvbmx5IG9uZSB0 byBuZWVkCj4+Pj4gdGhpcyBpbmZvcm1hdGlvbiBhdCB0aGXCoCBtb21lbnQuIElQReKAmXMgZ29h bCBpcyB0byBoYXZlIHByb3ZpZGUKPj4+PiB0cnVzdC1iYXNlZCBhY2Nlc3MgY29udHJvbC4gVHJ1 c3QgYW5kIEludGVncml0eSBhcmUgdGllZCB0b2dldGhlciwKPj4+PiBhcyB5b3UgY2Fubm90IHBy b3ZlIHRydXN0IHdpdGhvdXQgcHJvdmluZyBpbnRlZ3JpdHkuCj4+PiBJIHRoaW5rIHlvdSBtZWFu IGF1dGhlbnRpY2l0eSwgbm90IGludGVncml0eT8KPj4+Cj4+PiBBbHNvIGhvdyBkb2VzIHRoaXMg ZGlmZmVyIGZyb20gSU1BPyAgSSBrbm93IHRoYXQgSU1BIGRvZXNuJ3Qgc3VwcG9ydCBmcy12ZXJp dHkKPj4+IGZpbGUgaGFzaGVzLCBidXQgdGhhdCBjb3VsZCBiZSBjaGFuZ2VkLiAgV2h5IG5vdCBl eHRlbmQgSU1BIHRvIGNvdmVyIHlvdXIgdXNlCj4+PiBjYXNlKHMpPwo+Pj4KPj4+PiBJUEUgbmVl ZHMgdGhlIGRpZ2VzdCBpbmZvcm1hdGlvbiB0byBiZSBhYmxlIHRvIGNvbXBhcmUgYSBkaWdlc3QK Pj4+PiBwcm92aWRlZCBieSB0aGUgcG9saWN5IGF1dGhvciwgYWdhaW5zdCB0aGUgZGlnZXN0IGNh bGN1bGF0ZWQgYnkKPj4+PiBmc3Zlcml0eSB0byBtYWtlIGEgZGVjaXNpb24gb24gd2hldGhlciB0 aGF0IHNwZWNpZmljIGZpbGUsIHJlcHJlc2VudGVkCj4+Pj4gYnkgdGhlIGRpZ2VzdCBpcyBhdXRo b3JpemVkIGZvciB0aGUgYWN0aW9ucyBzcGVjaWZpZWQgaW4gdGhlIHBvbGljeS4KPj4+Pgo+Pj4+ IEEgbW9yZSBjb25jcmV0ZSBleGFtcGxlLCBpZiBhbiBJUEUgcG9saWN5IGF1dGhvciB3cml0ZXM6 Cj4+Pj4KPj4+PiAgwqDCoMKgIG9wPUVYRUNVVEUgZnN2ZXJpdHlfZGlnZXN0PTxIZXhEaWdlc3Qg PiBhY3Rpb249REVOWQo+Pj4+Cj4+Pj4gSVBFIHRha2VzIHRoZSBkaWdlc3QgcHJvdmlkZWQgYnkg dGhpcyBzZWN1cml0eSBob29rLCBzdG9yZXMgaXQKPj4+PiBpbiBJUEUncyBzZWN1cml0eSBibG9i IG9uIHRoZSBpbm9kZS4gSWYgdGhpcyBmaWxlIGlzIGxhdGVyCj4+Pj4gZXhlY3V0ZWQsIElQRSBj b21wYXJlcyB0aGUgZGlnZXN0IHN0b3JlZCBpbiB0aGUgTFNNIGJsb2IsCj4+Pj4gcHJvdmlkZWQg YnkgdGhpcyBob29rLCBhZ2FpbnN0IDxIZXhEaWdlc3Q+IGluIHRoZSBwb2xpY3ksIGlmCj4+Pj4g aXQgbWF0Y2hlcywgaXQgZGVuaWVzIHRoZSBhY2Nlc3MsIHBlcmZvcm1pbmcgYSByZXZvY2F0aW9u Cj4+Pj4gb2YgdGhhdCBmaWxlLgo+Pj4gRG8geW91IGhhdmUgYSBiZXR0ZXIgZXhhbXBsZT8gIFRo aXMgb25lIGlzIHByZXR0eSB1c2VsZXNzIHNpbmNlIG9uZSBjYW4gZ2V0Cj4+PiBhcm91bmQgaXQg anVzdCBieSBleGVjdXRpbmcgYSBmaWxlIHRoYXQgZG9lc24ndCBoYXZlIGZzLXZlcml0eSBlbmFi bGVkLgo+PiBJIHdhcyB3b25kZXJpbmcgaWYgdGhlIGZvbGxvd2luZyB1c2UgY2FzZSBjYW4gYmUg c3VwcG9ydGVkOgo+PiBhbGxvdyB0aGUgZXhlY3V0aW9uIG9mIGZpbGVzIHByb3RlY3RlZCB3aXRo IGZzdmVyaXR5IGlmIHRoZSByb290Cj4+IGRpZ2VzdCBpcyBmb3VuZCBhbW9uZyByZWZlcmVuY2Ug dmFsdWVzIChpbnN0ZWFkIG9mIHByb3ZpZGluZwo+PiB0aGVtIG9uZSBieSBvbmUgaW4gdGhlIHBv bGljeSkuCj4+Cj4+IFNvbWV0aGluZyBsaWtlOgo+Pgo+PiBvcD1FWEVDVVRFIGZzdmVyaXR5X2Rp Z2VzdD1kaWdsaW0gYWN0aW9uPUFMTE9XCj4gTG9va3MgbGlrZSBpdCB3b3Jrcy4gSSBtb2RpZmll ZCBJUEUgdG8gcXVlcnkgdGhlIHJvb3QgZGlnZXN0Cj4gb2YgYW4gZnN2ZXJpdHktcHJvdGVjdGVk IGZpbGUgaW4gRElHTElNLgo+Cj4gIyBjYXQgaXBlLXBvbGljeQo+IHBvbGljeV9uYW1lPSJBbGxv d0ZTVmVyaXR5S21vZHVsZXMiIHBvbGljeV92ZXJzaW9uPTAuMC4xCj4gREVGQVVMVCBhY3Rpb249 QUxMT1cKPiBERUZBVUxUIG9wPUtNT0RVTEUgYWN0aW9uPURFTlkKPiBvcD1LTU9EVUxFIGZzdmVy aXR5X2RpZ2VzdD1kaWdsaW0gYWN0aW9uPUFMTE9XCj4KPiBJUEUgc2V0dXA6Cj4gIyBjYXQgaXBl LXBvbGljeS5wN3MgPiAvc3lzL2tlcm5lbC9zZWN1cml0eS9pcGUvbmV3X3BvbGljeQo+ICMgZWNo byAtbiAxID4gIC9zeXMva2VybmVsL3NlY3VyaXR5L2lwZS9wb2xpY2llcy9BbGxvd0ZTVmVyaXR5 S21vZHVsZXMvYWN0aXZlCj4gIyBlY2hvIDEgPiAvc3lzL2tlcm5lbC9zZWN1cml0eS9pcGUvZW5m b3JjZQo+Cj4gSVBFIGRlbmllcyBsb2FkaW5nIG9mIGtlcm5lbCBtb2R1bGVzIG5vdCBwcm90ZWN0 ZWQgYnkgZnN2ZXJpdHk6Cj4gIyBpbnNtb2QgIC9saWIvbW9kdWxlcy81LjE1LjAtcmMxKy9rZXJu ZWwvZnMvZmF0L2ZhdC5rbwo+IGluc21vZDogRVJST1I6IGNvdWxkIG5vdCBpbnNlcnQgbW9kdWxl IC9saWIvbW9kdWxlcy81LjE1LjAtcmMxKy9rZXJuZWwvZnMvZmF0L2ZhdC5rbzogUGVybWlzc2lv biBkZW5pZWQKPgo+IFByb3RlY3QgZmF0LmtvIHdpdGggZnN2ZXJpdHk6Cj4gIyBjcCAvbGliL21v ZHVsZXMvNS4xNS4wLXJjMSsva2VybmVsL2ZzL2ZhdC9mYXQua28gL2ZzdmVyaXR5Cj4gIyBmc3Zl cml0eSBlbmFibGUgL2ZzdmVyaXR5L2ZhdC5rbwo+ICMgZnN2ZXJpdHkgbWVhc3VyZSAvZnN2ZXJp dHkvZmF0LmtvCj4gc2hhMjU2OjA3OWJlNmQ4ODYzOGU1ODE0MWVlMjRiYmE4OTgxMzkxN2M0NGZh YTU1YWRhNGJmNWQ4MDMzNWVmZTE1NDc4MDMgL2ZzdmVyaXR5L2ZhdC5rbwo+Cj4gSVBFIHN0aWxs IGRlbmllcyB0aGUgbG9hZGluZyBvZiBmYXQua28gKHJvb3QgZGlnZXN0IG5vdCB1cGxvYWRlZCB0 byB0aGUga2VybmVsKToKPiAjIGluc21vZCAvZnN2ZXJpdHkvZmF0LmtvCj4gaW5zbW9kOiBFUlJP UjogY291bGQgbm90IGluc2VydCBtb2R1bGUgL2ZzdmVyaXR5L2ZhdC5rbzogUGVybWlzc2lvbiBk ZW5pZWQKPgo+IEdlbmVyYXRlIGEgZGlnZXN0IGxpc3Qgd2l0aCB0aGUgcm9vdCBkaWdlc3QgYWJv dmUgYW5kIHVwbG9hZCBpdCB0byB0aGUga2VybmVsOgo+ICMgLi9jb21wYWN0X2dlbiAtaSAwNzli ZTZkODg2MzhlNTgxNDFlZTI0YmJhODk4MTM5MTdjNDRmYWE1NWFkYTRiZjVkODAzMzVlZmUxNTQ3 ODAzIC1hIHNoYTI1NiAtZCB0ZXN0IC1zIC10IGZpbGUgLWYKPiAjIGVjaG8gJFBXRC90ZXN0LzAt ZmlsZV9saXN0LWNvbXBhY3QtMDc5YmU2ZDg4NjM4ZTU4MTQxZWUyNGJiYTg5ODEzOTE3YzQ0ZmFh NTVhZGE0YmY1ZDgwMzM1ZWZlMTU0NzgwMyA+IC9zeXMva2VybmVsL3NlY3VyaXR5L2ludGVncml0 eS9kaWdsaW0vZGlnZXN0X2xpc3RfYWRkCj4KPiBJUEUgYWxsb3dzIHRoZSBsb2FkaW5nIG9mIGZh dC5rbzoKPiAjIGluc21vZCAvZnN2ZXJpdHkvZmF0LmtvCj4gIwo+Cj4gUmVnYXJkaW5nIGF1dGhl bnRpY2l0eSwgbm90IHNob3duIGluIHRoaXMgZGVtbywgSVBFIHdpbGwgYWxzbwo+IGVuc3VyZSB0 aGF0IHRoZSByb290IGRpZ2VzdCBpcyBzaWduZWQgKGRpZ2xpbV9kaWdlc3RfZ2V0X2luZm8oKQo+ IHJlcG9ydHMgdGhpcyBpbmZvcm1hdGlvbikuCgpJIGFwb2xvZ2l6ZSBmb3IgdGhlIGRlbGF5IGlu IHJlc3BvbnNlcywgYnV0IGl0IGxvb2tzIGxpa2UKeW91J3ZlIGZpZ3VyZWQgaXQgb3V0LgoKVGhp cyBraW5kIG9mIHRoaW5nIGlzIGV4YWN0bHkgd2hhdCBJUEUncyBkZXNpZ24gaXMgc3VwcG9zZWQg dG8Kc29sdmUsIHlvdSBoYXZlIHNvbWUgb3RoZXIgc3lzdGVtIHdoaWNoIHByb3ZpZGVzIHRoZQpp bnRlZ3JpdHkgbWVjaGFuaXNtIGFuZCAob3B0aW9uYWxseSkgZGV0ZXJtaW5lIGlmIGl0IGlzIHRy dXN0ZWQgb3IKbm90LCBhbmQgSVBFIGNhbiBwcm92aWRlIHRoZSBwb2xpY3kgYXNwZWN0IHZlcnkg ZWFzaWx5IHRvCm1ha2UgYSBzZXQgb2Ygc3lzdGVtLXdpZGUgcmVxdWlyZW1lbnRzIGFyb3VuZCB5 b3VyIG1lY2hhbmlzbS4KCkknbSB2ZXJ5IHN1cHBvcnRpdmUgb2YgYWRkaW5nIHRoZSBmdW5jdGlv bmFsaXR5LCBidXQgSSB3b25kZXIKaWYgaXQgbWFrZXMgbW9yZSBzZW5zZSB0byBoYXZlIGRpZ2ls bSdzIGV4dGVuc2lvbiBiZSBhIHNlcGFyYXRlCmtleSBpbnN0ZWFkIG9mIHRpZWQgdG8gdGhlIGZz dmVyaXR5X2RpZ2VzdCBrZXkgLSBzb21ldGhpbmcgbGlrZQoKICAgIG9wPUVYRUNVVEUgZGlnbGlt X2ZzdmVyaXR5PVRSVUUgYWN0aW9uPURFTlkKCnRoYXQgd2F5IHRoZSBjb25kaXRpb24gdGhhdCBl bmFibGVzIHRoaXMgcHJvcGVydHkgY2FuIGRlcGVuZApvbiBkaWdpbG0gaW4gdGhlIGJ1aWxkLCBh bmQgaXQgc2VwYXJhdGVzIHRoZSB0d28gc3lzdGVtcycKaW50ZWdyYXRpb25zIGluIGEgc2xpZ2h0 bHkgbW9yZSBjbGVhbiB3YXkuCgpBcyBhbiBhc2lkZSwgZGlkIHlvdSBmaW5kIGl0IGRpZmZpY3Vs dCB0byBleHRlbmQ/Cgo+IFJvYmVydG8KPgo+IEhVQVdFSSBURUNITk9MT0dJRVMgRHVlc3NlbGRv cmYgR21iSCwgSFJCIDU2MDYzCj4gTWFuYWdpbmcgRGlyZWN0b3I6IExpIFBlbmcsIFpob25nIFJv bmdodWEKPgo+PiBESUdMSU0gaXMgYSBjb21wb25lbnQgSSdtIHdvcmtpbmcgb24gdGhhdCBnZW5l cmljYWxseQo+PiBzdG9yZXMgZGlnZXN0cy4gVGhlIGN1cnJlbnQgdXNlIGNhc2UgaXMgdG8gc3Rv cmUgZmlsZSBkaWdlc3RzCj4+IGZyb20gUlBNVEFHX0ZJTEVESUdFU1RTIGFuZCB1c2UgdGhlbSB3 aXRoIElNQSwgYnV0Cj4+IHRoZSBmc3Zlcml0eSB1c2UgY2FzZSBjb3VsZCBiZSBlYXNpbHkgc3Vw cG9ydGVkIChpZiB0aGUgcm9vdAo+PiBkaWdlc3QgaXMgc3RvcmVkIGluIHRoZSBSUE0gaGVhZGVy KS4KPj4KPj4gRElHTElNIGFsc28gdGVsbHMgd2hldGhlciBvciBub3QgdGhlIHNpZ25hdHVyZSBv ZiB0aGUgc291cmNlCj4+IGNvbnRhaW5pbmcgZmlsZSBkaWdlc3RzIChvciBmc3Zlcml0eSBkaWdl c3RzKSBpcyB2YWxpZCAodGhlIHNpZ25hdHVyZQo+PiBvZiB0aGUgUlBNIGhlYWRlciBpcyB0YWtl biBmcm9tIFJQTVRBR19SU0FIRUFERVIpLgo+Pgo+PiBUaGUgbWVtb3J5IG9jY3VwYXRpb24gaXMg cmVsYXRpdmVseSBzbWFsbCBmb3IgZXhlY3V0YWJsZXMKPj4gYW5kIHNoYXJlZCBsaWJyYXJpZXMu IEkgcHVibGlzaGVkIGEgZGVtbyBmb3IgRmVkb3JhIGFuZAo+PiBvcGVuU1VTRSBzb21lIHRpbWUg YWdvOgo+Pgo+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC0KPj4gaW50ZWdyaXR5LzQ4 Y2Q3MzdjNTA0ZDQ1MjA4Mzc3ZGFhMjdkNjI1NTMxQGh1YXdlaS5jb20vCj4+Cj4+IFRoYW5rcwo+ Pgo+PiBSb2JlcnRvCj4+Cj4+IEhVQVdFSSBURUNITk9MT0dJRVMgRHVlc3NlbGRvcmYgR21iSCwg SFJCIDU2MDYzCj4+IE1hbmFnaW5nIERpcmVjdG9yOiBMaSBQZW5nLCBaaG9uZyBSb25naHVhCgoK LS0KZG0tZGV2ZWwgbWFpbGluZyBsaXN0CmRtLWRldmVsQHJlZGhhdC5jb20KaHR0cHM6Ly9saXN0 bWFuLnJlZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9kbS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9779C433F5 for ; Tue, 26 Oct 2021 19:30:08 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D19F60E08 for ; Tue, 26 Oct 2021 19:30:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D19F60E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-ovMTDD3HN1G-b_S1X42XHw-1; Tue, 26 Oct 2021 15:30:04 -0400 X-MC-Unique: ovMTDD3HN1G-b_S1X42XHw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9EA6801FCE; Tue, 26 Oct 2021 19:30:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB30F57CA5; Tue, 26 Oct 2021 19:30:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 231EE180BAD2; Tue, 26 Oct 2021 19:29:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19QJ3xmD022718 for ; Tue, 26 Oct 2021 15:03:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 894E71121319; Tue, 26 Oct 2021 19:03:59 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78A611121315 for ; Tue, 26 Oct 2021 19:03:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6945E185A79C for ; Tue, 26 Oct 2021 19:03:56 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-329-YBRdJdbyOjCTZnCCX8icRA-1; Tue, 26 Oct 2021 15:03:52 -0400 X-MC-Unique: YBRdJdbyOjCTZnCCX8icRA-1 Received: from [10.137.106.139] (unknown [131.107.159.11]) by linux.microsoft.com (Postfix) with ESMTPSA id 403732034CB5; Tue, 26 Oct 2021 12:03:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 403732034CB5 Message-ID: <40f70c77-80eb-2716-be77-9cbcf4770b8a@linux.microsoft.com> Date: Tue, 26 Oct 2021 12:03:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 From: Deven Bowers Subject: Re: [RFC PATCH v7 12/16] fsverity|security: add security hooks to fsverity digest and signature To: Roberto Sassu , Eric Biggers References: <1634151995-16266-1-git-send-email-deven.desai@linux.microsoft.com> <1634151995-16266-13-git-send-email-deven.desai@linux.microsoft.com> <9089bdb0-b28a-9fa0-c510-00fa275af621@linux.microsoft.com> <5c1f800ba554485cb3659da689d2079a@huawei.com> In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 19QJ3xmD022718 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Tue, 26 Oct 2021 15:25:17 -0400 Cc: "axboe@kernel.dk" , "linux-security-module@vger.kernel.org" , "tytso@mit.edu" , "snitzer@redhat.com" , "corbet@lwn.net" , "jannh@google.com" , "linux-doc@vger.kernel.org" , "jmorris@namei.org" , "eparis@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , "linux-audit@redhat.com" , "linux-fscrypt@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "agk@redhat.com" , "serge@hallyn.com" X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Ck9uIDEwLzIyLzIwMjEgOTozMSBBTSwgUm9iZXJ0byBTYXNzdSB3cm90ZToKPj4gRnJvbTogUm9i ZXJ0byBTYXNzdSBbbWFpbHRvOnJvYmVydG8uc2Fzc3VAaHVhd2VpLmNvbV0KPj4gU2VudDogV2Vk bmVzZGF5LCBPY3RvYmVyIDIwLCAyMDIxIDU6MDkgUE0KPj4+IEZyb206IEVyaWMgQmlnZ2VycyBb bWFpbHRvOmViaWdnZXJzQGtlcm5lbC5vcmddCj4+PiBTZW50OiBGcmlkYXksIE9jdG9iZXIgMTUs IDIwMjEgMTA6MTEgUE0KPj4+IE9uIEZyaSwgT2N0IDE1LCAyMDIxIGF0IDEyOjI1OjUzUE0gLTA3 MDAsIERldmVuIEJvd2VycyB3cm90ZToKPj4+PiBPbiAxMC8xMy8yMDIxIDEyOjI0IFBNLCBFcmlj IEJpZ2dlcnMgd3JvdGU6Cj4+Pj4+IE9uIFdlZCwgT2N0IDEzLCAyMDIxIGF0IDEyOjA2OjMxUE0g LTA3MDAsCj4+PiBkZXZlbi5kZXNhaUBsaW51eC5taWNyb3NvZnQuY29tICB3cm90ZToKPj4+Pj4+ IEZyb206IEZhbiBXdTx3dWZhbkBsaW51eC5taWNyb3NvZnQuY29tPgo+Pj4+Pj4KPj4+Pj4+IEFk ZCBzZWN1cml0eV9pbm9kZV9zZXRzZWN1cml0eSB0byBmc3Zlcml0eSBzaWduYXR1cmUgdmVyaWZp Y2F0aW9uLgo+Pj4+Pj4gVGhpcyBjYW4gbGV0IExTTXMgc2F2ZSB0aGUgc2lnbmF0dXJlIGRhdGEg YW5kIGRpZ2VzdCBoYXNoZXMgcHJvdmlkZWQKPj4+Pj4+IGJ5IGZzdmVyaXR5Lgo+Pj4+PiBDYW4g eW91IGVsYWJvcmF0ZSBvbiB3aHkgTFNNcyBuZWVkIHRoaXMgaW5mb3JtYXRpb24/Cj4+Pj4gVGhl IHByb3Bvc2VkIExTTSAoSVBFKSBvZiB0aGlzIHNlcmllcyB3aWxsIGJlIHRoZSBvbmx5IG9uZSB0 byBuZWVkCj4+Pj4gdGhpcyBpbmZvcm1hdGlvbiBhdCB0aGXCoCBtb21lbnQuIElQReKAmXMgZ29h bCBpcyB0byBoYXZlIHByb3ZpZGUKPj4+PiB0cnVzdC1iYXNlZCBhY2Nlc3MgY29udHJvbC4gVHJ1 c3QgYW5kIEludGVncml0eSBhcmUgdGllZCB0b2dldGhlciwKPj4+PiBhcyB5b3UgY2Fubm90IHBy b3ZlIHRydXN0IHdpdGhvdXQgcHJvdmluZyBpbnRlZ3JpdHkuCj4+PiBJIHRoaW5rIHlvdSBtZWFu IGF1dGhlbnRpY2l0eSwgbm90IGludGVncml0eT8KPj4+Cj4+PiBBbHNvIGhvdyBkb2VzIHRoaXMg ZGlmZmVyIGZyb20gSU1BPyAgSSBrbm93IHRoYXQgSU1BIGRvZXNuJ3Qgc3VwcG9ydCBmcy12ZXJp dHkKPj4+IGZpbGUgaGFzaGVzLCBidXQgdGhhdCBjb3VsZCBiZSBjaGFuZ2VkLiAgV2h5IG5vdCBl eHRlbmQgSU1BIHRvIGNvdmVyIHlvdXIgdXNlCj4+PiBjYXNlKHMpPwo+Pj4KPj4+PiBJUEUgbmVl ZHMgdGhlIGRpZ2VzdCBpbmZvcm1hdGlvbiB0byBiZSBhYmxlIHRvIGNvbXBhcmUgYSBkaWdlc3QK Pj4+PiBwcm92aWRlZCBieSB0aGUgcG9saWN5IGF1dGhvciwgYWdhaW5zdCB0aGUgZGlnZXN0IGNh bGN1bGF0ZWQgYnkKPj4+PiBmc3Zlcml0eSB0byBtYWtlIGEgZGVjaXNpb24gb24gd2hldGhlciB0 aGF0IHNwZWNpZmljIGZpbGUsIHJlcHJlc2VudGVkCj4+Pj4gYnkgdGhlIGRpZ2VzdCBpcyBhdXRo b3JpemVkIGZvciB0aGUgYWN0aW9ucyBzcGVjaWZpZWQgaW4gdGhlIHBvbGljeS4KPj4+Pgo+Pj4+ IEEgbW9yZSBjb25jcmV0ZSBleGFtcGxlLCBpZiBhbiBJUEUgcG9saWN5IGF1dGhvciB3cml0ZXM6 Cj4+Pj4KPj4+PiAgwqDCoMKgIG9wPUVYRUNVVEUgZnN2ZXJpdHlfZGlnZXN0PTxIZXhEaWdlc3Qg PiBhY3Rpb249REVOWQo+Pj4+Cj4+Pj4gSVBFIHRha2VzIHRoZSBkaWdlc3QgcHJvdmlkZWQgYnkg dGhpcyBzZWN1cml0eSBob29rLCBzdG9yZXMgaXQKPj4+PiBpbiBJUEUncyBzZWN1cml0eSBibG9i IG9uIHRoZSBpbm9kZS4gSWYgdGhpcyBmaWxlIGlzIGxhdGVyCj4+Pj4gZXhlY3V0ZWQsIElQRSBj b21wYXJlcyB0aGUgZGlnZXN0IHN0b3JlZCBpbiB0aGUgTFNNIGJsb2IsCj4+Pj4gcHJvdmlkZWQg YnkgdGhpcyBob29rLCBhZ2FpbnN0IDxIZXhEaWdlc3Q+IGluIHRoZSBwb2xpY3ksIGlmCj4+Pj4g aXQgbWF0Y2hlcywgaXQgZGVuaWVzIHRoZSBhY2Nlc3MsIHBlcmZvcm1pbmcgYSByZXZvY2F0aW9u Cj4+Pj4gb2YgdGhhdCBmaWxlLgo+Pj4gRG8geW91IGhhdmUgYSBiZXR0ZXIgZXhhbXBsZT8gIFRo aXMgb25lIGlzIHByZXR0eSB1c2VsZXNzIHNpbmNlIG9uZSBjYW4gZ2V0Cj4+PiBhcm91bmQgaXQg anVzdCBieSBleGVjdXRpbmcgYSBmaWxlIHRoYXQgZG9lc24ndCBoYXZlIGZzLXZlcml0eSBlbmFi bGVkLgo+PiBJIHdhcyB3b25kZXJpbmcgaWYgdGhlIGZvbGxvd2luZyB1c2UgY2FzZSBjYW4gYmUg c3VwcG9ydGVkOgo+PiBhbGxvdyB0aGUgZXhlY3V0aW9uIG9mIGZpbGVzIHByb3RlY3RlZCB3aXRo IGZzdmVyaXR5IGlmIHRoZSByb290Cj4+IGRpZ2VzdCBpcyBmb3VuZCBhbW9uZyByZWZlcmVuY2Ug dmFsdWVzIChpbnN0ZWFkIG9mIHByb3ZpZGluZwo+PiB0aGVtIG9uZSBieSBvbmUgaW4gdGhlIHBv bGljeSkuCj4+Cj4+IFNvbWV0aGluZyBsaWtlOgo+Pgo+PiBvcD1FWEVDVVRFIGZzdmVyaXR5X2Rp Z2VzdD1kaWdsaW0gYWN0aW9uPUFMTE9XCj4gTG9va3MgbGlrZSBpdCB3b3Jrcy4gSSBtb2RpZmll ZCBJUEUgdG8gcXVlcnkgdGhlIHJvb3QgZGlnZXN0Cj4gb2YgYW4gZnN2ZXJpdHktcHJvdGVjdGVk IGZpbGUgaW4gRElHTElNLgo+Cj4gIyBjYXQgaXBlLXBvbGljeQo+IHBvbGljeV9uYW1lPSJBbGxv d0ZTVmVyaXR5S21vZHVsZXMiIHBvbGljeV92ZXJzaW9uPTAuMC4xCj4gREVGQVVMVCBhY3Rpb249 QUxMT1cKPiBERUZBVUxUIG9wPUtNT0RVTEUgYWN0aW9uPURFTlkKPiBvcD1LTU9EVUxFIGZzdmVy aXR5X2RpZ2VzdD1kaWdsaW0gYWN0aW9uPUFMTE9XCj4KPiBJUEUgc2V0dXA6Cj4gIyBjYXQgaXBl LXBvbGljeS5wN3MgPiAvc3lzL2tlcm5lbC9zZWN1cml0eS9pcGUvbmV3X3BvbGljeQo+ICMgZWNo byAtbiAxID4gIC9zeXMva2VybmVsL3NlY3VyaXR5L2lwZS9wb2xpY2llcy9BbGxvd0ZTVmVyaXR5 S21vZHVsZXMvYWN0aXZlCj4gIyBlY2hvIDEgPiAvc3lzL2tlcm5lbC9zZWN1cml0eS9pcGUvZW5m b3JjZQo+Cj4gSVBFIGRlbmllcyBsb2FkaW5nIG9mIGtlcm5lbCBtb2R1bGVzIG5vdCBwcm90ZWN0 ZWQgYnkgZnN2ZXJpdHk6Cj4gIyBpbnNtb2QgIC9saWIvbW9kdWxlcy81LjE1LjAtcmMxKy9rZXJu ZWwvZnMvZmF0L2ZhdC5rbwo+IGluc21vZDogRVJST1I6IGNvdWxkIG5vdCBpbnNlcnQgbW9kdWxl IC9saWIvbW9kdWxlcy81LjE1LjAtcmMxKy9rZXJuZWwvZnMvZmF0L2ZhdC5rbzogUGVybWlzc2lv biBkZW5pZWQKPgo+IFByb3RlY3QgZmF0LmtvIHdpdGggZnN2ZXJpdHk6Cj4gIyBjcCAvbGliL21v ZHVsZXMvNS4xNS4wLXJjMSsva2VybmVsL2ZzL2ZhdC9mYXQua28gL2ZzdmVyaXR5Cj4gIyBmc3Zl cml0eSBlbmFibGUgL2ZzdmVyaXR5L2ZhdC5rbwo+ICMgZnN2ZXJpdHkgbWVhc3VyZSAvZnN2ZXJp dHkvZmF0LmtvCj4gc2hhMjU2OjA3OWJlNmQ4ODYzOGU1ODE0MWVlMjRiYmE4OTgxMzkxN2M0NGZh YTU1YWRhNGJmNWQ4MDMzNWVmZTE1NDc4MDMgL2ZzdmVyaXR5L2ZhdC5rbwo+Cj4gSVBFIHN0aWxs IGRlbmllcyB0aGUgbG9hZGluZyBvZiBmYXQua28gKHJvb3QgZGlnZXN0IG5vdCB1cGxvYWRlZCB0 byB0aGUga2VybmVsKToKPiAjIGluc21vZCAvZnN2ZXJpdHkvZmF0LmtvCj4gaW5zbW9kOiBFUlJP UjogY291bGQgbm90IGluc2VydCBtb2R1bGUgL2ZzdmVyaXR5L2ZhdC5rbzogUGVybWlzc2lvbiBk ZW5pZWQKPgo+IEdlbmVyYXRlIGEgZGlnZXN0IGxpc3Qgd2l0aCB0aGUgcm9vdCBkaWdlc3QgYWJv dmUgYW5kIHVwbG9hZCBpdCB0byB0aGUga2VybmVsOgo+ICMgLi9jb21wYWN0X2dlbiAtaSAwNzli ZTZkODg2MzhlNTgxNDFlZTI0YmJhODk4MTM5MTdjNDRmYWE1NWFkYTRiZjVkODAzMzVlZmUxNTQ3 ODAzIC1hIHNoYTI1NiAtZCB0ZXN0IC1zIC10IGZpbGUgLWYKPiAjIGVjaG8gJFBXRC90ZXN0LzAt ZmlsZV9saXN0LWNvbXBhY3QtMDc5YmU2ZDg4NjM4ZTU4MTQxZWUyNGJiYTg5ODEzOTE3YzQ0ZmFh NTVhZGE0YmY1ZDgwMzM1ZWZlMTU0NzgwMyA+IC9zeXMva2VybmVsL3NlY3VyaXR5L2ludGVncml0 eS9kaWdsaW0vZGlnZXN0X2xpc3RfYWRkCj4KPiBJUEUgYWxsb3dzIHRoZSBsb2FkaW5nIG9mIGZh dC5rbzoKPiAjIGluc21vZCAvZnN2ZXJpdHkvZmF0LmtvCj4gIwo+Cj4gUmVnYXJkaW5nIGF1dGhl bnRpY2l0eSwgbm90IHNob3duIGluIHRoaXMgZGVtbywgSVBFIHdpbGwgYWxzbwo+IGVuc3VyZSB0 aGF0IHRoZSByb290IGRpZ2VzdCBpcyBzaWduZWQgKGRpZ2xpbV9kaWdlc3RfZ2V0X2luZm8oKQo+ IHJlcG9ydHMgdGhpcyBpbmZvcm1hdGlvbikuCgpJIGFwb2xvZ2l6ZSBmb3IgdGhlIGRlbGF5IGlu IHJlc3BvbnNlcywgYnV0IGl0IGxvb2tzIGxpa2UKeW91J3ZlIGZpZ3VyZWQgaXQgb3V0LgoKVGhp cyBraW5kIG9mIHRoaW5nIGlzIGV4YWN0bHkgd2hhdCBJUEUncyBkZXNpZ24gaXMgc3VwcG9zZWQg dG8Kc29sdmUsIHlvdSBoYXZlIHNvbWUgb3RoZXIgc3lzdGVtIHdoaWNoIHByb3ZpZGVzIHRoZQpp bnRlZ3JpdHkgbWVjaGFuaXNtIGFuZCAob3B0aW9uYWxseSkgZGV0ZXJtaW5lIGlmIGl0IGlzIHRy dXN0ZWQgb3IKbm90LCBhbmQgSVBFIGNhbiBwcm92aWRlIHRoZSBwb2xpY3kgYXNwZWN0IHZlcnkg ZWFzaWx5IHRvCm1ha2UgYSBzZXQgb2Ygc3lzdGVtLXdpZGUgcmVxdWlyZW1lbnRzIGFyb3VuZCB5 b3VyIG1lY2hhbmlzbS4KCkknbSB2ZXJ5IHN1cHBvcnRpdmUgb2YgYWRkaW5nIHRoZSBmdW5jdGlv bmFsaXR5LCBidXQgSSB3b25kZXIKaWYgaXQgbWFrZXMgbW9yZSBzZW5zZSB0byBoYXZlIGRpZ2ls bSdzIGV4dGVuc2lvbiBiZSBhIHNlcGFyYXRlCmtleSBpbnN0ZWFkIG9mIHRpZWQgdG8gdGhlIGZz dmVyaXR5X2RpZ2VzdCBrZXkgLSBzb21ldGhpbmcgbGlrZQoKICAgIG9wPUVYRUNVVEUgZGlnbGlt X2ZzdmVyaXR5PVRSVUUgYWN0aW9uPURFTlkKCnRoYXQgd2F5IHRoZSBjb25kaXRpb24gdGhhdCBl bmFibGVzIHRoaXMgcHJvcGVydHkgY2FuIGRlcGVuZApvbiBkaWdpbG0gaW4gdGhlIGJ1aWxkLCBh bmQgaXQgc2VwYXJhdGVzIHRoZSB0d28gc3lzdGVtcycKaW50ZWdyYXRpb25zIGluIGEgc2xpZ2h0 bHkgbW9yZSBjbGVhbiB3YXkuCgpBcyBhbiBhc2lkZSwgZGlkIHlvdSBmaW5kIGl0IGRpZmZpY3Vs dCB0byBleHRlbmQ/Cgo+IFJvYmVydG8KPgo+IEhVQVdFSSBURUNITk9MT0dJRVMgRHVlc3NlbGRv cmYgR21iSCwgSFJCIDU2MDYzCj4gTWFuYWdpbmcgRGlyZWN0b3I6IExpIFBlbmcsIFpob25nIFJv bmdodWEKPgo+PiBESUdMSU0gaXMgYSBjb21wb25lbnQgSSdtIHdvcmtpbmcgb24gdGhhdCBnZW5l cmljYWxseQo+PiBzdG9yZXMgZGlnZXN0cy4gVGhlIGN1cnJlbnQgdXNlIGNhc2UgaXMgdG8gc3Rv cmUgZmlsZSBkaWdlc3RzCj4+IGZyb20gUlBNVEFHX0ZJTEVESUdFU1RTIGFuZCB1c2UgdGhlbSB3 aXRoIElNQSwgYnV0Cj4+IHRoZSBmc3Zlcml0eSB1c2UgY2FzZSBjb3VsZCBiZSBlYXNpbHkgc3Vw cG9ydGVkIChpZiB0aGUgcm9vdAo+PiBkaWdlc3QgaXMgc3RvcmVkIGluIHRoZSBSUE0gaGVhZGVy KS4KPj4KPj4gRElHTElNIGFsc28gdGVsbHMgd2hldGhlciBvciBub3QgdGhlIHNpZ25hdHVyZSBv ZiB0aGUgc291cmNlCj4+IGNvbnRhaW5pbmcgZmlsZSBkaWdlc3RzIChvciBmc3Zlcml0eSBkaWdl c3RzKSBpcyB2YWxpZCAodGhlIHNpZ25hdHVyZQo+PiBvZiB0aGUgUlBNIGhlYWRlciBpcyB0YWtl biBmcm9tIFJQTVRBR19SU0FIRUFERVIpLgo+Pgo+PiBUaGUgbWVtb3J5IG9jY3VwYXRpb24gaXMg cmVsYXRpdmVseSBzbWFsbCBmb3IgZXhlY3V0YWJsZXMKPj4gYW5kIHNoYXJlZCBsaWJyYXJpZXMu IEkgcHVibGlzaGVkIGEgZGVtbyBmb3IgRmVkb3JhIGFuZAo+PiBvcGVuU1VTRSBzb21lIHRpbWUg YWdvOgo+Pgo+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC0KPj4gaW50ZWdyaXR5LzQ4 Y2Q3MzdjNTA0ZDQ1MjA4Mzc3ZGFhMjdkNjI1NTMxQGh1YXdlaS5jb20vCj4+Cj4+IFRoYW5rcwo+ Pgo+PiBSb2JlcnRvCj4+Cj4+IEhVQVdFSSBURUNITk9MT0dJRVMgRHVlc3NlbGRvcmYgR21iSCwg SFJCIDU2MDYzCj4+IE1hbmFnaW5nIERpcmVjdG9yOiBMaSBQZW5nLCBaaG9uZyBSb25naHVhCgoK LS0KTGludXgtYXVkaXQgbWFpbGluZyBsaXN0CkxpbnV4LWF1ZGl0QHJlZGhhdC5jb20KaHR0cHM6 Ly9saXN0bWFuLnJlZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9saW51eC1hdWRpdA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AECC43219 for ; Tue, 26 Oct 2021 19:04:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3E2161090 for ; Tue, 26 Oct 2021 19:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238526AbhJZTGV (ORCPT ); Tue, 26 Oct 2021 15:06:21 -0400 Received: from linux.microsoft.com ([13.77.154.182]:56304 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238384AbhJZTGP (ORCPT ); Tue, 26 Oct 2021 15:06:15 -0400 Received: from [10.137.106.139] (unknown [131.107.159.11]) by linux.microsoft.com (Postfix) with ESMTPSA id 403732034CB5; Tue, 26 Oct 2021 12:03:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 403732034CB5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1635275031; bh=5uVMdrVNwQlawt1ibaKRqS7Nvl/fogOPepcpQlWjyuU=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=JQEBdaXtWvgoj1bYEEdu/OP37eRpJvc/BTJmbsE6C4U4De5XuUvriHCATeI91HD16 dGqKI4JATg+UNiQ2v4CwnOXDyj+Ep/KWPD5qIRJffJp4fYXN2Vr/rt+5yzjvAaeOQa LJ1K7KRo+AncXeQgSRAr1g3ptTcedfPMuvjzCD+A= Message-ID: <40f70c77-80eb-2716-be77-9cbcf4770b8a@linux.microsoft.com> Date: Tue, 26 Oct 2021 12:03:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 From: Deven Bowers Subject: Re: [RFC PATCH v7 12/16] fsverity|security: add security hooks to fsverity digest and signature To: Roberto Sassu , Eric Biggers Cc: "corbet@lwn.net" , "axboe@kernel.dk" , "agk@redhat.com" , "snitzer@redhat.com" , "tytso@mit.edu" , "paul@paul-moore.com" , "eparis@redhat.com" , "jmorris@namei.org" , "serge@hallyn.com" , "jannh@google.com" , "dm-devel@redhat.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-fscrypt@vger.kernel.org" , "linux-audit@redhat.com" , "linux-security-module@vger.kernel.org" , "linux-integrity@vger.kernel.org" References: <1634151995-16266-1-git-send-email-deven.desai@linux.microsoft.com> <1634151995-16266-13-git-send-email-deven.desai@linux.microsoft.com> <9089bdb0-b28a-9fa0-c510-00fa275af621@linux.microsoft.com> <5c1f800ba554485cb3659da689d2079a@huawei.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 10/22/2021 9:31 AM, Roberto Sassu wrote: >> From: Roberto Sassu [mailto:roberto.sassu@huawei.com] >> Sent: Wednesday, October 20, 2021 5:09 PM >>> From: Eric Biggers [mailto:ebiggers@kernel.org] >>> Sent: Friday, October 15, 2021 10:11 PM >>> On Fri, Oct 15, 2021 at 12:25:53PM -0700, Deven Bowers wrote: >>>> On 10/13/2021 12:24 PM, Eric Biggers wrote: >>>>> On Wed, Oct 13, 2021 at 12:06:31PM -0700, >>> deven.desai@linux.microsoft.com wrote: >>>>>> From: Fan Wu >>>>>> >>>>>> Add security_inode_setsecurity to fsverity signature verification. >>>>>> This can let LSMs save the signature data and digest hashes provided >>>>>> by fsverity. >>>>> Can you elaborate on why LSMs need this information? >>>> The proposed LSM (IPE) of this series will be the only one to need >>>> this information at the  moment. IPE’s goal is to have provide >>>> trust-based access control. Trust and Integrity are tied together, >>>> as you cannot prove trust without proving integrity. >>> I think you mean authenticity, not integrity? >>> >>> Also how does this differ from IMA? I know that IMA doesn't support fs-verity >>> file hashes, but that could be changed. Why not extend IMA to cover your use >>> case(s)? >>> >>>> IPE needs the digest information to be able to compare a digest >>>> provided by the policy author, against the digest calculated by >>>> fsverity to make a decision on whether that specific file, represented >>>> by the digest is authorized for the actions specified in the policy. >>>> >>>> A more concrete example, if an IPE policy author writes: >>>> >>>>     op=EXECUTE fsverity_digest= action=DENY >>>> >>>> IPE takes the digest provided by this security hook, stores it >>>> in IPE's security blob on the inode. If this file is later >>>> executed, IPE compares the digest stored in the LSM blob, >>>> provided by this hook, against in the policy, if >>>> it matches, it denies the access, performing a revocation >>>> of that file. >>> Do you have a better example? This one is pretty useless since one can get >>> around it just by executing a file that doesn't have fs-verity enabled. >> I was wondering if the following use case can be supported: >> allow the execution of files protected with fsverity if the root >> digest is found among reference values (instead of providing >> them one by one in the policy). >> >> Something like: >> >> op=EXECUTE fsverity_digest=diglim action=ALLOW > Looks like it works. I modified IPE to query the root digest > of an fsverity-protected file in DIGLIM. > > # cat ipe-policy > policy_name="AllowFSVerityKmodules" policy_version=0.0.1 > DEFAULT action=ALLOW > DEFAULT op=KMODULE action=DENY > op=KMODULE fsverity_digest=diglim action=ALLOW > > IPE setup: > # cat ipe-policy.p7s > /sys/kernel/security/ipe/new_policy > # echo -n 1 > /sys/kernel/security/ipe/policies/AllowFSVerityKmodules/active > # echo 1 > /sys/kernel/security/ipe/enforce > > IPE denies loading of kernel modules not protected by fsverity: > # insmod /lib/modules/5.15.0-rc1+/kernel/fs/fat/fat.ko > insmod: ERROR: could not insert module /lib/modules/5.15.0-rc1+/kernel/fs/fat/fat.ko: Permission denied > > Protect fat.ko with fsverity: > # cp /lib/modules/5.15.0-rc1+/kernel/fs/fat/fat.ko /fsverity > # fsverity enable /fsverity/fat.ko > # fsverity measure /fsverity/fat.ko > sha256:079be6d88638e58141ee24bba89813917c44faa55ada4bf5d80335efe1547803 /fsverity/fat.ko > > IPE still denies the loading of fat.ko (root digest not uploaded to the kernel): > # insmod /fsverity/fat.ko > insmod: ERROR: could not insert module /fsverity/fat.ko: Permission denied > > Generate a digest list with the root digest above and upload it to the kernel: > # ./compact_gen -i 079be6d88638e58141ee24bba89813917c44faa55ada4bf5d80335efe1547803 -a sha256 -d test -s -t file -f > # echo $PWD/test/0-file_list-compact-079be6d88638e58141ee24bba89813917c44faa55ada4bf5d80335efe1547803 > /sys/kernel/security/integrity/diglim/digest_list_add > > IPE allows the loading of fat.ko: > # insmod /fsverity/fat.ko > # > > Regarding authenticity, not shown in this demo, IPE will also > ensure that the root digest is signed (diglim_digest_get_info() > reports this information). I apologize for the delay in responses, but it looks like you've figured it out. This kind of thing is exactly what IPE's design is supposed to solve, you have some other system which provides the integrity mechanism and (optionally) determine if it is trusted or not, and IPE can provide the policy aspect very easily to make a set of system-wide requirements around your mechanism. I'm very supportive of adding the functionality, but I wonder if it makes more sense to have digilm's extension be a separate key instead of tied to the fsverity_digest key - something like op=EXECUTE diglim_fsverity=TRUE action=DENY that way the condition that enables this property can depend on digilm in the build, and it separates the two systems' integrations in a slightly more clean way. As an aside, did you find it difficult to extend? > Roberto > > HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 > Managing Director: Li Peng, Zhong Ronghua > >> DIGLIM is a component I'm working on that generically >> stores digests. The current use case is to store file digests >> from RPMTAG_FILEDIGESTS and use them with IMA, but >> the fsverity use case could be easily supported (if the root >> digest is stored in the RPM header). >> >> DIGLIM also tells whether or not the signature of the source >> containing file digests (or fsverity digests) is valid (the signature >> of the RPM header is taken from RPMTAG_RSAHEADER). >> >> The memory occupation is relatively small for executables >> and shared libraries. I published a demo for Fedora and >> openSUSE some time ago: >> >> https://lore.kernel.org/linux- >> integrity/48cd737c504d45208377daa27d625531@huawei.com/ >> >> Thanks >> >> Roberto >> >> HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 >> Managing Director: Li Peng, Zhong Ronghua