Re: [Buildroot] [PATCH 1/1] boot/edk2: fix description

["CHERNIAEV ANDREI" <dungeonlords789@naver.com>]

thank you for your attention,
1) "Please don't remove the upstream URL. If it's incorrect/outdated update it and note the change (ideally with reference) in the commit message, otherwise keep it as-is."
upstream URL is located in corresponding mk file, not in help. And github.com/tianocore/tianocore.github.io/wiki/EDK-II is not upstream, it is wiki
2) "Also, I don't think it's good to remove the general package description, better add a sentence about it providing OVMF for booting in Qemu."
original description is unclear. It can only be recognized by a person already in EDK II context. Description from wiki "TianoCore EDK II (formerly Tiano) is the reference implementation of UEFI by Intel." is better. But still the same: it can be recognized by a person who already knows what is EDK II. So I suggest to describe not what is EDK II (impossible) but what is BR2_TARGET_EDK2

-----Original Message-----
From: "Fiona Klute via buildroot"<buildroot@buildroot.org> 
To: "Andrei Cherniaev"<dungeonlords789@naver.com>; <buildroot@buildroot.org>; 
Cc: <hi@senzilla.io>; <romain.naour@gmail.com>; <kory.maincent@bootlin.com>; <vincent.stehle@arm.com>; <ju.o@free.fr>; <jiaxun.yang@flygoat.com>; <fancp2007@gmail.com>; 
Sent: 2026-04-28 (화) 01:54:42 (GMT+09:00)
Subject: Re: [Buildroot] [PATCH 1/1] boot/edk2: fix description

Am 27.04.26 um 13:28 schrieb Andrei Cherniaev:
> 1) usually user should not try to find OVMF.fd somewhere manually
> 2) board/qemu/x86_64-efi/readme.txt is trying to be duplicate of board/pc/readme.txt. We should not duplicate info
> 
> Signed-off-by: Andrei Cherniaev <dungeonlords789@naver.com>
> ---
>   board/pc/readme.txt              | 10 +++++-----
>   board/qemu/x86_64-efi/readme.txt | 17 +++--------------
>   boot/edk2/Config.in              |  6 ++----
>   3 files changed, 10 insertions(+), 23 deletions(-)
> 
> diff --git a/board/pc/readme.txt b/board/pc/readme.txt
> index 18b1e3dcf0..31ca5357e9 100644
> --- a/board/pc/readme.txt
> +++ b/board/pc/readme.txt
> @@ -63,12 +63,12 @@ Run the emulation with:
>   
>   qemu-system-x86_64 \
>   	-M pc \
> -	-bios </path/to/OVMF_CODE.fd> \
> +	-bios output/images/OVMF.fd \
>   	-drive file=output/images/disk.img,if=virtio,format=raw \
>   	-net nic,model=virtio \
>   	-net user
>   
> -Note that </path/to/OVMF.fd> needs to point to a valid x86_64 UEFI
> -firmware image for qemu. It may be provided by your distribution as a
> -edk2 or OVMF package, in path such as
> -/usr/share/edk2/ovmf/OVMF_CODE.fd .
> +Note that OVMF.fd needs to be a valid x86_64 UEFI firmware image for qemu. The
> +easiest way is to generate it during the Buildroot build by set
> +BR2_TARGET_EDK2. Alternatively it may be provided by your distribution as a
> +edk2 or OVMF package, in path such as /usr/share/edk2/ovmf/OVMF_CODE.fd .
> diff --git a/board/qemu/x86_64-efi/readme.txt b/board/qemu/x86_64-efi/readme.txt
> index 7f69be065f..036239819a 100644
> --- a/board/qemu/x86_64-efi/readme.txt
> +++ b/board/qemu/x86_64-efi/readme.txt
> @@ -12,17 +12,6 @@ Build
>   Emulation
>   =========
>   
> -Run the emulation with:
> -
> -    qemu-system-x86_64 \
> -        -M pc \
> -        -m 1024 \
> -        -serial stdio \
> -        -bios output/images/OVMF.fd \
> -        -drive file=output/images/disk.img,format=raw \
> -        -netdev user,id=net0 \
> -        -device virtio-net-pci,netdev=net0 # qemu_x86_64_efi_defconfig
> -
> -Optionally add -smp N to emulate a SMP system with N CPUs.
> -
> -The login prompt will appear in the graphical window.
> +    output/images/start-qemu.sh
> +or
> +    output/images/start-qemu.sh --serial-only --use-system-qemu
> diff --git a/boot/edk2/Config.in b/boot/edk2/Config.in
> index 2620c79076..a2ea1180f0 100644
> --- a/boot/edk2/Config.in
> +++ b/boot/edk2/Config.in
> @@ -12,10 +12,8 @@ config BR2_TARGET_EDK2
>   	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5
>   	select BR2_PACKAGE_EDK2_PLATFORMS
>   	help
> -	  EDK II is a modern, feature-rich, cross-platform firmware
> -	  development environment for the UEFI and PI specifications.
> -
> -	  https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
> +	  build EDK II (and OVMF) to have capability to boot Buildroot
> +	  in QEMU (UEFI mode)
>   
>   if BR2_TARGET_EDK2
Please don't remove the upstream URL. If it's incorrect/outdated update 
it and note the change (ideally with reference) in the commit message, 
otherwise keep it as-is.

Also, I don't think it's good to remove the general package description, 
better add a sentence about it providing OVMF for booting in Qemu.

Best regards,
Fiona

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot