From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] unpack-trees: correctly compute result count
Date: Fri, 10 Jan 2020 06:30:24 -0500 [thread overview]
Message-ID: <40ff5504-9cdc-a97f-9dbf-84529d6596ce@gmail.com> (raw)
In-Reply-To: <d9a465bf-843b-2a8f-66c0-73fb706dbfc0@gmail.com>
On 1/10/2020 6:24 AM, Derrick Stolee wrote:
> On 1/10/2020 5:37 AM, Jeff King wrote:
>> On Fri, Jan 10, 2020 at 01:59:30AM +0000, Derrick Stolee via GitGitGadget wrote:
>>>
>>> As for making it into the release, I don't know. The change is small, it
>>> has a very limited scope, but this flaw is also not really hurting
>>> anything in a major way.
>>
>> I could go either way.
>>
>> This counts as something small and obvious enough that I'd consider
>> slipping it in at the last minute if it were fixing a bad bug. But given
>> how minor the bug is, being conservative makes sense to me, if only
>> because it's good to exercise our release discipline muscles. :)
>
> Perhaps this should be an example for future release windows.
(Forgive me for fat-fingering and accidentally using "gmx.net" instead
of "gmx.de" for Johannes' email address. Fixed in this message.)
-Stolee
next prev parent reply other threads:[~2020-01-10 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 1:59 [PATCH] unpack-trees: correctly compute result count Derrick Stolee via GitGitGadget
2020-01-10 10:37 ` Jeff King
2020-01-10 11:24 ` Derrick Stolee
2020-01-10 11:30 ` Derrick Stolee [this message]
2020-01-10 19:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ff5504-9cdc-a97f-9dbf-84529d6596ce@gmail.com \
--to=stolee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.