From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] acl: fix missing flags when compiling without AVX2 Date: Wed, 27 Mar 2019 10:39:07 +0100 Message-ID: <4103365.eioPbUUbMs@xps> References: <1552317491-161841-1-git-send-email-andrius.sirvys@intel.com> <20190311163141.GA805836@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org To: Andrius Sirvys Return-path: In-Reply-To: <20190311163141.GA805836@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/03/2019 17:31, Bruce Richardson: > On Mon, Mar 11, 2019 at 03:18:11PM +0000, Andrius Sirvys wrote: > > When compiling the ACL library on a system without AVX2 support, > > the flags used to compile the AVX2-specific code for later run-time > > use were not based on the regular cflags for the rest of the library. > > This can cause errors due to symbols being missed/undefined > > due to incorrect flags. For example, > > when testing compilation on Alpine linux, we got: > > error: unknown type name 'cpu_set_t' > > due to _GNU_SOURCE not being defined in the cflags. > > > > This issue can be fixed by appending "-mavx2" to > > the cflags rather than replacing them with it. > > > > Fixes: 5b9656b157d3 ("lib: build with meson") > > Cc: stable@dpdk.org > > > > Signed-off-by: Andrius Sirvys > > --- > > --- a/lib/librte_acl/meson.build > > +++ b/lib/librte_acl/meson.build > > - c_args: '-mavx2') > > + c_args: cflags + ['-mavx2']) > > Looks to be 2 spaces rather than 1 before the opening "[", but not a big > deal and can be fixed on apply if necessary. > > Acked-by: Bruce Richardson Applied (without double space), thanks