All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
	netdev@oss.sgi.com, Jamal Hadi Salim <hadi@znyx.com>
Subject: Re: [PATCH] kill rtnl_exlock stubs
Date: Tue, 27 Jul 2004 20:38:42 +0200	[thread overview]
Message-ID: <4106A132.8040207@trash.net> (raw)
In-Reply-To: <20040727095057.78c7419c@dell_ss3.pdx.osdl.net>

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Stephen Hemminger wrote:
> Rtnetlink has some macro's that are relics from earlier locking.
> They are only used a couple of places so are easy to kill.

The variable "exclusive" in rtnetlink_rcv_msg becomes useless with
this patch. This patch (on top of Stephen's patch) removes it.

Regards
Patrick

[-- Attachment #2: useless-var.diff --]
[-- Type: text/x-patch, Size: 828 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/07/27 20:32:23+02:00 kaber@trash.net 
#   [NET]: Remove useless variable in rtnetlink_rcv_msg
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
# net/core/rtnetlink.c
#   2004/07/27 20:32:10+02:00 kaber@trash.net +0 -4
#   [NET]: Remove useless variable in rtnetlink_rcv_msg
# 
diff -Nru a/net/core/rtnetlink.c b/net/core/rtnetlink.c
--- a/net/core/rtnetlink.c	2004-07-27 20:33:47 +02:00
+++ b/net/core/rtnetlink.c	2004-07-27 20:33:47 +02:00
@@ -335,7 +335,6 @@
 	struct rtnetlink_link *link_tab;
 	struct rtattr	*rta[RTATTR_MAX];
 
-	int exclusive = 0;
 	int sz_idx, kind;
 	int min_len;
 	int family;
@@ -401,9 +400,6 @@
 		skb_pull(skb, rlen);
 		return -1;
 	}
-
-	if (kind != 2) 
-		exclusive = 1;
 
 	memset(&rta, 0, sizeof(rta));
 

  reply	other threads:[~2004-07-27 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-27 16:50 [PATCH] kill rtnl_exlock stubs Stephen Hemminger
2004-07-27 18:38 ` Patrick McHardy [this message]
2004-07-29  1:59   ` David S. Miller
2004-07-29 13:16 ` Jamal Hadi Salim
2004-07-29 14:43   ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4106A132.8040207@trash.net \
    --to=kaber@trash.net \
    --cc=davem@redhat.com \
    --cc=hadi@znyx.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.