From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Chew <achew@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.8-rc2] sata_nv.c
Date: Tue, 27 Jul 2004 14:55:28 -0400 [thread overview]
Message-ID: <4106A520.1070604@pobox.com> (raw)
In-Reply-To: <DBFABB80F7FD3143A911F9E6CFD477B03F95F4@hqemmail02.nvidia.com>
Andrew Chew wrote:
> Jeff Garzik wrote:
>
>
>>Please fix and resubmit:
>>4) [leak] driver appears to be missing a ->host_free hook, to
>>free your
>>nv_host_t structure.
>>
>>+ host = kmalloc(sizeof(nv_host_t), GFP_KERNEL);
>
>
> I register a host_stop routine, nv_host_stop(), that frees the host. Is
> this not the correct way to free the nv_host?
I missed the kfree(), sorry.
Jeff
next prev parent reply other threads:[~2004-07-27 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 18:45 [PATCH 2.6.8-rc2] sata_nv.c Andrew Chew
2004-07-27 18:45 ` Andrew Chew
2004-07-27 18:55 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-08-05 22:06 Andrew Chew
2004-08-05 22:06 ` Andrew Chew
2004-08-05 21:31 Andrew Chew
2004-08-05 21:31 ` Andrew Chew
2004-08-05 21:53 ` Jeff Garzik
2004-07-27 20:26 Andrew Chew
2004-07-27 20:26 ` Andrew Chew
2004-07-22 21:38 Andrew Chew
2004-07-22 21:38 ` Andrew Chew
2004-07-27 17:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4106A520.1070604@pobox.com \
--to=jgarzik@pobox.com \
--cc=achew@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.