All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH] usb/usbnet: replace
Date: Wed, 28 Jul 2004 05:23:48 +0000	[thread overview]
Message-ID: <41073864.1050407@pacbell.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. 
> 
> Applys-to: 2.6.7
> 
> Description: Use msleep() instead of schedule_timeout() to 
> guarantee the task delays for the desired time.

Please define and use UNLINK_TIMEOUT_MS, instead.
Or better yet, switch to wait_event() ...


> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> 
> --- linux-vanilla/drivers/usb/net/usbnet.c	2004-06-16 05:19:31.000000000 +0000
> +++ linux-dev/drivers/usb/net/usbnet.c	2004-07-06 01:14:20.000000000 +0000
> @@ -2550,8 +2550,7 @@ static int usbnet_stop (struct net_devic
>  	while (skb_queue_len (&dev->rxq)
>  			&& skb_queue_len (&dev->txq)
>  			&& skb_queue_len (&dev->done)) {
> -		set_current_state (TASK_UNINTERRUPTIBLE);
> -		schedule_timeout (UNLINK_TIMEOUT_JIFFIES);
> +		msleep(jiffies_to_msecs(UNLINK_TIMEOUT_JIFFIES);
>  		devdbg (dev, "waited for %d urb completions", temp);
>  	}
>  	dev->wait = 0;
> 




[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2004-07-28  5:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-28  5:23 David Brownell [this message]
2004-07-28 15:54 ` [Kernel-janitors] Re: [PATCH] usb/usbnet: replace Nishanth Aravamudan
2004-07-28 19:35 ` Nishanth Aravamudan
2004-08-02 21:26 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41073864.1050407@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.