From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Hollomon Date: Wed, 28 Jul 2004 14:51:05 +0000 Subject: Re: [Kernel-janitors] [PATCH] parport/parport_pc: Message-Id: <4107BD59.4030006@comcast.net> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============80273819598493112==" List-Id: References: <20040727211211.GN3471@us.ibm.com> In-Reply-To: <20040727211211.GN3471@us.ibm.com> To: kernel-janitors@vger.kernel.org --===============80273819598493112== Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Nishanth Aravamudan wrote: > I would appreciate any comments from the janitors list. This is one (of > many) cases where I made a decision about replacing > > set_current_state(TASK_INTERRUPTIBLE); > schedule_timeout(some_time); > > with > > msleep(jiffies_to_msecs(some_time)); > > msleep() is not exactly the same as the previous code, but I only did > this replacement where I thought long delays were *desired*. If this is > not the case here, then just disregard this patch. > > Thanks, > Nish > > > > Applys-to: 2.6.7 > > Description: Uses msleep() instead of schedule_timeout() to guarantee > the task delays the desired time. > > Signed-off-by: Nishanth Aravamudan > > --- linux-vanilla/drivers/parport/parport_pc.c 2004-06-16 05:20:04.000000000 +0000 > +++ linux-dev/drivers/parport/parport_pc.c 2004-07-12 22:09:32.000000000 +0000 > @@ -168,8 +168,7 @@ static int change_mode(struct parport *p > if (time_after_eq (jiffies, expire)) > /* The FIFO is stuck. */ > return -EBUSY; > - __set_current_state (TASK_INTERRUPTIBLE); > - schedule_timeout ((HZ + 99) / 100); > + msleep(10); > if (signal_pending (current)) > break; > } Wouldn't the check of signal_pending indicate that the interruptability was intentional? -- -------------------------- Mark Hollomon --===============80273819598493112== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============80273819598493112==--