From: Mark Hollomon <markhollomon@comcast.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] parport/ieee1284:
Date: Wed, 28 Jul 2004 15:57:21 +0000 [thread overview]
Message-ID: <4107CCE1.8050004@comcast.net> (raw)
In-Reply-To: <20040727210821.GL3471@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]
I think TASK_INTERRUPTIBLE is needed here. The top of the loop the
schedule_timeout is in looks for signals.
Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
>
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
>
> with
>
> msleep(jiffies_to_msecs(some_time));
>
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.
>
> Thanks,
> Nish
>
>
>
> Applys-to: 2.6.7
>
> Description: Uses msleep() instead of schedule_timeout() to guarantee
> the task delays the desired time.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- linux-vanilla/drivers/parport/ieee1284.c 2004-06-16 05:18:57.000000000 +0000
> +++ linux-dev/drivers/parport/ieee1284.c 2004-07-12 21:46:18.000000000 +0000
> @@ -212,13 +212,11 @@ int parport_wait_peripheral(struct parpo
> if ((status & mask) == result)
> return 0;
>
> - if (!ret) {
> + if (!ret)
> /* parport_wait_event didn't time out, but the
> * peripheral wasn't actually ready either.
> * Wait for another 10ms. */
> - __set_current_state (TASK_INTERRUPTIBLE);
> - schedule_timeout ((HZ+ 99) / 100);
> - }
> + msleep(10);
> }
>
> return 1;
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors
--
--------------------------
Mark Hollomon
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-07-28 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 21:08 [Kernel-janitors] [PATCH] parport/ieee1284: replace Nishanth Aravamudan
2004-07-27 21:08 ` [Kernel-janitors] [PATCH] parport/ieee1284_ops: replace Nishanth Aravamudan
2004-07-28 15:57 ` Mark Hollomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4107CCE1.8050004@comcast.net \
--to=markhollomon@comcast.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.