All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Willy Tarreau <willy@w.ods.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	greearb@candelatech.com, akpm@osdl.org, alan@redhat.com,
	jgarzik@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: PATCH: VLAN support for 3c59x/3c90x
Date: Sat, 31 Jul 2004 05:34:41 -0400	[thread overview]
Message-ID: <410B67B1.4080906@pobox.com> (raw)
In-Reply-To: <20040731083308.GA24496@alpha.home.local>

Willy Tarreau wrote:
>   - many (all ?) other drivers already have an MTU parameter, and many

s/many/almost none/


>     of them don't have a problem with using generic change_mtu(). So why
>     would this one in particular need such a change ? (and please don't
>     tell me that *I* will have to do this for all others :-))

For VLAN support you definitely want to let the user increase the size 
above 1500, and for that you need ->change_mtu

	Jeff



  parent reply	other threads:[~2004-07-31  9:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-28 12:42 PATCH: VLAN support for 3c59x/3c90x Alan Cox
2004-07-28 21:33 ` Ben Greear
2004-07-28 22:15   ` Alan Cox
2004-07-28 22:30     ` Ben Greear
2004-07-29 17:19       ` Alan Cox
2004-07-28 21:36 ` Andrew Morton
2004-07-28 21:45   ` Ben Greear
2004-07-29  4:18     ` Willy Tarreau
2004-07-30  2:20       ` Herbert Xu
2004-07-30 12:10         ` Willy Tarreau
2004-07-31  3:57           ` Herbert Xu
2004-07-31  8:33             ` Willy Tarreau
     [not found]               ` <200407310846.i6V8k3qq006659@uai.com.br>
2004-07-31  8:57                 ` Willy Tarreau
2004-07-31  9:34               ` Jeff Garzik [this message]
2004-07-31 10:11                 ` Willy Tarreau
2004-07-31 14:12                   ` Matti Aarnio
2004-07-31 16:18                     ` Jeff Garzik
2004-07-31 17:13                       ` Ben Greear
2004-07-31 17:03                     ` Ben Greear
2004-07-31 17:05                       ` Willy Tarreau
2004-07-31 17:21                         ` Ben Greear
2004-07-31 20:16                           ` Lee Revell
2004-07-31 20:23                             ` Willy Tarreau
2004-07-31 20:25                             ` Alan Cox
2004-07-31 20:40                               ` Lee Revell
2004-08-06 12:30                     ` Willy Tarreau
2004-07-31 16:05                   ` Jeff Garzik
2004-07-31 16:12                     ` Willy Tarreau
2004-07-31 16:26                       ` Jeff Garzik
2004-07-31 21:06                         ` PATCH-2.4: MTU fix for tulip driver Willy Tarreau
2004-07-31  9:35               ` PATCH: VLAN support for 3c59x/3c90x Herbert Xu
2004-07-31 10:01                 ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410B67B1.4080906@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.