All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Scholz <steven.scholz@imc-berlin.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Fixed CD in serial.c, AT91RM9200
Date: Tue, 03 Aug 2004 13:34:10 +0200	[thread overview]
Message-ID: <410F7832.8070700@imc-berlin.de> (raw)
In-Reply-To: <20040802232609.F0FAFC109F@atlas.denx.de>

Wolfgang Denk wrote:

> In message <367ED8C46538D7119DAC000A0D106744520D6E@elmegmbh.elmedmn.com> you wrote:
> 
>>is there a reason why the clock divisor in the baudrate generator register
>>(us->US_BRGR) is set to a fixed value in serial_setbrg(void):
>>
>>us->US_BRGR = CFG_AT91C_BRGR_DIVISOR
>>
>>
>>I changed the implementation of serial_setbrg(void) and i can now opperate
>>at higher baudrates. (change baudrate with loadb).
> 
> 
> I have never seen any feedback or comments about this proposal.
> 
> Anybody out there?

I introduced this since it was originally hardcoded to

	us->US_BRGR = 33

for the AT91RM9200DK. The comment says "hardcode so no __divsi3".
I decdided that having a CFG_AT91C_BRGR_DIVISOR in your board specific 
header file would be enough.

I had no time to test Peter's patch yet. But go ahead and apply it. If I 
find problems I'll report them...

-- 
Steven Scholz

  reply	other threads:[~2004-08-03 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-13  7:13 [U-Boot-Users] Fixed CD in serial.c, AT91RM9200 Kögler Peter
2004-08-02 23:26 ` Wolfgang Denk
2004-08-03 11:34   ` Steven Scholz [this message]
2004-08-03 13:29     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410F7832.8070700@imc-berlin.de \
    --to=steven.scholz@imc-berlin.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.