All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marko Macek <Marko.Macek@gmx.net>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Vojtech Pavlik <vojtech@suse.cz>, Jesper Juhl <juhl-lkml@dif.dk>,
	Eric Wong <eric@yhbt.net>, LKML <linux-kernel@vger.kernel.org>,
	david+challenge-response@blue-labs.org
Subject: Re: KVM & mouse wheel [PATCH]
Date: Wed, 04 Aug 2004 21:14:56 +0200	[thread overview]
Message-ID: <411135B0.5040702@gmx.net> (raw)
In-Reply-To: <20040804174140.81473.qmail@web81307.mail.yahoo.com>

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Dmitry Torokhov wrote:

>Anyway, I think that explicitely calling reset-disable after each
>failed probe is a good idea... or maybe not after each probe but just
>once, before probing for generic protocols (imps/exps), like in the
>attached patch.
>  
>
Besides above, the attached patch moves setting the streaming mode
above setting of resolution/rate/scaling.  With that, the mouse works
fine for me in 'imex' mode without any overrides.

Mark



[-- Attachment #2: psmouse-kvm-reset-streaming.patch --]
[-- Type: text/x-patch, Size: 921 bytes --]

--- drivers/input/mouse/psmouse-base.c.orig	2004-08-04 21:02:38.045307096 +0200
+++ drivers/input/mouse/psmouse-base.c	2004-08-04 21:01:38.739322976 +0200
@@ -461,6 +461,12 @@
 			return type;
 	}
 
+/*
+ * Reset to defaults in case the device got confused by extended
+ * protocol probes.
+ */
+	psmouse_command(psmouse, NULL, PSMOUSE_CMD_RESET_DIS);
+
 	if (max_proto >= PSMOUSE_IMEX && im_explorer_detect(psmouse)) {
 
 		if (set_properties) {
@@ -581,6 +587,12 @@
 	unsigned char param[2];
 
 /*
+ * We set the mouse into streaming mode.
+ */
+
+	psmouse_command(psmouse, param, PSMOUSE_CMD_SETSTREAM);
+
+/*
  * We set the mouse report rate, resolution and scaling.
  */
 
@@ -589,12 +601,6 @@
 		psmouse_set_resolution(psmouse);
 		psmouse_command(psmouse,  NULL, PSMOUSE_CMD_SETSCALE11);
 	}
-
-/*
- * We set the mouse into streaming mode.
- */
-
-	psmouse_command(psmouse, param, PSMOUSE_CMD_SETSTREAM);
 }
 
 /*

      reply	other threads:[~2004-08-04 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-04 17:41 KVM & mouse wheel Dmitry Torokhov
2004-08-04 19:14 ` Marko Macek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=411135B0.5040702@gmx.net \
    --to=marko.macek@gmx.net \
    --cc=david+challenge-response@blue-labs.org \
    --cc=dtor_core@ameritech.net \
    --cc=eric@yhbt.net \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.