From: Pablo Neira <pablo@eurodev.net>
To: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Harald Welte <laforge@netfilter.org>,
Patrick McHardy <kaber@trash.net>
Subject: [PATCH] ip_queue and fragments
Date: Thu, 05 Aug 2004 15:32:47 +0200 [thread overview]
Message-ID: <411236FF.4080405@eurodev.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 121 bytes --]
Hi,
I've tracing ip_queue source code and I think that it's not fragment
aware. Am I missing anything?
regards,
Pablo
[-- Attachment #2: ip_queue_frags.patch --]
[-- Type: text/x-patch, Size: 537 bytes --]
diff -u -r1.1.1.1 ip_queue.c
--- a/net/ipv4/netfilter/ip_queue.c 11 May 2004 13:07:08 -0000 1.1.1.1
+++ b/net/ipv4/netfilter/ip_queue.c 4 Aug 2004 14:37:25 -0000
@@ -255,9 +255,10 @@
entry->skb->dev->hard_header_parse(entry->skb,
pmsg->hw_addr);
}
-
- if (data_len)
- memcpy(pmsg->payload, entry->skb->data, data_len);
+
+ if (data_len)
+ if (skb_copy_bits(entry->skb, 0, pmsg->payload, data_len) != 0)
+ goto nlmsg_failure;
nlh->nlmsg_len = skb->tail - old_tail;
return skb;
next reply other threads:[~2004-08-05 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 13:32 Pablo Neira [this message]
2004-08-05 14:16 ` [PATCH] ip_queue and fragments Patrick McHardy
2004-08-06 16:44 ` Pablo Neira
2004-08-07 19:20 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411236FF.4080405@eurodev.net \
--to=pablo@eurodev.net \
--cc=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.