From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 1/3] cli_hush.c: refactor handle_dollar() to prepare for cmd_call
Date: Fri, 25 Sep 2020 15:02:20 +0200 [thread overview]
Message-ID: <4118589.1601038940@gemini.denx.de> (raw)
In-Reply-To: <20200925111942.4629-2-rasmus.villemoes@prevas.dk>
Dear Rasmus,
In message <20200925111942.4629-2-rasmus.villemoes@prevas.dk> you wrote:
> A later patch will add handling of $1 through $9 as well as $#, using
> the same SPECIAL_VAR_SYMBOL handling as is currently used for $?. So
> move that case to an explicit #ifdef __U_BOOT__ branch, and
> consolidate a few of the #ifndef __U_BOOT__ cases, making it easier to
> see the original hush code.
I won't comment on these and the other patches - you know my
opinion: instead of hacking the current code, we should 1) come up
with a plan and 2) update.
Please consider this a soft-NAK ;-)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The good Christian should beware of mathematicians and all those who
make empty prophecies. The danger already exists that mathematicians
have made a covenant with the devil to darken the spirit and confine
man in the bonds of Hell." - Saint Augustine
next prev parent reply other threads:[~2020-09-25 13:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 11:19 [PATCH 0/3] add "call" command Rasmus Villemoes
2020-09-25 11:19 ` [PATCH 1/3] cli_hush.c: refactor handle_dollar() to prepare for cmd_call Rasmus Villemoes
2020-09-25 13:02 ` Wolfgang Denk [this message]
2020-09-25 11:19 ` [PATCH 2/3] cli_hush.c: add "call" command Rasmus Villemoes
2020-09-25 13:18 ` Rasmus Villemoes
2020-09-26 8:37 ` Wolfgang Denk
2020-09-25 11:19 ` [PATCH 3/3] ut: add small hush tests Rasmus Villemoes
2020-09-25 11:52 ` [PATCH 0/3] add "call" command Heinrich Schuchardt
2020-09-25 12:36 ` Rasmus Villemoes
2020-09-25 13:09 ` Wolfgang Denk
2020-09-25 13:38 ` Rasmus Villemoes
2020-09-25 13:38 ` Heinrich Schuchardt
2020-09-25 13:51 ` Rasmus Villemoes
2020-09-26 8:55 ` Wolfgang Denk
2020-09-26 8:51 ` Wolfgang Denk
2020-09-26 10:39 ` Heinrich Schuchardt
2020-09-26 14:13 ` Wolfgang Denk
2020-09-25 12:59 ` Wolfgang Denk
2020-09-25 14:40 ` Simon Glass
2020-09-26 14:02 ` Wolfgang Denk
2020-09-29 17:45 ` Tom Rini
2020-09-30 11:46 ` Wolfgang Denk
2020-10-07 7:20 ` [PATCH v2 0/3] allow positional arguments with "run" Rasmus Villemoes
2020-10-07 7:20 ` [PATCH v2 1/3] cli_hush.c: refactor handle_dollar() to prepare for "run with arguments" Rasmus Villemoes
2020-10-12 3:34 ` Simon Glass
2020-10-07 7:20 ` [PATCH v2 2/3] allow positional arguments with "run" command Rasmus Villemoes
2020-10-12 3:34 ` Simon Glass
2020-10-12 7:06 ` Rasmus Villemoes
2020-10-15 15:05 ` Simon Glass
2020-10-15 22:06 ` Rasmus Villemoes
2020-10-19 7:31 ` Wolfgang Denk
2020-10-19 8:31 ` Rasmus Villemoes
2020-10-19 8:49 ` Wolfgang Denk
2020-10-07 7:20 ` [PATCH v2 3/3] ut: add small hush tests Rasmus Villemoes
2020-10-12 3:34 ` Simon Glass
2020-11-05 7:25 ` [PATCH v2 0/3] allow positional arguments with "run" Rasmus Villemoes
2020-11-06 20:52 ` Tom Rini
2020-11-08 13:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4118589.1601038940@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.